Commit graph

55 commits

Author SHA1 Message Date
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen 713606271c Rename fail macros in Obj-C. 2018-08-27 10:29:51 -04:00
Michael Kirk 7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
2018-08-24 08:54:23 -06:00
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
2018-08-22 12:00:44 -06:00
Matthew Chen 8daaef22da Add custom themed search bar. 2018-08-17 12:43:35 -04:00
Matthew Chen a76d488e8b Fix QA issues in theme. 2018-08-15 17:09:59 -04:00
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
2018-08-09 15:30:19 -06:00
Matthew Chen 3fc3425605 Theme search bars. 2018-08-09 14:02:29 -04:00
Matthew Chen 6dfe36f9b5 Respond to CR. 2018-08-08 15:49:22 -04:00
Matthew Chen 579e88bdc2 Improve nullability handling for SignalAccount. 2018-08-01 09:22:56 -04:00
Matthew Chen f795b12a86 Refine theme. 2018-07-26 09:42:48 -04:00
Matthew Chen 2b1f928770 Respond to CR. 2018-07-20 15:47:37 -04:00
Matthew Chen 48975eaac8 Respond to CR. 2018-07-20 15:37:47 -04:00
Matthew Chen 8862f9a531 Refine views. 2018-07-20 15:26:46 -04:00
Matthew Chen 9f9e0965d5 Refine table views. 2018-07-20 15:26:46 -04:00
Michael Kirk baacebc956 Enable (quick) static analyzer for normal builds
// FREEBIE
2018-07-18 10:24:08 -06:00
Michael Kirk c53f777bc1 CR: explanatory comment 2018-07-16 13:51:22 -06:00
Michael Kirk 898d64ae1c Fix compose picker content scrolls behind navbar
// FREEBIE
2018-07-16 13:51:22 -06:00
Michael Kirk 104e63ded9 remove appearance juggling 2018-06-29 16:27:37 -06:00
Matthew Chen 1acf51ea5c Unify the cell and avatar sizes. 2018-06-15 11:08:01 -04:00
Matthew Chen c1e1a52695 Auto-size contact cells everywhere. 2018-06-15 10:01:16 -04:00
Matthew Chen dd49c6225f Auto-size contact cells everywhere. 2018-06-15 10:01:16 -04:00
Matthew Chen 3f9f2abcd8 Style the search results. 2018-06-13 12:34:24 -04:00
Matthew Chen f4a559156c Style the search results. 2018-06-13 12:34:24 -04:00
Matthew Chen 3cd6a33aa6 Fix build warnings. 2018-06-01 12:39:13 -04:00
Michael Kirk 33eb4c38cd Centralize translucency configuration
// FREEBIE
2018-05-24 12:28:20 -04:00
Matthew Chen 91d54360ba Add contact view. 2018-05-03 14:09:54 -04:00
Matthew Chen fe9a61117c Rework archived conversations mode of home view. 2018-04-24 11:29:24 -04:00
Michael Kirk 86553b62f9 keyboard pinning vs iPhoneX 2018-04-02 17:38:13 -04:00
Michael Kirk 394cc6637c Backport comments from translations
// FREEBIE
2018-03-26 10:12:04 -04:00
Matthew Chen 593f7da72d Upload test file to CloudKit. 2018-03-12 16:40:07 -03:00
Matthew Chen 4b62faf2f8 Aggressively nag iOS 8 users to upgrade iOS. 2018-02-14 14:15:23 -05:00
Matthew Chen 9258b0883e Clean up TSStorageManager usage. 2017-12-19 11:41:31 -05:00
Matthew Chen 9a990b58e8 Respond to CR. 2017-12-19 11:38:25 -05:00
Michael Kirk 157bf00410 Merge branch 'hotfix/2.19.3' 2017-12-17 14:02:03 -05:00
Michael Kirk e78edcde87 Only clear cache when user pulls-to-refresh
// FREEBIE
2017-12-16 12:01:19 -05:00
Michael Kirk 49196f8013 Spin activity indicator until contacts are fetched
// FREEBIE
2017-12-15 16:31:53 -05:00
Michael Kirk 4f06518539 Merge tag '2.19.3.1' 2017-12-14 16:21:41 -05:00
Michael Kirk 1f8042685d Show loading cell when contacts are still loading.
// FREEBIE
2017-12-14 13:53:02 -05:00
Michael Kirk d9cca77e23 update header references
// FREEBIE
2017-12-08 13:32:52 -05:00
Matthew Chen b4e8df79da Migrate environment to SignalMessaging. 2017-12-05 10:29:29 -05:00
Matthew Chen c817aa51b3 Migrate environment to SignalMessaging. 2017-12-05 10:28:46 -05:00
Michael Kirk cd440b839f Consolidate search logic
// FREEBIE
2017-12-04 13:53:10 -05:00
Matthew Chen a07e1e0cf9 For most views, only try to dismiss keyboard when scroll drag starts. 2017-11-20 17:17:49 -05:00
Michael Kirk 8c69e00a3f Adapt ConversationViewController to iPhoneX
// FREEBIE
2017-11-14 12:37:09 -05:00
Matthew Chen 6e840ff956 Fix build warnings from XCode 9. 2017-11-09 02:52:44 -05:00
Matthew Chen 1b3b5fc9e5 Respond to CR.
// FREEBIE
2017-10-26 11:53:35 -04:00
Matthew Chen be0149ccf2 Update layout of views to reflect keyboard.
// FREEBIE
2017-10-24 17:10:12 -04:00
Michael Kirk 038ca0d6a9 Fix invite via SMS in search
- whispersystems.org -> signal.org
- nav color was wrong since iOS10
- update search results after clearing post SMS invite

// FREEBIE
2017-10-16 12:25:48 -07:00