Commit graph

1063 commits

Author SHA1 Message Date
Matthew Chen
4d89670f19 Fix UD auth edge cases. 2018-10-18 11:21:16 -04:00
Matthew Chen
0add39c2a8 Respond to CR. 2018-10-16 17:45:31 -04:00
Matthew Chen
275414cbda Respond to CR. 2018-10-16 17:42:54 -04:00
Matthew Chen
7c1f1882d8 Sync "show UD indicators" setting. 2018-10-16 17:42:54 -04:00
Matthew Chen
2b8c70ef9e Fix UD attributes migration completion. 2018-10-16 17:08:31 -04:00
Matthew Chen
f1646b6cbc Move db connections to environments. 2018-10-16 13:00:50 -04:00
Matthew Chen
829851bd7b Hang PushManager on AppEnvironment. 2018-10-16 11:47:54 -04:00
Matthew Chen
32cf68bece Get all tests building. 2018-10-15 12:50:07 -04:00
Matthew Chen
603e3bf0b6 Move SM singletons to Environment. 2018-10-15 11:34:42 -04:00
Michael Kirk
d6a6024f37 Update PromiseKit 2018-10-13 16:04:20 -06:00
Michael Kirk
c425aa9493 dont rotate profile keys for unregistered user 2018-10-12 15:55:41 -06:00
Matthew Chen
c9922cda3e Respond to CR. 2018-10-12 17:38:13 -04:00
Matthew Chen
8fdf6009f9 Sync contacts after rotating profile key. 2018-10-12 17:19:00 -04:00
Matthew Chen
eb7abdfc64 Account attributes updates. 2018-10-12 17:19:00 -04:00
Matthew Chen
f1d93d4472 Merge remote-tracking branch 'origin/release/2.30.2' 2018-10-12 16:00:42 -04:00
Michael Kirk
d5f69e4bba feature flag for group avatar color 2018-10-12 15:32:03 -04:00
Matthew Chen
010ce1f6c2 Rename to OWSOutgoingReceiptManager. 2018-10-12 13:52:46 -04:00
Matthew Chen
13373db3bc Send delivery receipts. 2018-10-12 13:52:46 -04:00
Michael Kirk
e7170dc6e8 conventional error structure for connectivity error 2018-10-12 11:06:21 -06:00
Matthew Chen
794914353d Respond to CR. 2018-10-11 13:07:25 -04:00
Matthew Chen
f00f608833 Respond to CR. 2018-10-11 13:02:02 -04:00
Matthew Chen
f7827cda7b Respond to CR. 2018-10-11 13:02:02 -04:00
Matthew Chen
0ce2e4d4d9 Rotate profile key if blocklist intersects profile whitelist. 2018-10-11 13:02:02 -04:00
Matthew Chen
c907721a18 Rotate profile key if blocklist intersects profile whitelist. 2018-10-11 13:02:02 -04:00
Michael Kirk
1544f8db46 Optionally show UD status in message details 2018-10-11 09:04:35 -06:00
Matthew Chen
9323e411fc Revert AppReadiness singleton. 2018-10-11 09:42:49 -04:00
Matthew Chen
27700ef78f Revert AppVersion singleton. 2018-10-11 09:36:47 -04:00
Matthew Chen
f24ccb3ce6 Hang more singletons on SSKEnv. 2018-10-11 08:56:50 -04:00
Matthew Chen
03f23b5f79 Fix breakage in UD manager; add UD manager test, hang TSAccountManager on SSKEnv, fix bugs in tests. 2018-10-11 08:46:24 -04:00
Michael Kirk
fb2abdcd1a UD auth for profile fetching
Converging with Android, use UnidentifiedAccess getter
2018-10-10 09:09:11 -06:00
Michael Kirk
0be1f8cca2 Move UD auth into request initializers 2018-10-10 09:09:11 -06:00
Michael Kirk
39ba413439 Track UD mode enum instead of two booleans 2018-10-10 09:09:11 -06:00
Matthew Chen
fab79e2673 Respond to CR. 2018-10-10 09:59:10 -04:00
Matthew Chen
283cb18288 Re-run UD attributes migration. 2018-10-10 09:10:45 -04:00
Matthew Chen
d9c8a218bc Use local profile data for the local phone number. 2018-10-10 09:10:45 -04:00
Matthew Chen
23088e4121 Remove overzealous assert in theme. 2018-10-10 09:10:18 -04:00
Matthew Chen
17541a8888 Change conversation bubble colors. 2018-10-09 16:06:23 -04:00
Matthew Chen
01f63792f8 Respond to CR. 2018-10-05 13:19:46 -04:00
Matthew Chen
7cb0158331 Apply UD access verifier. 2018-10-05 13:14:45 -04:00
Matthew Chen
3b06434d4f Split out second web socket. 2018-10-05 12:48:19 -04:00
Matthew Chen
c137e95ae5 Move socket manager to hang on SSKEnvironment. 2018-10-05 12:47:11 -04:00
Matthew Chen
a697072271 Respond to CR. 2018-10-05 10:32:32 -04:00
Michael Kirk
2b805e4eae Constantize ConversationColorName, map previous incorrect values 2018-10-04 18:21:35 -06:00
Michael Kirk
d59e21e7f0 Nothing outside of TSThread should know about legacy colors 2018-10-04 17:07:50 -06:00
Michael Kirk
405cc31a38 Apply new colors to new conversation 2018-10-04 10:34:57 -06:00
Matthew Chen
ccb67f49a3 Fix issues in UD send & receive. 2018-10-04 11:56:37 -04:00
Matthew Chen
0b41e5e240 Rework profile fetch to reflect UD changes. 2018-10-04 11:56:37 -04:00
Michael Kirk
f243914fe5 NSTemporaryDirectory -> OWSTemporaryDirectory/AccessibleAfterFirstAuth
Remove redundant move - AFNetworking alread moves the CFNetwork tmp file for
us.
2018-10-03 14:01:36 -06:00
Matthew Chen
3eb84ed0e0 Move message processing singletons to SSKEnvironment. 2018-10-03 09:25:29 -04:00
Matthew Chen
4ab281346a Respond to CR. 2018-10-03 09:09:24 -04:00
Matthew Chen
95387dd220 Fix rebase breakage. 2018-10-03 08:59:55 -04:00
Matthew Chen
1d40cbfb41 Rework account attributes; persist manual message fetch; add "unrestricted UD" setting. 2018-10-03 08:59:55 -04:00
Matthew Chen
7fd15d2fd9 Add server certificate methods to UD manager. 2018-10-02 13:24:00 -04:00
Matthew Chen
71da312336 Post-SMK ud changes. 2018-10-02 13:19:41 -04:00
Michael Kirk
8faf8668bd lighter sheetview handle for dark theme 2018-10-02 09:49:37 -06:00
Michael Kirk
043b0c8359 swipe to dismiss sheet view 2018-10-02 09:49:37 -06:00
Matthew Chen
24d7a97616 Fix rebase breakage. 2018-10-01 09:08:41 -04:00
Matthew Chen
3738155c81 Fix build breakage from SMK. 2018-10-01 09:08:02 -04:00
Matthew Chen
8ae200ac21 Fix build breakage around SignalCoreKit. 2018-10-01 09:07:40 -04:00
Matthew Chen
0125535d4d Pull out SignalCoreKit. 2018-10-01 09:06:40 -04:00
Michael Kirk
06eae47e09 ConversationViewItem -> protocol 2018-09-28 12:58:33 -06:00
Matthew Chen
ebae75af00 Revert 'new sort id'. 2018-09-27 19:40:51 -04:00
Matthew Chen
b076f14964 Swift exit(). 2018-09-27 16:56:54 -04:00
Matthew Chen
1e82caed03 Remove dark theme feature flag. 2018-09-27 15:41:43 -04:00
Matthew Chen
fbeb07d2e4 Fix build break. 2018-09-27 15:40:55 -04:00
Michael Kirk
acd042c35a Sort conversation colors 2018-09-27 13:34:23 -06:00
Michael Kirk
4765ed9a06 Color picker
TODO

-[x] tap to select/deselect
-[x] initially selected
-[x] integrate into conversation settings
-[x] colorPickerDelegate
-[x] translate strings
-[] reorder colors
-[x] SheetView: add top handle

Nice to have:

-[] SheetView: interactively swipe/unswipe to dismiss?
-[] preview color in bubbles
2018-09-27 13:34:23 -06:00
Michael Kirk
95a6df6496 Generic SheetViewController 2018-09-27 13:34:23 -06:00
Joshua Lund
97d0543cef String cleanup:
* Made our Title Case usage a little more consistent.
* Standardized on the ellipses special character.
* Rephrased a few buttons and descriptions.
2018-09-27 15:30:58 -04:00
Michael Kirk
79add78d51 Merge branch 'release/2.30.1' 2018-09-27 13:03:35 -06:00
Michael Kirk
3518d37c3e use autorelease pool in migration to avoid accumulating memory 2018-09-27 10:30:28 -06:00
Matthew Chen
2b75c4034d Pull out OWSConversationColor to its own file. 2018-09-27 12:24:14 -04:00
Matthew Chen
5a99cd347f Pull out OWSConversationColor to its own file. 2018-09-27 12:24:14 -04:00
Matthew Chen
43dc362fc7 Fix secondary color within message bubbles. 2018-09-27 12:22:52 -04:00
Matthew Chen
0e5f42defe Use new asset for default contact avatars. 2018-09-27 12:22:14 -04:00
Matthew Chen
857cdf4368 Map the legacy conversation color names. 2018-09-27 11:26:21 -04:00
Matthew Chen
ec0206ff01 Adapt text size of default avatars to avatar size. 2018-09-27 11:25:18 -04:00
Matthew Chen
6d14a1b472 Local profile default avatars should use steel background. 2018-09-27 11:24:20 -04:00
Matthew Chen
27488f078a Replace old "default profile avatar" icon with default avatar for local user. 2018-09-27 11:24:20 -04:00
Matthew Chen
e4ab360716 Respond to CR. 2018-09-27 10:43:50 -04:00
Matthew Chen
547724b5cf Add inner shadows to profile pics. 2018-09-27 09:41:42 -04:00
Matthew Chen
352777765e Add inner shadows to profile pics. 2018-09-27 09:41:42 -04:00
Matthew Chen
ff6feafe8c Update text colors. 2018-09-27 09:30:59 -04:00
Matthew Chen
6715e3d1ad Respond to CR. 2018-09-27 09:28:16 -04:00
Matthew Chen
b20cd57383 Rename OWSConversationColor. 2018-09-27 09:15:15 -04:00
Matthew Chen
3adc03fa2c Rework conversation message bubble colors; add "conversation colors" class. 2018-09-27 09:07:47 -04:00
Matthew Chen
b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 2018-09-27 09:07:47 -04:00
Matthew Chen
26a2d568de Add "conversation color mode" enum. 2018-09-27 09:07:47 -04:00
Matthew Chen
e5150267c2 Rework the conversation color constants. 2018-09-27 09:07:47 -04:00
Matthew Chen
da63731447 Respond to CR. 2018-09-27 09:07:03 -04:00
Matthew Chen
8db4595bdc Rework group avatars to reflect conversation colors. 2018-09-27 08:55:20 -04:00
Matthew Chen
1c920c6be6 Rework group avatars to reflect conversation colors. 2018-09-27 08:55:20 -04:00
Matthew Chen
25d56b30c1 Rework group avatars to reflect conversation colors. 2018-09-27 08:55:20 -04:00
Matthew Chen
2f9eae5caf Respond to CR. 2018-09-27 08:50:52 -04:00
Michael Kirk
04a52980a3 fixup migration
- nested transaction for enumeration
- save when complete
2018-09-26 09:55:23 -06:00
Michael Kirk
fe7d69e9c6 Update thread's sorting order based on whatever the currently last message is 2018-09-26 09:52:34 -06:00
Michael Kirk
c2f87c738a trivial replace of timestampForSorting -> sortId in some logging 2018-09-26 09:52:34 -06:00
Michael Kirk
6f8eddc955 unread indicator uses sortId
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state

1. `unreadIndicator.firstUnseenTimestamp`:
    the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
    the timestamp of the first interaction *after* the unread indicator that fits in the loading window

We don't actually need to track `2` because it was only used in a comparison like:

   viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp

But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.

In other words, there's no situation where

   viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
2018-09-26 09:52:34 -06:00
Michael Kirk
2eb3ec6d0c benchmark migration 2018-09-26 09:52:34 -06:00
Michael Kirk
b281b37637 replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId
Update migration accordingly

Date shown on home view cell is message.receivedAt
2018-09-26 09:52:34 -06:00
Michael Kirk
c27d35f8f2 sort search results by sortId 2018-09-26 09:52:34 -06:00
Michael Kirk
ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
2018-09-26 09:52:33 -06:00
Michael Kirk
df61316495 minimize diff senderTimestamp -> timestamp 2018-09-26 09:52:33 -06:00
Michael Kirk
00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
2018-09-26 09:52:33 -06:00
Michael Kirk
eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
2018-09-26 09:52:33 -06:00
Michael Kirk
6c5fbc6de5 Update existing contact offers in place
WIP: migration / autoincrement logic

TODO:

-[x] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?

fixup contact offers
2018-09-26 09:52:33 -06:00
Michael Kirk
a60d8eb161 WIP: migration / autoincrement logic
TODO:

-[ ] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?
2018-09-26 09:52:33 -06:00
Matthew Chen
7b2dd19fb8 Respond to CR. 2018-09-25 16:11:37 -04:00
Matthew Chen
ae84528dc3 Update avatar colors; add shaded conversation color constants, modify color picker to be color-name-based, not color-based, use shaded conversation colors, remove JSQ. 2018-09-25 16:11:37 -04:00
Matthew Chen
87836f506b Move more singletons to SSKEnvironment. 2018-09-21 09:06:48 -04:00
Matthew Chen
6a712366ae Tweak gray 95. 2018-09-20 10:15:09 -04:00
Matthew Chen
922c505559 Respond to CR. 2018-09-20 10:14:20 -04:00
Matthew Chen
ef6689410b Design feedback from Myles. 2018-09-20 10:14:20 -04:00
Matthew Chen
8cf5f3e58f New grayscale palette. 2018-09-20 10:14:20 -04:00
Matthew Chen
3b2c5bfc7b Modify mock environments to register all db views. 2018-09-19 16:29:15 -04:00
Matthew Chen
e1db60c1c0 Rework creation of singletons. 2018-09-19 15:11:26 -04:00
Michael Kirk
21e67e9a1d New resolutions for call banner, rename to accommodate multiple X devices.
Only apply work-around to legacy versions where required.
2018-09-19 11:17:40 -06:00
Michael Kirk
3df0e72eda Extract SPK rotation and CreatePreKey operations 2018-09-17 10:10:32 -06:00
Michael Kirk
920a82564f Merge tag '2.29.3.3' 2018-09-15 09:17:08 -05:00
Michael Kirk
e7f9598e68 disable dark theme switch for production 2018-09-14 17:45:32 -05:00
Matthew Chen
9b94580dae Update assertions.
* Streamline precompiled headers.
* Remove obsolete assertions in Constraints.h.
2018-09-14 14:30:06 -04:00
Michael Kirk
df67e883f3 BlockList vs. "zero length" group names 2018-09-14 11:32:39 -05:00
Michael Kirk
b447e68597 clarify post-unblock-group copy 2018-09-14 11:09:14 -05:00
Michael Kirk
c1b88b5f48 copy cleanup: remove redundant body 2018-09-14 10:52:01 -05:00
Michael Kirk
0f9b0936df Use cached group details when rendering blocklist 2018-09-14 10:31:17 -05:00
Michael Kirk
1f15ba6dc5 Cache group details on blocking manager
In case the group thread is later deleted.
2018-09-14 10:31:17 -05:00
Michael Kirk
c0991fce74 enable dark theme for beta 2018-09-12 19:21:14 -05:00
Michael Kirk
7b7da4bc13 add docs to BlockListCache 2018-09-12 19:16:14 -05:00
Michael Kirk
fd492f379a Use BlockListCache where possible 2018-09-12 19:16:14 -05:00
Michael Kirk
2c49232db0 remove barely used getters
Lock contention on these methods is less important because we're not iterating
over their access, e.g. per tableViewCell
2018-09-12 19:16:14 -05:00
Michael Kirk
448936d156 BlockListCache
block manager synchronizes on self for coherent read/writes to blocking state
across threads, but we want to be able to have performant reads on the main
thread.
2018-09-12 19:16:14 -05:00
Michael Kirk
28d28cf2b6 remove unused code 2018-09-12 19:16:14 -05:00
Michael Kirk
b6eb1476cb Leave group when blocking it 2018-09-12 19:16:14 -05:00
Michael Kirk
8aba5725cf BlockListViewController v. group blocking 2018-09-12 19:16:14 -05:00
Michael Kirk
c6de8c579c WIP: Localizations 2018-09-12 19:16:14 -05:00
Michael Kirk
eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
2018-09-12 19:16:14 -05:00
Michael Kirk
236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
2018-09-12 19:16:14 -05:00
Matthew Chen
3935b019f4 Add base class for tests. 2018-09-10 17:30:18 -05:00
Matthew Chen
3fe7d7f9be Remove more usage of logTag. 2018-09-10 17:25:46 -05:00
Michael Kirk
5bafc7b6d6 Don't allow enabling dark theme in production yet 2018-09-07 16:36:24 -06:00
Matthew Chen
df7acfeed3 Simplify OWSPreferences access. 2018-09-07 16:28:21 -04:00
Matthew Chen
106ecf2e8e Respond to CR. 2018-09-07 16:25:10 -04:00
Matthew Chen
cc117b385c Modify environment accessors to use our 'shared' convention. 2018-09-07 16:20:59 -04:00
Matthew Chen
3a12446be8 Modify environment accessors to use our 'shared' convention. 2018-09-07 16:20:41 -04:00
Matthew Chen
bd05cdc031 Rename TextSecureKitEnv to SSKEnvironment. 2018-09-07 16:19:00 -04:00
Matthew Chen
f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 2018-09-07 15:27:50 -04:00
Michael Kirk
c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
2018-09-07 10:00:48 -06:00
Matthew Chen
34a05cdb85 Refine image validation. 2018-09-06 16:04:01 -04:00
Matthew Chen
51e8fdcb25 Use small thumbnail when creating quoted reply. 2018-09-06 16:03:29 -04:00
Matthew Chen
206432fdf0 Add failure methods to thumbnail service. 2018-09-06 15:30:00 -04:00
Matthew Chen
3437361d70 Use new thumbnails in media gallery thumbnails. 2018-09-06 15:30:00 -04:00
Matthew Chen
ac4365e1c9 Add OWSThumbnailService. 2018-09-06 15:30:00 -04:00
Matthew Chen
446ceb2b9c Rename AttachmentStream methods. 2018-09-06 15:30:00 -04:00
Matthew Chen
498828f93c Rename AttachmentStream methods. 2018-09-06 15:30:00 -04:00
Matthew Chen
9ab4da5c81 cherry-pick Merge branch 'charlesmchen/logSdp' 2018-09-04 13:51:31 -06:00
Matthew Chen
fac7f6932f Rename TSGroupMetaMessage enum values. 2018-09-04 09:30:01 -04:00
Matthew Chen
f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 2018-09-04 09:27:41 -04:00
Michael Kirk
d6f856a626 fixup: Leave theme enabled if ever enabled 2018-08-31 16:58:28 -06:00
Michael Kirk
4e19a79436 Leave theme enabled if ever enabled 2018-08-31 16:55:23 -06:00
Michael Kirk
64dd7c79ed enable dark theme for beta 2018-08-31 16:54:12 -06:00
Michael Kirk
e715bf9ea2 image sizing
Validate image sizing
2018-08-30 19:21:38 -06:00
Matthew Chen
f473f60111 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
cc5a480baa Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
03829779cc Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
c0d486b1f1 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
3a50377902 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
0b5b74a901 Respond to CR. 2018-08-27 10:49:26 -04:00
Matthew Chen
b4539328e1 Log call session description. 2018-08-27 10:49:25 -04:00
Matthew Chen
2d06c05a4f Log call session description. 2018-08-27 10:49:25 -04:00
Matthew Chen
713606271c Rename fail macros in Obj-C. 2018-08-27 10:29:51 -04:00
Matthew Chen
5b50e81b4f Rename fail macros in Swift. 2018-08-27 10:27:48 -04:00
Matthew Chen
7be8f30877 Apply -> Never. 2018-08-27 10:21:03 -04:00
Matthew Chen
d4f7b5d45b Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen
e1049fdfcc Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen
cf6f3841a8 Apply new Swift logging. 2018-08-27 10:02:28 -04:00
Michael Kirk
1a92f414eb Revert "Disable dark theme in production."
This reverts commit 472a92a1a3.
2018-08-24 16:22:28 -06:00
Michael Kirk
1d2590fa12 Merge tag '2.29.0.17' 2018-08-24 16:22:07 -06:00
Michael Kirk
bc2ba63c21 DRY refactor 2018-08-23 10:39:55 -06:00
Michael Kirk
37738c24c5 Allow menuActions + callBanner
// FREEBIE
2018-08-23 10:39:55 -06:00
Michael Kirk
82e559d11b Use swift macros for main thread assert 2018-08-23 10:29:49 -06:00
Matthew Chen
cb827169fb Respond to CR. 2018-08-22 16:30:12 -04:00
Matthew Chen
472a92a1a3 Disable dark theme in production. 2018-08-22 16:07:09 -04:00
Michael Kirk
1743407cc2 Code cleanup per code review 2018-08-22 12:54:22 -06:00
Michael Kirk
3022f92925 Tweak tint for search bar icons in dark theme 2018-08-22 12:00:44 -06:00
Michael Kirk
75bb9b60db Alternative dark theme search bar
Rather than our custom class, we can get pretty far using existing UISearchBar
styling, and then apply the final tweak, the search bar text field background
color by traversing the view.

This fixes a couple issues:

1. There was a small wavering in height of the custom search bar
2. When your table header view is a UISearchBar you get nice scroll "snapping"
   when showing/hiding the search bar.
2018-08-22 12:00:44 -06:00
Michael Kirk
e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
2018-08-22 12:00:44 -06:00
Matthew Chen
4971d40c75 Respond to CR. 2018-08-21 16:36:58 -04:00
Matthew Chen
9e21612298 Respond to CR. 2018-08-21 16:35:25 -04:00
Matthew Chen
6dd474d794 Theme quoted replies. 2018-08-21 16:34:37 -04:00
Matthew Chen
a92fca5c13 Theme quoted replies. 2018-08-21 16:34:37 -04:00
Michael Kirk
b80d88c824 theme attachment approval keyboard
// FREEBIE
2018-08-20 12:26:48 -06:00
Matthew Chen
c7ed09ed91 Fix 'can't delete formatting in phone number' issue. 2018-08-17 14:25:34 -04:00
Matthew Chen
8daaef22da Add custom themed search bar. 2018-08-17 12:43:35 -04:00
Matthew Chen
decb0c54ca Theme review. 2018-08-16 17:30:08 -04:00
Matthew Chen
d62e07d6f1 Theme review. 2018-08-16 17:30:08 -04:00
Matthew Chen
4ea5d9b849 Theme review. 2018-08-16 17:30:07 -04:00
Matthew Chen
a76d488e8b Fix QA issues in theme. 2018-08-15 17:09:59 -04:00
Matthew Chen
22dda476bb Fix QA issues in theme. 2018-08-15 16:29:13 -04:00
Matthew Chen
26001e49d1 Unify log tags. 2018-08-15 10:24:29 -04:00
Michael Kirk
71cb90b575 Avoid incremental theme-redraws
IMO this feels more impressive
2018-08-10 17:00:35 -06:00