Commit graph

5749 commits

Author SHA1 Message Date
Matthew Chen ec32d8839b "Bump build to 2.20.0.40." 2018-02-22 16:31:37 -05:00
Matthew Chen e0793a0eae Merge branch 'charlesmchen/backgroundVsMigration' 2018-02-22 16:21:54 -05:00
Matthew Chen 5235f97953 Use background task while migrating. 2018-02-22 16:21:48 -05:00
Matthew Chen 8ec9540b8f Merge branch 'charlesmchen/handleCaptions' 2018-02-22 16:12:58 -05:00
Matthew Chen 10ca369da8 Respond to CR. 2018-02-22 16:12:39 -05:00
Matthew Chen 6006d22870 Improve handling of attachments with captions. 2018-02-22 16:03:00 -05:00
Matthew Chen 8576da791c Improve handling of attachments with captions. 2018-02-22 16:03:00 -05:00
Matthew Chen 96b5f22799 Improve handling of attachments with captions. 2018-02-22 16:03:00 -05:00
Matthew Chen d30dd22040 "Bump build to 2.20.0.39." 2018-02-22 13:31:45 -05:00
Matthew Chen 81629a87df Fix build break. 2018-02-22 13:31:41 -05:00
Matthew Chen 5e88110a0b "Bump build to 2.20.0.38." 2018-02-22 13:30:51 -05:00
Matthew Chen 8e9261e1ba "Bump build to 2.20.0.37." 2018-02-22 13:30:15 -05:00
Matthew Chen 708ff7efbd "Bump build to 2.20.0.36." 2018-02-22 13:28:23 -05:00
Matthew Chen 1112f7a644 Merge branch 'charlesmchen/conversationViewVsModifiedExternal' 2018-02-22 12:10:48 -05:00
Matthew Chen 152c570900 Respond to CR. 2018-02-22 12:07:11 -05:00
Matthew Chen 03670b4868 Rename the view horizon. 2018-02-22 11:46:08 -05:00
Matthew Chen fabbe46114 Clean up ahead of PR. 2018-02-22 11:46:08 -05:00
Matthew Chen 4e1e232825 Flush writes from other processes. 2018-02-22 11:46:08 -05:00
Matthew Chen 1ff4f85247 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Matthew Chen 5444fc73b0 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Matthew Chen 2ac7716771 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Matthew Chen 31d22e3e35 "Bump build to 2.20.0.35." 2018-02-22 10:33:39 -05:00
Matthew Chen ba31059e43 Merge branch 'mkirk/fix-share-with-caption' 2018-02-22 10:33:34 -05:00
Michael Kirk e43d0b1b5a Fix "Share" for attachment with caption
// FREEBIE
2018-02-22 10:33:29 -05:00
Matthew Chen 88d8eacc6e "Bump build to 2.20.0.34." 2018-02-22 10:02:35 -05:00
Michael Kirk e27ab36205 Merge branch 'mkirk/remove-share-menu' 2018-02-22 09:39:41 -05:00
Michael Kirk 5ba5d3f524 Remove "Share" from edit menu
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.

Specifically:

- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
  share extension (could be the Signal share extension or another app's
  share extension)
- the conversation view (which is rendered behind the share extension)
  regains first responder, causing the input toolbar to appear above the
  share extension

One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.

// FREEBIE
2018-02-22 08:57:58 -05:00
Michael Kirk 9428b5d02b Merge branch 'mkirk/obscure-alert' 2018-02-21 16:35:52 -05:00
Michael Kirk d7f8c3e9d3 Ensure inputAccessory doesn't obscure the SN alert
This affects iOS 8, 9, and to a lesser degree iOS10.
On iOS11, presenting an alert causes the keyboard/inputAccessoryView to
temporarily dismiss.

// FREEBIE
2018-02-21 16:35:46 -05:00
Michael Kirk c0d1126394 Merge branch 'mkirk/fix-date-formatting-crash' 2018-02-21 16:35:12 -05:00
Michael Kirk 7040437ca6 Handle nil date when formatting
// FREEBIE
2018-02-21 16:35:09 -05:00
Matthew Chen 2575d01b96 "Bump build to 2.20.0.33." 2018-02-21 16:22:57 -05:00
Matthew Chen 26fbe28c42 Merge branch 'charlesmchen/legacyPasswordOnSuccess' 2018-02-21 16:20:19 -05:00
Matthew Chen a4855acf44 Don't clear legacy db password until conversion completes. 2018-02-21 16:20:13 -05:00
Matthew Chen 85e504745c Merge branch 'charlesmchen/filterUnicodeOrderingCharacters' 2018-02-21 16:18:17 -05:00
Matthew Chen 1109158b5b Add comment. 2018-02-21 16:18:10 -05:00
Matthew Chen 70ba1720d9 Filter unicode ordering letters. 2018-02-21 16:18:10 -05:00
Matthew Chen 6ddd9d788e Merge branch 'charlesmchen/backgroundTaskVsDBTransactions' 2018-02-21 16:14:40 -05:00
Matthew Chen 3bb802189c Use background tasks during db transactions. 2018-02-21 16:10:55 -05:00
Matthew Chen 2e1dad740c Merge branch 'charlesmchen/robustMigration2' 2018-02-21 09:37:14 -05:00
Matthew Chen 706006539f Improve the robustness of the migration logic. 2018-02-20 20:16:12 -05:00
Matthew Chen cf507487c1 "Bump build to 2.20.0.32." 2018-02-20 17:46:34 -05:00
Matthew Chen 4cfb71dc65 Merge branch 'charlesmchen/robustMigration' 2018-02-20 17:46:27 -05:00
Matthew Chen d91507d897 Improve the robustness of the migration logic. 2018-02-20 17:37:14 -05:00
Matthew Chen e8cbba61f9 "Bump build to 2.20.0.31." 2018-02-20 16:25:35 -05:00
Matthew Chen 9295a56309 Elaborate logging around storage migration. 2018-02-20 16:25:15 -05:00
Matthew Chen 1fb170715b Merge branch 'charlesmchen/heicHeifFixes' 2018-02-20 13:52:02 -05:00
Matthew Chen 7132179c5c Fix handling of HEIF/HEIC when attaching image "as document." 2018-02-20 13:51:55 -05:00
Matthew Chen 11680958de "Bump build to 2.20.0.30." 2018-02-20 13:48:00 -05:00
Matthew Chen b1c4dd7b55 Merge branch 'charlesmchen/storageFailureAlert' 2018-02-20 13:47:52 -05:00