Commit graph

1591 commits

Author SHA1 Message Date
Matthew Chen
21ab670fc9 Clean up ahead of PR. 2018-04-24 11:29:24 -04:00
Matthew Chen
fe9a61117c Rework archived conversations mode of home view. 2018-04-24 11:29:24 -04:00
Matthew Chen
9c7e9b795a Rework archived conversations mode of home view. 2018-04-24 11:29:24 -04:00
Matthew Chen
af2539f473 Rework archived conversations mode of home view. 2018-04-24 11:29:24 -04:00
Michael Kirk
f5e810e82b CR: rename ThreadModel -> ThreadViewModel
// FREEBIE
2018-04-23 12:15:21 -04:00
Michael Kirk
1f63ce02a0 Increase cache, remove dead code, add debug logging
// FREEBIE
2018-04-21 20:00:57 -04:00
Michael Kirk
113cb254d9 fixup cache 2018-04-21 19:21:19 -04:00
Michael Kirk
9c81eb44a1 Replace remaining UI usage of interaction.description
// FREEBIE
2018-04-21 19:21:18 -04:00
Michael Kirk
897d4a925b HomeView caches thread models
// FREEBIE
2018-04-21 19:21:18 -04:00
Michael Kirk
5f2b38c50b Introduce Thread view model
// FREEBIE
2018-04-21 19:21:18 -04:00
Michael Kirk
1fb1b5bbe2 WIP unjank home screen
verify `description` isn't used elsewhere (notifications? conversation
view?)

Probably want to remove overzealous asserts for now, but would be good
to work towards leaving them enabled.

// FREEBIE
2018-04-21 19:21:18 -04:00
Matthew Chen
7912598ccb Merge branch 'release/2.24.0' 2018-04-21 14:27:27 -04:00
Michael Kirk
8e56175099 CR: unread badge updates w/ dynamic text change
also renames for clarity

// FREEBIE
2018-04-20 16:05:25 -04:00
Michael Kirk
8ca62a8d44 Align top row by baseline
// FREEBIE
2018-04-19 21:01:45 -04:00
Michael Kirk
743867859f smaller font for date/unread, per updated spec
// FREEBIE
2018-04-19 19:51:32 -04:00
Michael Kirk
bba2bcefe2 Grow unread badge into pill
// FREEBIE
2018-04-19 19:51:05 -04:00
Michael Kirk
2bc072fe8e Now that snippet is a bit higher, increase max message cell height
// FREEBIE
2018-04-19 19:21:51 -04:00
Michael Kirk
ee4d038d2d Top row baseline and badge to spec
- Single visual baseline for all top row text
- Snippet should not flow under badge, it should stop at it's left edge
- unread font to spec (same as date stamp font, but never bold)

// FREEBIE
2018-04-19 19:17:37 -04:00
Michael Kirk
c693beb763 dateTime to spec
read should be gray
unread should be bold and black

// FREEBIE
2018-04-19 15:40:30 -04:00
Michael Kirk
91f4f38c02 snippet to spec (subheading: 15pt)
// FREEBIE
2018-04-19 15:28:59 -04:00
Michael Kirk
5ada961ec7 unread badge to spec (footnote: 13)
// FREEBIE
2018-04-19 15:28:59 -04:00
Michael Kirk
eec7678979 Group's meta message defaults to "Delivery"
// FREEBIE
2018-04-19 14:57:42 -04:00
Michael Kirk
0f46834e8d Show "Reconnecting..." on call screen
// FREEBIE
2018-04-19 09:56:09 -04:00
Matthew Chen
2c43d20ee8 Merge tag '2.24.0.9' 2018-04-18 17:40:10 -04:00
Matthew Chen
cc42e85bd6 Avoid race condition in call view controller. 2018-04-18 15:39:35 -04:00
Michael Kirk
b039fdd276 UI Fix: start with full hourglass on short timer durations
We were positioning relative to "blink" time (2s), rather than delete
time, which means that for 10s timers we were starting as though only 8s
remained.

// FREEBIE
2018-04-18 15:32:01 -04:00
Michael Kirk
754549adf1 Start timer for expiring message based on when read receipt was sent
// FREEBIE
2018-04-18 15:32:01 -04:00
Michael Kirk
dfb2a034af Use explicit transactions.
- Start expiration within scope of existing transaction when we're
  already in a transaction

// FREEBIE
2018-04-18 15:32:01 -04:00
Matthew Chen
621d54db17 Revert "Remove usage of ! in call view."
This reverts commit ce197b0ada.
2018-04-18 14:39:59 -04:00
Matthew Chen
943b3f031c Revert "Remove usage of ! in call view."
This reverts commit 699bf0a829.
2018-04-18 14:39:50 -04:00
Matthew Chen
594ddfaec3 Revert "Remove usage of ! in call view."
This reverts commit 3cbd49627a.
2018-04-18 14:39:37 -04:00
Matthew Chen
3cbd49627a Remove usage of ! in call view. 2018-04-18 13:58:43 -04:00
Matthew Chen
699bf0a829 Remove usage of ! in call view. 2018-04-18 13:29:04 -04:00
Matthew Chen
ce197b0ada Remove usage of ! in call view. 2018-04-18 13:29:04 -04:00
Matthew Chen
a1386eca81 Fix taps in message cells. 2018-04-17 13:28:06 -04:00
Matthew Chen
26f8050da0 Merge tag '2.23.4.2' 2018-04-16 19:18:31 -04:00
Matthew Chen
ae61b44a99 Resolve conflict between keyboard and call view. 2018-04-16 19:01:48 -04:00
Matthew Chen
284cc8c265 Apply attachment type assets. 2018-04-16 16:12:16 -04:00
Matthew Chen
146db1984b Apply attachment type assets. 2018-04-16 16:12:16 -04:00
Michael Kirk
64ff4cd660 tap-to-retry failed thumbnail downloads
// FREEBIE
2018-04-16 16:06:18 -04:00
Matthew Chen
f6d5b9197c Respond to CR. 2018-04-16 12:39:11 -04:00
Matthew Chen
94e9c72e67 Apply design changes from Myles. 2018-04-16 12:36:30 -04:00
Matthew Chen
bb9c1fb23d Apply design changes from Myles. 2018-04-16 12:36:30 -04:00
Matthew Chen
6a69070ce9 Apply design changes from Myles. 2018-04-16 12:36:30 -04:00
Matthew Chen
6831412e44 Respond to CR. 2018-04-16 12:14:09 -04:00
Matthew Chen
a5c7bdb987 Don't animate changes to shape layer properties. 2018-04-16 12:08:57 -04:00
Matthew Chen
df685da497 Merge remote-tracking branch 'private/hotfix/2.23.3' 2018-04-16 09:47:38 -04:00
Matthew Chen
59a3d736bf Respond to CR. 2018-04-13 15:10:16 -04:00
Matthew Chen
d7ae35f72c Streamline usage of quoted message view. 2018-04-13 15:03:51 -04:00
Matthew Chen
195d357370 Streamline usage of quoted message view. 2018-04-13 15:03:51 -04:00
Matthew Chen
9c93099515 Fix incomplete asserts. 2018-04-13 15:01:25 -04:00
Matthew Chen
6caa5b87b6 Add more asserts around thread in SAE. 2018-04-13 14:59:38 -04:00
Matthew Chen
644e78f19d Respond to CR. 2018-04-13 14:32:42 -04:00
Matthew Chen
eb400114c2 Fix message details layout in iPhone X. 2018-04-13 14:32:42 -04:00
Matthew Chen
03e6a5dc70 Refine screenlock. 2018-04-13 10:40:48 -04:00
Michael Kirk
e554884ab3 Use profile name in quoted messages, fix "multi account" label
// FREEBIE
2018-04-13 09:53:31 -04:00
Michael Kirk
40879ca3e3 Distinguish between quoting yourself and someone else quoting you
// FREEBIE
2018-04-11 19:21:38 -04:00
Michael Kirk
5774e5769d truncate tail for both preview and message bubble
// FREEBIE
2018-04-11 15:26:09 -04:00
Matthew Chen
576f5dee88 Add white background to images in quoted reply view. 2018-04-11 14:53:59 -04:00
Matthew Chen
fc2704cf88 Label quoted replies to yourself as such. 2018-04-11 14:40:18 -04:00
Matthew Chen
759b2a332f Respond to CR. 2018-04-11 14:18:09 -04:00
Matthew Chen
c6df55b820 Scale home view cells to reflect dynamic type size. 2018-04-11 14:09:38 -04:00
Matthew Chen
3688d57eac Scale home view cells to reflect dynamic type size. 2018-04-11 14:09:38 -04:00
Matthew Chen
543c898dbe Scale home view cells to reflect dynamic type size. 2018-04-11 14:09:38 -04:00
Matthew Chen
25e487fcde Scale home view cells to reflect dynamic type size. 2018-04-11 14:09:38 -04:00
Matthew Chen
c3345a4c4e Scale home view cells to reflect dynamic type size. 2018-04-11 14:09:38 -04:00
Matthew Chen
ea82419a40 Fix long press on quoted reply. 2018-04-11 14:02:07 -04:00
Matthew Chen
031a1d7325 Fix quoted message overflow. 2018-04-11 13:57:17 -04:00
Matthew Chen
ae91b03c71 Add white background to images in conversation view. 2018-04-11 13:45:12 -04:00
Michael Kirk
5320536736 remove WIP comments
// FREEBIE
2018-04-11 11:55:30 -04:00
Michael Kirk
1780973e68 fix image, video, audio interactions in message details
// FREEBIE
2018-04-11 11:55:30 -04:00
Michael Kirk
7abd51838f Move bubble actions to new bubble delegate
// FREEBIE
2018-04-11 11:55:30 -04:00
Matthew Chen
f6698501df Revert "Label quoted replies to yourself as such."
This reverts commit 24d7492f61.
2018-04-11 11:48:08 -04:00
Matthew Chen
24d7492f61 Label quoted replies to yourself as such. 2018-04-11 11:47:33 -04:00
Matthew Chen
c0578b31fe Clean up ahead of CR. 2018-04-11 09:34:37 -04:00
Matthew Chen
45cb1ec510 Clean up ahead of PR. 2018-04-11 09:34:37 -04:00
Matthew Chen
abba24988c Rework how dates are formatted in home view. 2018-04-11 09:34:37 -04:00
Matthew Chen
b8f8a3017a Apply design changes to home view. 2018-04-11 09:34:37 -04:00
Michael Kirk
6b6f4f9336 Limit caption length
// FREEBIE
2018-04-10 16:00:19 -04:00
Matthew Chen
9769d482da Respond to CR. 2018-04-10 15:56:56 -04:00
Matthew Chen
76995e4594 Enforce quoted reply edge cases. 2018-04-10 15:56:55 -04:00
Matthew Chen
f2b416d800 Respond to CR. 2018-04-10 15:54:46 -04:00
Matthew Chen
8b060a187c Tap on quoted replies. 2018-04-10 15:54:46 -04:00
Matthew Chen
65015e686f Tap on quoted replies. 2018-04-10 15:54:46 -04:00
Matthew Chen
ca1f8efdad Move 'never clear' view to proper subfolder. 2018-04-10 13:09:18 -04:00
Fredrik Lillejordet
21e0d1cd3d simplified backgroundColor logic 2018-04-10 13:04:56 -04:00
Fredrik Lillejordet
2f538b9f59 fixed header formatting 2018-04-10 13:04:22 -04:00
Fredrik Lillejordet
d16bffe6c1 forget target reference to new class in PR 2018-04-10 13:04:22 -04:00
Fredrik Lillejordet
8984f659f3 Keeps original background color of a subview in during row selection
When a row is selected in UITableView, background colors of all UIView subviews gets changed. This class will prevent that from happening so that the blue dot can remain blue while the row is selected. Description and solution suggestions found in the following link:
https://stackoverflow.com/questions/6745919/uitableviewcell-subview-disappears-when-cell-is-selected/27717607
2018-04-10 13:04:22 -04:00
Matthew Chen
e8ad6bad87 Respond to CR. 2018-04-10 10:53:29 -04:00
Matthew Chen
ebb89ed1fd Tweak message layout. 2018-04-10 10:52:08 -04:00
Michael Kirk
520dad25bb WIP making OWSQuotedMessageView work with preview
// FREEBIE
2018-04-10 10:06:18 -04:00
Michael Kirk
5287ab8f8c Try 2: no more stack view
// FREEBIE
2018-04-10 10:06:18 -04:00
Fredrik Lillejordet
16014f321a autoresize label in segmentControl to avoid unwanted truncation 2018-04-09 17:01:34 -04:00
Matthew Chen
8fe289feec Tweak design of quoted replies. 2018-04-09 16:45:42 -04:00
Matthew Chen
8c1362b807 Fix small text usage. 2018-04-09 16:15:24 -04:00
Matthew Chen
3799dce822 Respond to CR. 2018-04-09 14:32:10 -04:00
Matthew Chen
c106a67a52 Use dynamic type everywhere in conversation view. 2018-04-09 14:25:53 -04:00
Matthew Chen
ade2ee7216 Use dynamic type everywhere in conversation view. 2018-04-09 14:25:53 -04:00
Michael Kirk
90486aa49c Inline method with one caller, fix formatting
// FREEBIE
2018-04-09 12:47:57 -04:00