Matthew Chen
f4d1f25656
Merge remote-tracking branch 'origin/release/2.29.1'
2018-09-04 09:27:41 -04:00
Michael Kirk
2cdca0299c
show generic file icon for invalid GIF
2018-08-30 20:49:31 -06:00
Michael Kirk
e715bf9ea2
image sizing
...
Validate image sizing
2018-08-30 19:21:38 -06:00
Matthew Chen
cc5a480baa
Apply OWS log functions in Objective-C.
2018-08-27 12:58:52 -04:00
Matthew Chen
3a50377902
Apply OWS log functions in Objective-C.
2018-08-27 12:58:52 -04:00
Matthew Chen
713606271c
Rename fail macros in Obj-C.
2018-08-27 10:29:51 -04:00
Michael Kirk
8829cdfb4b
Toast view when tapped message doesn't exist, mark remotely sourced.
2018-08-10 16:55:54 -06:00
Michael Kirk
c05700fd98
Log in OWSFail
...
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
2018-08-09 15:30:19 -06:00
Matthew Chen
0ac1cb1e72
Cache system message text.
2018-08-09 14:01:07 -04:00
Michael Kirk
42eb7a8d31
cleanup unused code
2018-07-13 13:00:27 -06:00
Michael Kirk
2552368146
add text reply action, comment out more deprecated uimenu code
2018-07-13 13:00:27 -06:00
Matthew Chen
ecafe546b6
Rework unread indicators.
2018-07-11 16:43:39 -04:00
Matthew Chen
8d72bb032e
Rework unread indicators.
2018-07-11 16:43:39 -04:00
Matthew Chen
e48a1e0816
Respond to CR.
2018-07-11 15:43:27 -04:00
Matthew Chen
8b3bdb88f3
Revert "Merge branch 'charlesmchen/tweakCalls'"
...
This reverts commit 3e0233ea60
, reversing
changes made to 74ce3012cf
.
2018-07-11 15:34:16 -04:00
Michael Kirk
c81799169e
CR: intercell spacing dicated by ConversationViewItem
2018-07-10 11:39:56 -06:00
Michael Kirk
77e9533dc1
remove hairline
...
// FREEBIE
2018-07-10 11:39:56 -06:00
Matthew Chen
1a9a5016fe
Tweak calls.
2018-07-09 11:08:53 -04:00
Matthew Chen
db32dcc6a2
Cleanup.
2018-07-02 16:20:16 -04:00
Matthew Chen
7be6fbc24f
Refine intra-cell spacing.
2018-07-02 15:36:01 -04:00
Matthew Chen
39eac9129b
Respond to CR.
2018-07-02 15:25:43 -04:00
Matthew Chen
d869afc3e4
Tweak break spacing.
2018-06-28 15:06:53 -04:00
Matthew Chen
966e6a1156
Tweak sender names.
2018-06-27 13:18:31 -04:00
Matthew Chen
227234d8cb
Respond to CR.
2018-06-27 13:15:31 -04:00
Matthew Chen
16a1dcfb77
Respond to CR.
2018-06-27 09:53:45 -04:00
Matthew Chen
89523f556b
Tweak intra-cell spacing.
2018-06-27 09:33:47 -04:00
Matthew Chen
33b1628c26
Rename to ConversationStyle.
2018-06-26 10:20:26 -04:00
Matthew Chen
4effa56d50
Tweak 'group sender' avatars.
2018-06-25 15:07:46 -04:00
Matthew Chen
a9b6fe5978
Respond to CR.
2018-06-25 15:00:45 -04:00
Matthew Chen
fdd6174871
Fix breakage from cell layout changes.
2018-06-25 14:41:14 -04:00
Matthew Chen
fc299b8700
Use UI database connection throughout the conversation cells.
2018-06-25 13:08:10 -04:00
Matthew Chen
d40f74dd0b
Respond to CR.
2018-06-25 12:43:25 -04:00
Matthew Chen
ac6f78a5fc
Tweak message cells.
2018-06-25 09:26:41 -04:00
Matthew Chen
3cd6a33aa6
Fix build warnings.
2018-06-01 12:39:13 -04:00
Michael Kirk
5ba5e98260
Show downloaded contact avatar in thread
...
// FREEBIE
2018-05-07 12:08:41 -04:00
Matthew Chen
411d5a3b4f
Respond to CR.
2018-05-02 11:01:23 -04:00
Matthew Chen
708b44e3c5
Improve handling of contact display names.
2018-05-02 10:52:29 -04:00
Matthew Chen
7e35a7e7d7
Sketch out rendering of contact shares in conversation view.
2018-05-02 10:51:59 -04:00
Matthew Chen
9275c67818
Rework outgoing message state.
2018-04-25 10:49:19 -04:00
Matthew Chen
9c93099515
Fix incomplete asserts.
2018-04-13 15:01:25 -04:00
Matthew Chen
ea82419a40
Fix long press on quoted reply.
2018-04-11 14:02:07 -04:00
Michael Kirk
5320536736
remove WIP comments
...
// FREEBIE
2018-04-11 11:55:30 -04:00
Matthew Chen
9769d482da
Respond to CR.
2018-04-10 15:56:56 -04:00
Matthew Chen
76995e4594
Enforce quoted reply edge cases.
2018-04-10 15:56:55 -04:00
Michael Kirk
1d4c0624be
Clarify variable names
...
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
cb5d3d4f85
Use QuotedReplyModel to access attachment data
...
This view model loads the attachment when it's build.
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
d99054d895
Reply menu item
...
MVP
- [x] populate from menu
- [] send quoted message
TODO
- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit
NICE TO HAVE
- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments
// FREEBIE
2018-04-04 10:59:04 -04:00
Matthew Chen
7cf169012c
Elaborate conversation view items around quoted replies.
2018-04-04 10:12:07 -04:00
Michael Kirk
00e5e1b0d6
Fixup some tests
...
// FREEBIE
2018-04-03 11:29:05 -04:00
Matthew Chen
12bcf887c1
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
4f9085a761
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
3ca2c08b06
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
578f40d791
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
8d74c68f9d
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
e0e8eafb5d
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
75177ef00f
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
38ff82ab97
Rebrand OWSAudioPlayer.
2018-02-26 14:47:57 -05:00
Michael Kirk
5ba5d3f524
Remove "Share" from edit menu
...
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.
Specifically:
- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
share extension (could be the Signal share extension or another app's
share extension)
- the conversation view (which is rendered behind the share extension)
regains first responder, causing the input toolbar to appear above the
share extension
One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.
// FREEBIE
2018-02-22 08:57:58 -05:00
Matthew Chen
e3776015bb
Respond to CR.
2018-02-13 10:49:54 -05:00
Matthew Chen
246a56e925
Respond to CR.
2018-02-13 10:49:54 -05:00
Matthew Chen
33686594e9
Tweak debug logging.
2018-02-13 10:49:54 -05:00
Matthew Chen
b9bd21e73f
Improve presentation of text attachments in attachment approval view.
2018-01-25 13:24:22 -05:00
Michael Kirk
05035e40a6
Fixup tests
...
// FREEBIE
2018-01-25 11:00:38 -05:00
sdkjfhsdkjhfsdlkjhfsdf
cf091758a5
Fix oversized text messages
...
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
82aeee301d
can delete text messages again
...
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
0e9c9a9bb3
Separate gestures for text/vs media
...
// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk
3eb3c268a9
Towards a caption in message
...
TODO
- [ ] adjust height properly
- [ ] all media types
- [ ] include caption in message details
- [ ] gestures working on both independently
- [ ] perf benchmark
// FREEBIE
2017-12-20 14:26:53 -06:00
Matthew Chen
9258b0883e
Clean up TSStorageManager usage.
2017-12-19 11:41:31 -05:00
Matthew Chen
9a990b58e8
Respond to CR.
2017-12-19 11:38:25 -05:00
Matthew Chen
d8ae5841d6
Respond to CR.
...
// FREEBIE
2017-11-20 14:50:43 -05:00
Matthew Chen
6d4a05bbea
Improving handling of edge cases in conversation view.
2017-11-20 14:44:10 -05:00
Matthew Chen
dffd776ace
Increase the max text message length.
2017-11-16 17:29:26 -05:00
Matthew Chen
aad93d2d89
Fix broken assert in conversation view item.
2017-11-16 13:23:47 -05:00
Matthew Chen
ddf4bf28cc
Load attachments for conversation view items using long-lived db connection.
2017-11-16 13:16:18 -05:00
Matthew Chen
0abdbffe1f
Improve handling of attachment edge cases.
2017-11-10 13:12:43 -05:00
Matthew Chen
6e840ff956
Fix build warnings from XCode 9.
2017-11-09 02:52:44 -05:00
Matthew Chen
a5c4140a12
Reduce max text message bubble size.
...
// FREEBIE
2017-11-03 15:48:08 -04:00
Matthew Chen
8cb3e5d35d
Fix edge cases around oversize test messages.
...
// FREEBIE
2017-10-26 14:34:30 -04:00
Matthew Chen
9cc4521d07
Respond to CR.
...
// FREEBIE
2017-10-26 12:09:36 -04:00
Matthew Chen
bcf83a4c8e
Rework handling of oversize text messages.
...
// FREEBIE
2017-10-26 11:56:03 -04:00
Matthew Chen
7e585b72aa
Fix tests broken by the JSQ rewrite.
...
// FREEBIE
2017-10-25 16:08:15 -04:00
Matthew Chen
fb4d43d542
Fix "can't send same GIF twice" issue.
...
// FREEBIE
2017-10-19 10:04:49 -07:00
Matthew Chen
3b945a9da2
Respond to CR.
...
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen
032ec59d1c
Respond to CR.
...
// FREEBIE
2017-10-16 21:05:29 -07:00
Matthew Chen
3723a4845f
Restore message cell footers.
...
// FREEBIE
2017-10-16 20:41:14 -07:00
Matthew Chen
c2f07bb3d8
Restore message cell footers.
...
// FREEBIE
2017-10-16 20:41:14 -07:00
Matthew Chen
227fd5280d
Resize conversation view cells as necessary.
...
// FREEBIE
2017-10-16 20:41:14 -07:00
Matthew Chen
49501a5d1b
Respond to CR.
...
// FREEBIE
2017-10-12 16:23:48 -04:00
Matthew Chen
b1624d6818
Respond to CR.
...
// FREEBIE
2017-10-12 16:23:48 -04:00
Matthew Chen
b833976b77
Clean up ahead of PR.
...
// FREEBIE
2017-10-12 16:23:48 -04:00
Matthew Chen
5621fe893c
Clean up ahead of PR.
...
// FREEBIE
2017-10-12 16:23:48 -04:00
Matthew Chen
fb408f980c
Remove JSQ.
...
// FREEBIE
2017-10-12 16:23:48 -04:00