Cleanup and refactor Node handling #4

Merged

mirsal merged 4 commits from refactor-node into main

2021-03-31 12:43:58 +02:00

ryzokuken commented

2021-03-31 08:47:10 +02:00

Owner

Starting to clean stuff up, let me know what you think!

ryzokuken added 2 commits 2021-03-31 08:47:11 +02:00

d46faad53e

src: implement base64 handling for PublicKey

4b2a20c581

src: improve Node handling

ryzokuken self-assigned this 2021-03-31 08:47:15 +02:00

ryzokuken requested review from mirsal 2021-03-31 08:47:50 +02:00

ryzokuken added 1 commit 2021-03-31 09:01:38 +02:00

53bd1c9e6c

src: move network types to new file

mirsal refused to review 2021-03-31 11:20:04 +02:00

mirsal approved these changes 2021-03-31 11:21:58 +02:00

mirsal left a comment

Collaborator

LGTM, apart from maybe the names of Host::to/from_base64 methods, which are a bit confusing as only the public key is base64 encoded, it's more of a peer-discovery format? maybe from/to_str instead?

also I suggest renaming Node to Peer

LGTM, apart from maybe the names of Host::to/from_base64 methods, which are a bit confusing as only the public key is base64 encoded, it's more of a peer-discovery format? maybe from/to_str instead? also I suggest renaming Node to Peer

ryzokuken added 1 commit 2021-03-31 12:28:18 +02:00

db5f74ae86

src: rename Host and methods

ryzokuken force-pushed refactor-node from db5f74ae86 to 77387edd0d

2021-03-31 12:40:19 +02:00

Compare

mirsal merged commit 5d351ebc00 into main

2021-03-31 12:43:58 +02:00

mirsal referenced this issue from a commit

2021-03-31 12:43:59 +02:00

Merge pull request 'Cleanup and refactor Node handling' (#4) from refactor-node into main

ryzokuken deleted branch refactor-node