tqt
/
Ghost-Admin
mirror of https://github.com/TryGhost/Ghost-Admin.git
1
0
Fork 0
Code Issues Releases Wiki Activity
Ghost-Admin/app/components/gh-alerts.js

13 lines
304 B
JavaScript
Raw Normal View History

Switched from ember-cli-shims to new module imports (#779) no issue - add eslint-plugin-ember, configure no-old-shims rule - run `eslint --fix` on `app`, `lib`, `mirage`, and `tests` to move imports to the new module imports - further cleanup of Ember globals usage - remove event-dispatcher initializer now that `canDispatchToEventManager` is deprecated
2017-08-22 09:53:26 +02:00
import Component from '@ember/component';
import {alias} from '@ember/object/computed';
Match service/controller import to ember-modules-codemod style for consistency no issue Automated tools, code generators, and editor integrations are increasingly standardising on the import style used in `ember-modules-codemod`. Our import style differed a little with regards to service/controller injection imports which meant we were starting to see inconsistent naming.
2017-10-30 10:38:01 +01:00
import {inject as service} from '@ember/service';
Use es6 across client and add ember-suave to enforce rules no issue - add ember-suave dependency - upgrade grunt-jscs dependency - add a new .jscsrc for the client's tests directory that extends from client's base .jscsrc - separate client tests in Gruntfile jscs task so they pick up the test's .jscsrc - standardize es6 usage across client
2015-10-28 12:36:45 +01:00
export default Component.extend({
Match service/controller import to ember-modules-codemod style for consistency no issue Automated tools, code generators, and editor integrations are increasingly standardising on the import style used in `ember-modules-codemod`. Our import style differed a little with regards to service/controller injection imports which meant we were starting to see inconsistent naming.
2017-10-30 10:38:01 +01:00
notifications: service(),
fixed notification components
2015-05-21 19:03:24 +02:00
ESLint: Consistent ember property/method ordering no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-components.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-controllers.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-routes.md
2018-01-11 18:43:23 +01:00
classNames: 'gh-alerts',
tagName: 'aside',
Remove unused top notification count functionality no issue - in a very old iteration of the admin design we needed a data attribute containing the number of notifications in order to add extra spacing in the styles. This hasn't been necessary for a long time and there are easier ways to do it now than using observers.
2017-11-24 11:47:06 +01:00
messages: alias('notifications.alerts')
fixed notification components
2015-05-21 19:03:24 +02:00
});