Removed redundant reset value for task buttons

no issue

- Since task buttons by default have reset on now, we don't need to explicitly add it to individual buttons
This commit is contained in:
Rish 2020-06-04 19:16:52 +05:30 committed by Rishabh Garg
parent aaac414745
commit 4ed4f71c71
14 changed files with 8 additions and 15 deletions

View File

@ -138,7 +138,6 @@
{{/if}}
<GhTaskButton @buttonText="Send test email"
@autoReset={{true}}
@task={{this.sendTestEmail}}
@successText="Email sent"
@runningText="Sending..."

View File

@ -45,7 +45,6 @@
@taskArgs={{hash dropdown=dd}}
@successText={{this.successText}}
@runningText={{this.runningText}}
@autoReset={{true}}
@class="gh-btn gh-btn-blue gh-publishmenu-button gh-btn-icon"
data-test-publishmenu-save=true
/>

View File

@ -72,7 +72,6 @@
<GhTaskButton
@buttonText="Save"
@successText="Saved"
@autoReset={{true}}
@task={{this.saveTask}}
@taskArgs={{this.model}}
@class="gh-btn gh-btn-green gh-btn-icon"

View File

@ -29,14 +29,12 @@
/>
{{#if signinUrl}}
<GhTaskButton
@autoReset={{true}}
@buttonText="Copy link"
@task={{this.copySigninUrl}}
@successText="Link copied"
@class="gh-btn gh-btn-blue gh-btn-icon" />
{{else}}
<GhTaskButton
@autoReset={{true}}
@buttonText="Copy link"
@task={{this.copySigninUrl}}
@successText="Link copied"

View File

@ -68,7 +68,6 @@
@buttonText="Save"
@runningText="Saving..."
@successText="Saved"
@autoReset={{true}}
@task={{this.saveTask}}
@taskArgs={{this.label}}
@class="gh-btn gh-btn-green gh-btn-icon"

View File

@ -21,7 +21,7 @@
{{/unless}}
{{/if}}
<GhTaskButton @class="gh-btn gh-btn-blue gh-btn-icon" @type="button" @task={{this.saveTask}} @autoReset={{true}} @data-test-button="save" />
<GhTaskButton @class="gh-btn gh-btn-blue gh-btn-icon" @type="button" @task={{this.saveTask}} @data-test-button="save" />
</section>
</GhCanvasHeader>

View File

@ -4,7 +4,7 @@
Code injection
</h2>
<section class="view-actions">
<GhTaskButton @task={{this.saveTask}} @autoReset={{true}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
<GhTaskButton @task={{this.saveTask}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
</section>
</GhCanvasHeader>

View File

@ -4,7 +4,7 @@
Design
</h2>
<section class="view-actions">
<GhTaskButton @task={{this.save}} @autoReset={{true}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
<GhTaskButton @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
</section>
</GhCanvasHeader>

View File

@ -5,7 +5,7 @@
General settings
</h2>
<section class="view-actions">
<GhTaskButton @buttonText="Save settings" @task={{this.save}} @autoReset={{true}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button="true" />
<GhTaskButton @buttonText="Save settings" @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button="true" />
</section>
</GhCanvasHeader>

View File

@ -7,7 +7,7 @@
{{this.integration.name}}
</h2>
<section class="view-actions">
<GhTaskButton @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" @autoReset={{true}} data-test-button="save" />
<GhTaskButton @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-button="save" />
</section>
</GhCanvasHeader>

View File

@ -6,7 +6,7 @@
Slack
</h2>
<section class="view-actions">
<GhTaskButton @task={{this.save}} @autoReset={{true}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
<GhTaskButton @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
</section>
</GhCanvasHeader>

View File

@ -6,7 +6,7 @@
Unsplash
</h2>
<section class="view-actions">
<GhTaskButton @task={{this.save}} @autoReset={{true}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
<GhTaskButton @task={{this.save}} @class="gh-btn gh-btn-blue gh-btn-icon" data-test-save-button={{true}} />
</section>
</GhCanvasHeader>

View File

@ -35,7 +35,6 @@
@task={{this.saveSettings}}
@successText="Saved"
@runningText="Saving"
@autoReset={{true}}
@class="gh-btn gh-btn-blue gh-btn-icon"
/>
</div>

View File

@ -7,7 +7,7 @@
{{if this.tag.isNew "New tag" this.tag.name}}
</h2>
<section class="view-actions">
<GhTaskButton @task={{this.save}} @type="button" @class="gh-btn gh-btn-blue gh-btn-icon" @autoReset={{true}} @data-test-button="save" />
<GhTaskButton @task={{this.save}} @type="button" @class="gh-btn gh-btn-blue gh-btn-icon" @data-test-button="save" />
</section>
</GhCanvasHeader>