tqt/Ghost-Admin
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
Code Issues Releases Wiki Activity

Fixed button and title cases for Tags screen

Browse source 
no refs.
Set "New tag" button and "Tag settings" to sentence case to be consistent with the rest of the UI. (Previously they were title case.)
This commit is contained in:
Zimo 2019-03-25 09:37:44 +01:00
parent 133eb21e30
commit 5dcf5b9651
6 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/components/gh-tag-settings-form.js
View file

@ -32,9 +32,9 @@ export default Component.extend({
title: computed('tag.isNew', function () {
if (this.get('tag.isNew')) {
return 'New Tag';
return 'New tag';
} else {
return 'Tag Settings';
return 'Tag settings';
}
}),

2
app/templates/settings/tags-loading.hbs
View file

@ -2,7 +2,7 @@
<header class="view-header">
{{#gh-view-title}}<span>Tags</span>{{/gh-view-title}}
<section class="view-actions">
{{#link-to "settings.tags.new" class="gh-btn gh-btn-green"}}<span>New Tag</span>{{/link-to}}
{{#link-to "settings.tags.new" class="gh-btn gh-btn-green"}}<span>New tag</span>{{/link-to}}
</section>
</header>

2
app/templates/settings/tags.hbs
View file

@ -2,7 +2,7 @@
<header class="view-header">
{{#gh-view-title}}<span>Tags</span>{{/gh-view-title}}
<section class="view-actions">
{{#link-to "settings.tags.new" class="gh-btn gh-btn-green"}}<span>New Tag</span>{{/link-to}}
{{#link-to "settings.tags.new" class="gh-btn gh-btn-green"}}<span>New tag</span>{{/link-to}}
</section>
</header>

2
app/templates/settings/tags/index.hbs
View file

@ -1,6 +1,6 @@
<div class="no-posts-box">
<div class="no-posts">
<h3>You haven't added any tags yet!</h3>
{{#link-to "settings.tags.new"}}<button type="button" class="gh-btn gh-btn-green btn-lg" title="New Tag"><span>Add a tag</span></button>{{/link-to}}
{{#link-to "settings.tags.new"}}<button type="button" class="gh-btn gh-btn-green btn-lg" title="New tag"><span>Add a tag</span></button>{{/link-to}}
</div>
</div>

2
tests/acceptance/settings/tags-test.js
View file

@ -122,7 +122,7 @@ describe('Acceptance: Settings - Tags', function () {
// it shows selected tag form
expect(find('.tag-settings-pane h4').textContent, 'settings pane title')
.to.equal('Tag Settings');
.to.equal('Tag settings');
expect(find('.tag-settings-pane input[name="name"]').value, 'loads correct tag into form')
.to.equal(tag1.name);

4
tests/integration/components/gh-tag-settings-form-test.js
View file

@ -56,10 +56,10 @@ describe('Integration: Component: gh-tag-settings-form', function () {
await render(hbs`
{{gh-tag-settings-form tag=tag setProperty=(action setProperty)}}
`);
expect(find('.tag-settings-pane h4').textContent, 'existing tag title').to.equal('Tag Settings');
expect(find('.tag-settings-pane h4').textContent, 'existing tag title').to.equal('Tag settings');
this.set('tag.isNew', true);
expect(find('.tag-settings-pane h4').textContent, 'new tag title').to.equal('New Tag');
expect(find('.tag-settings-pane h4').textContent, 'new tag title').to.equal('New tag');
});
it('renders main settings', async function () {