no issue
- This will help with the octane migration and you can still run the lint rules even when they are todos. (Checkout the docs at 158b119667/docs/todos.md) The good news is any new code will be checked against the recommended config.
- I fixed all the auto fixable things we could get in this PR as well
refs https://github.com/TryGhost/Toolbox/issues/71
- Node 16 is now LTS so we're picking up support for it
- we're also bumping the minimum Node 14 version to 14.17.0 so it
unblocks merging dependencies
- Admin needs the Node engine range and CI updating
- CI has been updated to the minimum Node 14 range as that is our
recommended version
refs https://linear.app/tryghost/issue/CORE-74/improve-the-test-situation
- this commit:
- adds the `ember-cli-code-coverage` dependency to collect
coverage from ember tests
- enables the `COVERAGE` env variable in CI
- merges coverage data because tests are run in parallel
- adds the codecov GitHub Action into CI so we can upload
coverage reports
no issue
- we were still referencing `master` here, whereas we've since switched
to `main`
- this commit updates the workflow to trigger the notification if it
fails on `main`
- also enables testing on `v4.*` branches
refs 84bfbae282
- if Admin is pushed to after Ghost, the canary build won't contain
Admin changes, so we need to trigger another canary build
- this commit adds a final step to the CI flow that will trigger the
Ghost canary build if all steps were successful
- we don't need to run linting twice as we do currently in the Firefox &
Chrome jobs
- also pins the Node version to 12.18.0 so we can be sure what Node
version we're running with
- we recently had an issue where a dependency update broke the
release process because it was building in production mode, but our CI
never ran in this mode and we missed it
- this commit adds a test to run in prod mode so hopefully we catch it
next time
no issue
- using the setup-node action is currently failing because of an
upstream issue - https://github.com/nodejs/node/issues/32683
- this commit switches to using a Docker container
- lots of links were old and out of date
- updated contributing guide to match the one in Ghost
- updated PR guide to be similar to the one in Ghost, but with the Ghost-Admin test info
Daniel Lockyer
Renovate Bot
Simon Backx
Gabriel Csapo
Aileen Nowak
Hannah Wolfe
Katharina Irrgang
Kevin Ansfield