1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
Ghost-Admin/app
Kevin Ansfield 4e4d7cc85c Fixed and improved members stats "debounced" fetches
no issue

- the "days changed" logic was incorrect so we were always performing new fetches rather than using existing data
- added a minor improvement that returns an in-progress fetch promise if we have one and params haven't changed - avoids triggering unnecessary extra fetches in the rare occasions the chart is re-rendered before a previous stats fetch has finished
2020-05-28 11:11:43 +01:00
..
adapters Added labels for Members (#1477) 2020-02-14 15:04:01 +05:30
authenticators Added "What's new" indicator and modal to highlight recent updates (#1292) 2019-08-23 10:01:27 +01:00
components Updated billing icon in nav bar 2020-05-28 21:53:38 +12:00
controllers Added server-side search to new members screen (#1582) 2020-05-28 10:15:17 +01:00
errors Added polling when confirming email to show immediate error 2019-11-20 23:27:09 +00:00
helpers Added server-side search to new members screen (#1582) 2020-05-28 10:15:17 +01:00
initializers Bumped dependencies (Fixed production build) (#1091) 2019-01-08 12:36:16 +00:00
mixins Update dependency eslint-plugin-ghost to v1.4.0 2020-05-06 18:07:01 +01:00
models Update dependency eslint-plugin-ghost to v1.4.0 2020-05-06 18:07:01 +01:00
modifiers Update dependency ember-power-select to v4 (#1528) 2020-05-17 22:35:53 +01:00
routes Added server-side search to new members screen (#1582) 2020-05-28 10:15:17 +01:00
serializers Added member's geographic location to admin 2020-02-27 12:56:26 +00:00
services Fixed and improved members stats "debounced" fetches 2020-05-28 11:11:43 +01:00
session-stores Use Admin API v2 with session auth (#1046) 2018-10-05 19:46:33 +01:00
styles Fixed browser URL syncronization with embeded iframe state 2020-05-22 14:44:37 +12:00
templates Added server-side search to new members screen (#1582) 2020-05-28 10:15:17 +01:00
transforms Upgraded eslint-plugin-ghost and fixed new linter errors 2020-01-16 17:01:12 +00:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Removed <GhDownloadCount> 2020-01-27 09:51:45 +00:00
validators Fixed incorrect validation when member's name is too long 2020-05-11 11:40:38 +01:00
app.js Update ember core (#1441) 2020-01-06 10:51:48 +00:00
index.html 🤡 Serve own admin favicon (#619) 2017-04-06 17:28:51 +01:00
README.md Convert Sass to Myth 2015-05-22 19:05:09 +01:00
router.js Fixed browser URL syncronization with embeded iframe state 2020-05-22 14:44:37 +12:00
transitions.js Unsplash integration 2017-08-15 16:01:12 +01:00

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)