1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
Ghost-Admin/app/components/gh-scroll-trigger.js
Kevin Ansfield e9c7fad302 Refactored usage of .get('property') with es5 getters
no issue
- ran [es5-getter-ember-codemod](https://github.com/rondale-sc/es5-getter-ember-codemod)
- [es5 getters RFC](https://github.com/emberjs/rfcs/blob/master/text/0281-es5-getters.md)
- updates the majority of `object.get('property')` with `object.property` with exceptions:
  - `.get('nested.property')` - it's not possible to determine if this is relying on "safe" path chaining for when `nested` doesn't exist
  - `.get('config.x')` and `.get('settings.x')` - both our `config` and `settings` services are proxy objects which do not support es5 getters
- this PR is not exhaustive, there are still a number of places where `.get('service.foo')` and similar could be replaced but it gets us a long way there in a quick and automated fashion
2019-03-06 13:54:14 +00:00

44 lines
988 B
JavaScript

import Component from '@ember/component';
import InViewportMixin from 'ember-in-viewport';
export default Component.extend(InViewportMixin, {
enter() {},
exit() {},
registerElement() {},
didInsertElement() {
let offset = this.triggerOffset || {};
// if triggerOffset is a number we use it for all dimensions
if (typeof offset === 'number') {
offset = {
top: offset,
bottom: offset,
left: offset,
right: offset
};
}
this.set('viewportSpy', true);
this.set('viewportTolerance', {
top: offset.top,
bottom: offset.bottom,
left: offset.left,
right: offset.right
});
this._super(...arguments);
this.registerElement(this.element);
},
didEnterViewport() {
return this.enter();
},
didExitViewport() {
return this.exit();
}
});