1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
No description
Find a file
Kevin Ansfield 6ef7fcafda 🐛 fix broken sidebar after successful import (#658)
closes TryGhost/Ghost#8307

- unloading the store and refreshing the `session.user` attribute after an import was triggering a rendering edge case where the style was re-computed and a re-render was attempted after the sidebar has been destroyed
- rather than binding a style attribute directly to a CP in `gh-nav-menu` we pass the menu icon in (using `settings.settledIcon` - see below) and manually set the style attribute via the `didReceiveAttrs` hook so that outside changes don't trigger re-computations when we don't expect them and so we can still react to icons being uploaded or removed
- our usage of `settings.icon` is a bit of an odd situation because it's a link to an external resource that will only resolve correctly after a successful save - if we change `settings.icon` in the local store and the nav menu icon style updates before the save has been completed then the server will give us the old icon. To work around this a `settings.settledIcon` attribute has been added that is only updated when we receive data from the store ensuring that our cache-busting technique works correctly
2017-04-19 18:57:56 +02:00
.github Rename PULL_REQUEST_TEMPLATE to PULL_REQUEST_TEMPLATE.md 2016-05-23 10:50:15 +01:00
app 🐛 fix broken sidebar after successful import (#658) 2017-04-19 18:57:56 +02:00
config switch to ember-cli-moment-shim (#622) 2017-04-05 19:45:35 +02:00
lib 🐛 Fix HTML card not launching in edit mode (#647) 2017-04-18 19:20:38 +12:00
mirage switch to ember-cli-moment-shim (#622) 2017-04-05 19:45:35 +02:00
public/assets Revert svg icon stroke changes 2017-04-15 14:28:47 +01:00
tests 💄 convert editor acceptance tests to async/await (#654) 2017-04-20 01:21:37 +12:00
.editorconfig deps: ember-cli@2.8.0 2016-10-07 17:32:30 +01:00
.ember-cli grunt init, dev 2015-03-11 12:37:41 -06:00
.eslintrc.js 🐛 Fix HTML card not launching in edit mode (#647) 2017-04-18 19:20:38 +12:00
.gitignore chore(package): update ember-cli to version 2.9.0 (#354) 2016-10-21 09:07:49 +01:00
.travis.yml Re-enable yarn in Travis 2017-02-19 10:59:51 -06:00
.watchmanconfig deps: ember-cli@1.13.13 2015-11-30 11:21:39 -06:00
bower.json General Editor UI improvements. (#630) 2017-04-10 10:10:53 +01:00
ember-cli-build.js 🎨 animated retry icon 2017-04-14 16:16:52 +01:00
Gruntfile.js 🛠 switch to using yarn in our Grunt tasks (#613) 2017-04-04 11:36:17 +01:00
LICENSE 2017 2017-01-04 10:32:54 +00:00
package.json deps: ember-inline-svg@0.1.11 2017-04-14 16:08:46 +01:00
README.md Add code coverage badge to README (#486) 2017-01-11 13:09:26 +00:00
testem.js Update code to match eslint rules 2016-11-14 13:26:00 +00:00
yarn.lock deps: ember-inline-svg@0.1.11 2017-04-14 16:08:46 +01:00

Ghost-Admin

Build Status Coverage Status

This is the home of Ember.js based admin client that ships with Ghost. For now, refer to that repository for install and development instructions.

Have a bug or issue?

Bugs and issues (even if they only affect the admin client) should be opened on the core Ghost repository.

Copyright & License

Copyright (c) 2013-2017 Ghost Foundation - Released under the MIT license.