1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
Ghost-Admin/app
Kevin Ansfield a51fcba8cb
Don't destructure Ember.testing (#933)
no issue
- `Ember.testing` is or will soon be a getter/setter in Ember with the value set during a test, however destructuring will read the value when the module is evaluated
- moves all uses of `Ember.testing` inline
2018-01-02 10:19:59 +00:00
..
adapters Match service/controller import to ember-modules-codemod style for consistency 2017-10-30 09:38:01 +00:00
authenticators Match service/controller import to ember-modules-codemod style for consistency 2017-10-30 09:38:01 +00:00
authorizers deps: ember-simple-auth@1.0.0 2015-10-18 13:17:02 -05:00
components Don't destructure Ember.testing (#933) 2018-01-02 10:19:59 +00:00
controllers Don't destructure Ember.testing (#933) 2018-01-02 10:19:59 +00:00
helpers Match service/controller import to ember-modules-codemod style for consistency 2017-10-30 09:38:01 +00:00
html Remove wishlist links (#850) 2017-09-07 09:05:02 +02:00
initializers Upgrade eslint dependencies (#855) 2017-09-11 14:56:11 +07:00
mixins Don't destructure Ember.testing (#933) 2018-01-02 10:19:59 +00:00
models Use computed property brace expansion 2017-11-25 09:49:49 +00:00
routes Avoid leaking state in Ember objects 2017-11-25 09:49:49 +00:00
serializers Fix Ember deprecations and warnings (#895) 2017-10-13 16:39:49 +07:00
services Don't destructure Ember.testing (#933) 2018-01-02 10:19:59 +00:00
session-stores Update code to match eslint rules 2016-11-14 13:26:00 +00:00
styles Changed theme upload dragged-over border colour to match app colours 2017-11-14 12:27:14 +00:00
templates 🐛 Fixed blog icon not shown in nav (#918) 2017-11-30 20:12:01 +07:00
transforms Fixed missing Unsplash icons when API doesn't return an unsplash setting (#865) 2017-09-21 11:13:31 +02:00
utils Remove unused {{gh-datetime-input}} and related helper 2017-11-30 17:06:48 +07:00
validators Avoid leaking state in Ember objects 2017-11-25 09:49:49 +00:00
_config.yml The great migration (EAK -> ember-cli) 2015-03-11 12:37:41 -06:00
app.js Avoid leaking state in Ember objects 2017-11-25 09:49:49 +00:00
index.html 🤡 Serve own admin favicon (#619) 2017-04-06 17:28:51 +01:00
README.md Convert Sass to Myth 2015-05-22 19:05:09 +01:00
resolver.js deps: ember-cli@2.3.0 2016-02-16 12:32:48 -06:00
router.js Match service/controller import to ember-modules-codemod style for consistency 2017-10-30 09:38:01 +00:00
transitions.js Unsplash integration 2017-08-15 16:01:12 +01:00

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)