1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
Ghost-Admin/app
Paul Adam Davis b68ac115bf Re-add X icon
No issue

The `icon-x` class got messed up when I attempted to dry up our icon code in both https://github.com/TryGhost/Ghost/pull/4948 and 69fb78150d. All that was left was an `x` in the file.

This adds that class back, so the `icon-x` icon works again.
2015-04-02 10:42:32 +01:00
..
adapters Ember init, bower deps, es6 modules 2015-03-11 12:37:41 -06:00
assets/lib No more CodeMirror 2015-03-17 14:32:55 +00:00
components No more CodeMirror 2015-03-17 14:32:55 +00:00
controllers Fixed typos 2015-03-17 17:43:53 +00:00
helpers Ember init, bower deps, es6 modules 2015-03-11 12:37:41 -06:00
html The great migration (EAK -> ember-cli) 2015-03-11 12:37:41 -06:00
initializers Ember init, bower deps, es6 modules 2015-03-11 12:37:41 -06:00
mixins Fixed typos 2015-03-17 17:43:53 +00:00
models Ember init, bower deps, es6 modules 2015-03-11 12:37:41 -06:00
routes Ember init, bower deps, es6 modules 2015-03-11 12:37:41 -06:00
serializers Ember init, bower deps, es6 modules 2015-03-11 12:37:41 -06:00
styles Re-add X icon 2015-04-02 10:42:32 +01:00
templates Merge pull request #5026 from felixrieseberg/iss4978 2015-03-17 12:54:39 -06:00
transforms Ember init, bower deps, es6 modules 2015-03-11 12:37:41 -06:00
utils No more CodeMirror 2015-03-17 14:32:55 +00:00
validators Ember init, bower deps, es6 modules 2015-03-11 12:37:41 -06:00
views Ember init, bower deps, es6 modules 2015-03-11 12:37:41 -06:00
_config.yml The great migration (EAK -> ember-cli) 2015-03-11 12:37:41 -06:00
app.js Build assets with ember, and serve with ghost 2015-03-11 12:37:41 -06:00
index.html Serve files to core/built/assets/ 2015-03-12 15:59:02 -06:00
README.md The great migration (EAK -> ember-cli) 2015-03-11 12:37:41 -06:00
router.js Ember init, bower deps, es6 modules 2015-03-11 12:37:41 -06:00

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

Architecture

ToDo: Explain the basic Ember app structure.

client/
├── assets/
│   ├── ghost.css
│   └── ghost.min.css
├── things/
│   ├── things.js
│   └── things.min.js
└── things/
    ├── things.js
    └── things.js

SASS

All CSS is written in SASS and compiled using grunt. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Helpers - are pure-sass files. Variables/mixins/things which are generally never compiled to actual CSS, and are simply used to aid development.
  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)
  • Lib - is where we store styles for 3rd party components.

All of these separate files are subsequently imported and compiled in screen.scss.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid SASS over-nesting. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Eg. This requires a z-index in order to appear above mobile navigation. Not: This is a thing which is always on top!)