2
1
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2023-12-13 21:00:40 +01:00

Created migrations for page -> type column

refs #10822
This commit is contained in:
Fabien O'Carroll 2019-07-25 12:31:47 +08:00
parent a52f15d3d3
commit 51fb0815b4
3 changed files with 182 additions and 0 deletions

View file

@ -0,0 +1,44 @@
const common = require('../../../../lib/common');
const commands = require('../../../schema').commands;
const createLog = type => msg => common.logging[type](msg);
function createColumnMigration({table, column, dbIsInCorrectState, operation, operationVerb}) {
return function columnMigrations({transacting}) {
return transacting.schema.hasColumn(table, column)
.then(dbIsInCorrectState)
.then((isInCorrectState) => {
const log = createLog(isInCorrectState ? 'warn' : 'info');
log(`${operationVerb} ${table}.${column}`);
if (!isInCorrectState) {
return operation(table, column, transacting);
}
});
};
}
module.exports.up = createColumnMigration({
table: 'posts',
column: 'type',
dbIsInCorrectState(columnExists) {
return columnExists === true;
},
operation: commands.addColumn,
operationVerb: 'Adding'
});
module.exports.down = createColumnMigration({
table: 'posts',
column: 'type',
dbIsInCorrectState(columnExists) {
return columnExists === false;
},
operation: commands.dropColumn,
operationVerb: 'Removing'
});
module.exports.config = {
transaction: true
};

View file

@ -0,0 +1,94 @@
const Promise = require('bluebird');
const toPairs = require('lodash/toPairs');
const common = require('../../../../lib/common');
/*
* @param from: object with a SINGLE entry { 'fromColumn': 'fromValue' }
* @param to: object with a SINGLE entry { 'toColumn': 'toValue' }
*/
const createColumnToColumnMap = ({from, to, tableName}) => (connection) => {
return connection.schema.hasTable(tableName)
.then((tableExists) => {
if (!tableExists) {
common.logging.warn(
`Table ${tableName} does not exist`
);
return;
}
const [fromColumn, fromValue] = toPairs(from)[0];
const [toColumn, toValue] = toPairs(to)[0];
return Promise.all([
connection.schema.hasColumn(tableName, fromColumn),
connection.schema.hasColumn(tableName, toColumn)
]).then(([fromColumnExists, toColumnExists]) => {
if (!fromColumnExists) {
common.logging.warn(
`Table '${tableName}' does not have column '${fromColumn}'`
);
}
if (!toColumnExists) {
common.logging.warn(
`Table '${tableName}' does not have column '${toColumn}'`
);
}
if (!fromColumnExists || !toColumnExists) {
return;
}
common.logging.info(
`Updating ${tableName}, setting "${toColumn}" column to "${toValue}" where "${fromColumn}" column is "${fromValue}"`
);
return connection(tableName)
.where(fromColumn, fromValue)
.update(toColumn, toValue);
});
});
};
const createColumnToColumnMigration = ({tableName, from, to}) => {
return {
up: createColumnToColumnMap({from, to, tableName}),
down: createColumnToColumnMap({from: to, to: from, tableName})
};
};
const pageColumnToPageType = createColumnToColumnMigration({
tableName: 'posts',
from: {
page: true
},
to: {
type: 'page'
}
});
const pageColumnToPostType = createColumnToColumnMigration({
tableName: 'posts',
from: {
page: false
},
to: {
type: 'post'
}
});
module.exports.up = ({transacting}) => {
return Promise.all([
pageColumnToPageType.up(transacting),
pageColumnToPostType.up(transacting)
]);
};
module.exports.down = ({transacting}) => {
return Promise.all([
pageColumnToPageType.down(transacting),
pageColumnToPostType.down(transacting)
]);
};
module.exports.config = {
transaction: true
};

View file

@ -0,0 +1,44 @@
const common = require('../../../../lib/common');
const commands = require('../../../schema').commands;
const createLog = type => msg => common.logging[type](msg);
function createColumnMigration({table, column, dbIsInCorrectState, operation, operationVerb}) {
return function columnMigrations({transacting}) {
return transacting.schema.hasColumn(table, column)
.then(dbIsInCorrectState)
.then((isInCorrectState) => {
const log = createLog(isInCorrectState ? 'warn' : 'info');
log(`${operationVerb} ${table}.${column}`);
if (!isInCorrectState) {
return operation(table, column, transacting);
}
});
};
}
module.exports.up = createColumnMigration({
table: 'posts',
column: 'page',
dbIsInCorrectState(columnExists) {
return columnExists === false;
},
operation: commands.dropColumn,
operationVerb: 'Removing'
});
module.exports.down = createColumnMigration({
table: 'posts',
column: 'page',
dbIsInCorrectState(columnExists) {
return columnExists === true;
},
operation: commands.addColumn,
operationVerb: 'Adding'
});
module.exports.config = {
transaction: true
};