tqt/Ghost
2
1
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2023-12-13 21:00:40 +01:00
Code Issues 1 Releases Wiki Activity
35997 commits 101 branches 822 tags 285 MiB
Commit graph

668 commits

Author SHA1 Message Date
Peter Zimon
a5b62707ef
AdminX theme navigation experiment (#17210) 
refs. https://github.com/TryGhost/Product/issues/3349

It's a bit cumbersome how design and theme navigation is handled in
AdminX at the moment. On a high level, this PR applies the following
changes:

- Change theme is under Design settings
- After activating a theme, Design settings are automatically opened
 2023-07-06 12:03:01 +02:00
Jono M
e1fbfd3e12
Added HTML editor using koenig-lexical (#17217) 
refs https://github.com/TryGhost/Product/issues/3545

Used in portal settings for the signup message.
 2023-07-06 03:05:33 +00:00
Jono M
b9158215ee
Added portal icon picker in AdminX settings (#17216) 
refs https://github.com/TryGhost/Product/issues/3545
 2023-07-05 23:16:52 +00:00
Rishabh
79a7f8c408 Added basic routing for adminX settings 
refs https://github.com/TryGhost/Product/issues/3349

- adds basic routing in adminX settings based on hash url path
- adds new routing provider that manages hash routing across adminX
- updates sidebar navigation to update route directly
- updates theme/design settings to update route for opening edit modals
 2023-07-04 20:56:55 +05:30
Rishabh
56fcba1d27 Updated global Modals to handle after close method 
refs https://github.com/TryGhost/Product/issues/3349

- allows modals to call `afterClose` when removed in case the parent wants any action on modal close, like routing update
 2023-07-04 20:56:55 +05:30
Daniel Lockyer
1aeac9777e Enabled parallel testing for Playwright tests of apps 
- we should allow parallel test execution because it's faster than
  serial
 2023-07-04 16:08:06 +02:00
Peter Zimon
47a9eaadcc
AdminX Portal setting forms (#17201) 
refs. https://github.com/TryGhost/Product/issues/3545

Styles was not applied to AdminX Portal settings forms. Also a couple of new components had to be added for easer future form design and implementation.
 2023-07-04 15:18:19 +02:00
renovate[bot]
1c03280223 Update dependency @storybook/addon-styling to v1.3.2 2023-07-04 13:44:25 +02:00
renovate[bot]
8e8c64c622 Update storybook monorepo to v7.0.25 2023-07-04 12:44:42 +02:00
renovate[bot]
74f2e08b16 Update dependency vitest to v0.32.4 2023-07-04 12:24:03 +02:00
Jono M
1cc55eda2e
Updated portal popup to support selecting and updating tiers (#17192) 
refs https://github.com/TryGhost/Team/issues/3545
 2023-07-04 19:17:42 +12:00
Jono M
7f9f467fc6
Wired up basic settings in AdminX portal settings (#17191) 
refs https://github.com/TryGhost/Team/issues/3545
 2023-07-04 15:47:55 +12:00
Peter Zimon
de4186ab97
AdminX Portal UI (#17185) 
refs. https://github.com/TryGhost/Team/issues/3545

As the first step of Portal settings being rebuilt in AdminX, we needed a couple of static skeleton components to get started. For this we also had to extend the props of Preview modal component in the design system.
 2023-07-03 16:53:40 +02:00
Peter Zimon
dda42f521b
AdminX UI refinements (#17160) 
refs. https://github.com/TryGhost/Team/issues/3349

- Search field styling in AdminX sidebar was off
- Error guide was missing in AdminX
 2023-07-03 14:35:35 +02:00
renovate[bot]
8a4aac0c9f Update dependency cross-fetch to v3.1.8 2023-07-03 14:31:29 +02:00
Jono M
3811999be7
Improved AdminX theme installation flow (#17175) 
refs https://github.com/TryGhost/Team/issues/3349
 2023-07-03 17:59:31 +12:00
renovate[bot]
aa8cbb9fa3 Update dependency typescript to v5.1.6 2023-06-29 08:24:30 +02:00
Jono M
c03d3ff384
Factored out theme installed modal (#17158) 
refs https://github.com/TryGhost/Team/issues/3349

Will be reused in future changes, just doing a quick refactor first to
prevent conflicts
 2023-06-29 18:14:53 +12:00
Sodbileg Gansukh
d0bea0d607 Released Announcement-Bar v1.1.7 2023-06-29 08:35:07 +08:00
Sodbileg Gansukh
e8e2077548 Added box-sizing to the announcement bar 
no issues

- it overrides the default content-box behavior and prevents the bar becoming taller than it should be
 2023-06-29 08:33:39 +08:00
renovate[bot]
58b54333a5 Update dependency typescript to v5.1.5 2023-06-28 16:21:27 +02:00
renovate[bot]
a04a4293cb Update dependency vite-plugin-css-injected-by-js to v3.1.2 2023-06-28 16:21:00 +02:00
Simon Backx
5c843545d8 Added comments-ui editor E2E tests 
refs https://github.com/TryGhost/Team/issues/3504
 2023-06-28 13:08:35 +02:00
Jono M
9c2553a06a
Updated theme upload modal to show gscan errors (#17148) 
refs https://github.com/TryGhost/Team/issues/3349
 2023-06-28 19:54:21 +12:00
Jono M
768511c7cc
Added tests for more areas of AdminX settings (themes, design, multiselect) (#17134) 
refs https://github.com/TryGhost/Team/issues/3349

Tidies up the remaining major pieces which were not covered by tests.
Extends the existing test patterns, although the API mocks are getting a
bit unmanageable.
 2023-06-28 14:59:05 +12:00
renovate[bot]
5bcbb2de41 Update storybook monorepo to v7.0.24 2023-06-27 16:56:47 +02:00
Simon Backx
e6fe60ed37 Added E2E test for colorScheme in comments-ui 
refs https://github.com/TryGhost/Team/issues/3504
 2023-06-27 16:28:53 +02:00
Simon Backx
23fc00ae60 Added E2E tests for comments-ui accent color option 
refs https://github.com/TryGhost/Team/issues/3504

This also fixes an issue where the signup button would become transparent when the accent color option was not set
 2023-06-27 16:28:53 +02:00
Simon Backx
81970fbe01 Added E2E test for avatarSaturation on comments-ui 
refs https://github.com/TryGhost/Team/issues/3504
 2023-06-27 16:28:53 +02:00
Simon Backx
331533d724
Migrated Comments-UI to TypeScript (#17129) 
refs https://github.com/TryGhost/Team/issues/3504

This migrates comments-ui to TypeScript. Only `App.js` is left to
migrate, but since this isn't using hooks yet, it will need a bigger
rewrite so this will need to happen in a separate PR.
 2023-06-27 14:51:37 +02:00
Daniel Lockyer
549e608b27
Released Portal v2.33.4 2023-06-27 09:26:05 +02:00
Daniel Lockyer
bebf85f84a
Released Portal v2.33.3 2023-06-27 08:22:48 +02:00
renovate[bot]
2c6f30b4b8 Update dependency @storybook/addon-styling to v1.3.1 2023-06-27 07:33:22 +02:00
Jono M
0d8eb203bf
Updated AdminX search to use centralised configuration (#17106) 
refs https://github.com/TryGhost/Team/issues/3349
 2023-06-27 08:09:12 +12:00
Jono M
fdef6a30ab
Fixed default recipients behaviour when deselecting all tiers (#17133) 
refs https://github.com/TryGhost/Team/issues/3349
 2023-06-27 07:56:17 +12:00
renovate[bot]
0a6b3d6b99 Update dependency vite-plugin-commonjs to v0.8.0 2023-06-26 08:51:09 +02:00
Jono M
9e325d6b38
Added tests for user management (#17128) 
refs https://github.com/TryGhost/Team/issues/3349
 2023-06-26 15:12:46 +12:00
renovate[bot]
1cbbe91a63 Update dependency flexsearch to v0.7.31 2023-06-23 15:04:18 +02:00
Daniel Lockyer
8c5e2a53a9 Moved Admin-X-Settings to apps/ folder 
refs https://github.com/TryGhost/Toolbox/issues/594

- we're moving all the external apps into a different folder so we can
  keep `ghost/` for internal code
 2023-06-23 14:37:39 +02:00
renovate[bot]
9e6c800e38 Update dependency webpack-cli to v5 2023-06-23 08:29:15 +02:00
Simon Backx
9135ca92e0 Added Playwright test for comment reply pagination 
refs https://github.com/TryGhost/Team/issues/3504
 2023-06-22 19:09:21 +02:00
Simon Backx
8d6fb51908 Added Playwright tests to comments-ui 
refs https://github.com/TryGhost/Team/issues/3504

Not complete yet, but contains the basic structure and a few tests that work and should run in CI.
 2023-06-22 15:06:13 +02:00
Simon Backx
ab86e0d901 Removed Sentry and unused data options from comments-ui 
refs https://github.com/TryGhost/Team/issues/3504

- Sentry was never setup and we don't use it
- Styles have been moved to inline JS styles (no separate css file generated)
- App version was never used
- Improved current script tag detection
 2023-06-22 15:06:13 +02:00
Michael Barrett
a79035c2f6
🐛 Fixed portal free trial message incorrectly showing (#17095) 
no issue

Fixed portal free trial message incorrectly showing when signing up for
free. Message was showing due to `pageQuery` erroneously not being
passed down the call stack to `getSiteProducts`
 2023-06-22 13:38:33 +01:00
renovate[bot]
e723365cd5 Update storybook monorepo to v7.0.23 2023-06-22 12:31:42 +02:00
Simon Backx
098d2ad3d9 Updated comments-ui eslint rules 
refs https://github.com/TryGhost/Team/issues/3504

- Use same rules as signup-forms
- Updates files for the new rules
 2023-06-22 10:39:39 +02:00
Daniel Lockyer
dfd5c50b80
Configured yarn dev to allow starting Comments-UI 
refs https://github.com/TryGhost/Toolbox/issues/400

- this allows for easier development with Comments-UI
 2023-06-22 10:23:05 +02:00
Daniel Lockyer
130c9c3c6f
Updated test:unit script for Comments-UI 
refs https://github.com/TryGhost/Toolbox/issues/400

- this package won't pass tests on Node 16 because of the use of
  `fetch`, but that's ok because we publish using Node 18 anyway
- this switches the test command to just ensuring the package can build
 2023-06-22 10:01:07 +02:00
Daniel Lockyer
8fc09b9433
Removed unneeded files 
refs https://github.com/TryGhost/Toolbox/issues/400

- these files are no longer needed now the package is in the monorepo
 2023-06-22 09:57:43 +02:00
Daniel Lockyer
5da9264ea7
Updated lockfile 
- removed the imported one from comments-ui repo
 2023-06-22 09:51:25 +02:00
Daniel Lockyer
36af781a67
Migrated code + history from Comments-UI 
refs https://github.com/TryGhost/Toolbox/issues/400

- this moves comments-ui into the monorepo to aid with the development
  workflow
 2023-06-22 09:48:32 +02:00
Simon Backx
60f969c9c2 Locked resolutions of tiptap and prosemirror 2023-06-22 08:35:17 +02:00
Simon Backx
fbd268272a Fixed linting issues 2023-06-21 17:25:47 +02:00
Daniel Lockyer
346b9ff9e2 Added missing dependencies 
- both eslint and jsdom are needed to correctly run linting + tests
 2023-06-21 17:22:07 +02:00
Daniel Lockyer
fcce6d8519 Removed react-scripts dependency 
refs 13d3d0cde6

- this is no longer needed because we've migrated to Vite
 2023-06-21 17:19:14 +02:00
Daniel Lockyer
2df3caa159 Removed use of Cypress eslint plugin 
refs 13d3d0cde6

- we removed cypress in the referenced commit so this is no longer
  needed
 2023-06-21 17:18:00 +02:00
Simon Backx
0f86300757 Added missing changes from previous commit 
no issue

Updated package and yarn.lock
 2023-06-21 15:37:12 +02:00
Simon Backx
13d3d0cde6 Migrated from Webpack to Vite and updated dependencies 
refs https://github.com/TryGhost/Team/issues/3504

- Removed Cypress. Tests will get replaced by Playwright
- Removed unused files and HTML files
- Updated scripts to work similar to Portal, Signup-Form
- Updated to pinned dependencies and removed unused dependencies
 2023-06-21 15:28:01 +02:00
renovate[bot]
a441d9dab3 Update dependency react-error-overlay to v6.0.11 2023-06-21 14:43:21 +02:00
renovate[bot]
7a7013dc9c Update dependency bson-objectid to v2.0.4 2023-06-21 14:43:08 +02:00
renovate[bot]
2666b2cec4 Update dependency source-map-explorer to v2.5.3 2023-06-21 14:42:51 +02:00
renovate[bot]
bc0a741df4 Update dependency cypress to v10.11.0 2023-06-21 14:42:39 +02:00
renovate[bot]
777ea0912c Update dependency minimist to v1.2.8 2023-06-21 12:46:16 +02:00
renovate[bot]
ddec966e5d Update dependency tailwindcss to v3.3.2 2023-06-21 12:46:05 +02:00
renovate[bot]
e98d9e3f3c Update dependency chokidar to v3.5.3 2023-06-21 12:41:49 +02:00
renovate[bot]
6e0e9e02ca Update dependency postcss to v8.4.24 2023-06-21 12:41:39 +02:00
renovate[bot]
e8f5ea0f33 Update dependency serve-handler to v6.1.5 2023-06-21 12:41:12 +02:00
Daniel Lockyer
8d611112a1 Updated Renovate config to quietJS 
- this is our homegrown Renovate preset that should keep things quiet around here
 2023-06-21 12:35:40 +02:00
Daniel Lockyer
08aef4fbb4 Pinned dependencies 
- this is an app so we want to pin dependencies to ensure we know what
  version they're using
 2023-06-21 12:26:56 +02:00
renovate[bot]
94242ec627 Update dependency @testing-library/react to v12.1.5 2023-06-21 12:19:41 +02:00
renovate[bot]
5a426e5575 Update dependency @testing-library/jest-dom to v5.16.5 2023-06-21 12:17:06 +02:00
renovate[bot]
7a7629620b Add renovate.json 2023-06-21 12:15:03 +02:00
Hannah Wolfe
3a58b6402a Update dependency eslint-plugin-ghost to v3.2.0 
refs: https://github.com/TryGhost/Toolbox/issues/595

- Adds custom rules for node assert
- Enforces assert/strict as an error
 2023-06-21 10:34:37 +01:00
Sodbileg Gansukh
19b8bd2b50 Released Announcement-Bar v1.1.6 2023-06-21 17:04:56 +08:00
Sodbileg Gansukh
c1cd18b526 Added correct cursor style to announcement bar links 2023-06-21 17:03:58 +08:00
Hannah Wolfe
6161f94910
Updated to use assert/strict everywhere (#17047) 
refs: https://github.com/TryGhost/Toolbox/issues/595

We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default.

This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results:
- Url matching needs to be done on `url.href` see aa58b354a4
- Null and undefined are not the same thing,  there were a few cases of this being confused
- Particularly questionable changes in [PostExporter tests](c1a468744b) tracked [here](https://github.com/TryGhost/Team/issues/3505).
- A typo see eaac9c293a

Moving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
 2023-06-21 09:56:59 +01:00
Simon Backx
3e932458a4 Released Signup Form v0.1.3 2023-06-21 10:48:22 +02:00
Simon Backx
40f71cb79b 🐛 Fixed accessibility issue with hidden success message in signup form 
refs https://ghost.slack.com/archives/CTH5NDJMS/p1686928938857799

The button read 'Subscribe email sent' on screen readers.
 2023-06-21 10:38:27 +02:00
Daniel Lockyer
1be11e4648
Fixed include path for signup-form translations 
- this fixes the path after we moved the signup-form folder between
  workspace folders
 2023-06-21 09:12:28 +02:00
renovate[bot]
e3c9af380c Update dependency @storybook/testing-library to v0.2.0 2023-06-21 08:12:26 +02:00
Daniel Lockyer
5c4ef092b6 Updated vitest to v0.32 
refs https://github.com/TryGhost/Ghost/pull/16949
refs https://github.com/vitest-dev/vitest/releases/tag/v0.32.0

- contains a switch from `@vitest/coverage-c8` to `@vitest/coverage-v8`
  as this is now required in 0.32
 2023-06-20 14:54:04 +02:00
renovate[bot]
ea3ab6beb6 Update dependency @vitejs/plugin-react to v4.0.1 2023-06-20 08:09:23 +02:00
Daniel Lockyer
2173fd9ef9 Moved signup-form to apps/ folder 
refs https://github.com/TryGhost/Toolbox/issues/594

- we're moving all the standalone apps to a separate folder to keep them
  out of the core code and easier to find
 2023-06-19 09:43:33 +02:00
Daniel Lockyer
e13fcd3272
Released Portal v2.33.2 2023-06-16 13:41:31 +02:00
Daniel Lockyer
f3894d5898 Moved Portal to apps/ 
refs https://github.com/TryGhost/Toolbox/issues/594

- we're moving all the standalone apps to a separate folder to keep them
  out of the core code and easier to find
 2023-06-16 13:37:58 +02:00
Elena Baidakova
333471c263 Released Announcement-Bar v1.1.5 2023-06-15 09:54:19 +04:00
Daniel Lockyer
7a124a6901 Moved announcement-bar to apps/ 
refs https://github.com/TryGhost/Toolbox/issues/594

- we're moving all the standalone apps to a separate folder to keep them
  out of the core code and easier to find
 2023-06-14 12:28:55 +02:00
Daniel Lockyer
fa43a0236b Moved Sodo-Search into apps/ 
refs https://github.com/TryGhost/Toolbox/issues/594

- this is the first of a set of commits to move our "apps" into the
  `apps/` folder, so we don't mix Ghost core and standalone apps
 2023-06-14 12:10:57 +02:00
Daniel Lockyer
33fa048c7e Pinned dependencies 
- Comments-UI is an app so we should pin the dependencies to ensure we
  know what version it is running
 2023-03-21 09:59:12 +01:00
Daniel Lockyer
fac4ec7876 Fixed minor linting issues 
- these classes needed to be reordered to satisfy eslint-plugin-tailwindcss
 2023-03-17 12:19:52 +01:00
Sodbileg Gansukh
1892be929b v0.12.4 2023-03-14 18:46:10 +08:00
Rishabh
7aa1281e45 Fixed build script not working on Node 18.x 
- `yarn start:dev` was failing with `error:0308010C:digital envelope routines::unsupported` without the `--openssl-legacy-provider` option on Node 18. Currently react-scripts@4.x doesn't support Node 18, so until we upgrade to use react-scripts@5.x we'll need to pass in this change for build scripts
 2023-03-14 15:42:40 +05:30
Sodbileg Gansukh
be7e3f3e62 Fixed invisible top border issue of the form input (#14) 
refs https://github.com/TryGhost/Team/issues/2615
 2023-03-14 18:11:49 +08:00
James Morris
4abbb0a8ca v0.12.3 2022-11-11 15:33:51 +00:00
James Morris
a41259be27 Fix the word break for long links in comments on mobile 
refs https://github.com/TryGhost/Team/issues/2245
 2022-11-11 15:31:34 +00:00
James Morris
9bcdfb911d Removed the duplicate sm config 
refs https://github.com/TryGhost/Team/issues/2244
 2022-11-11 15:25:57 +00:00
James Loh
62149ea747 v0.12.2 2022-11-08 10:06:51 +11:00
Kevin Ansfield
c334afef3a v0.12.1 2022-11-07 22:45:15 +00:00
Kevin Ansfield
fcf8570393 🐛 Fixed error rendering count with no number (#13) 
refs https://github.com/TryGhost/Team/issues/2221

- added guard to `formatNumber` helper used in the `<Count>` component via the `<ContentTitle>` component so a missing count prop is handled gracefully
 2022-11-07 22:40:58 +00:00
e.baidakova
cb6bf40f56 v0.12.0 2022-11-04 09:28:47 +04:00
James Morris
6956b82245 Add comma separators to all numbers in comments 
refs https://github.com/TryGhost/Team/issues/2210
 2022-11-03 15:47:49 +00:00
e.baidakova
40c26a26f6 v0.11.0 2022-11-02 10:22:49 +04:00
Elena Baidakova
290e3d5713 Updated counts api url (#12) 
closes TryGhost/Team#2094
- Counts request was changed from `post` to `get` for enable request caching.
 2022-11-02 10:02:26 +04:00
Simon Backx
883a9728ca v0.10.3 2022-10-10 11:45:22 +02:00
Simon Backx
a2daf2e448 🐛 Fixed CMD+C focussing main form 
fixes https://github.com/TryGhost/Ghost/issues/15563
 2022-10-10 11:43:07 +02:00
James Morris
1a00c070d1 v0.10.2 2022-10-06 16:25:19 +01:00
James Morris
92dec78902 Improving the border, text and buttons to work in light, dark and other weird colours 
- Changed all borders to work better in different background colours
- Same goes for main buttons like pagination for main and reply
- Same goes for any secondary text which should help

no issue
 2022-10-06 16:06:40 +01:00
Simon Backx
ec586d02af Removed start-server-and-test dev dependency 2022-09-09 17:34:21 +02:00
Simon Backx
68c2e6a30d Removed Cypress from CI 
refs 24af5ad0dd

CI is not working yet with Cypress atm.
 2022-09-09 17:32:57 +02:00
Simon Backx
24af5ad0dd Added experimental Cypress tests 
refs https://github.com/TryGhost/Team/issues/1780

This commit adds some Cypress tests as a POC to the project. If we decide to go with Cypress, we can add more tests to cover the rest of the codebase. The main reason to have a E2E framework is that some editor related UI is hard to test with the React tests because it uses JSDOM.
 2022-09-09 17:27:32 +02:00
Simon Backx
ddbc2db76d Fixed error when not signed in as admin 
no issue

When loading comments UI without being logged in as an admin, it would throw an error every time when unpacking result.users[0].
 2022-09-09 12:05:14 +02:00
Simon Backx
500ebf0de2 Prevented relative time updates on comment state changes 
no issue

When the state of a comment changes (e.g., after a like) the relative time would update. This is not desirable because it looks glitchy. If the relative time doesn't update every second, then it is better to never update it after the initial render.
 2022-09-09 11:52:26 +02:00
Simon Backx
f72e804d08 Removed event bus 2022-09-09 11:48:24 +02:00
Simon Backx
527abdbcd6 Cleaned up ContentBox and PopupBox 2022-09-09 11:46:55 +02:00
Simon Backx
65dd6bd1d6 Cleaned up component props 2022-09-09 11:46:08 +02:00
Simon Backx
87729cd0ee Splitted Content component from ContentBox 2022-09-09 11:38:52 +02:00
Simon Backx
d63e75f0a2 Cleaned up Form and splitted it into multiple components (#9) 
refs https://github.com/TryGhost/Team/issues/1858
 2022-09-09 11:25:34 +02:00
Ronald Langeveld
7e95bfd42c V0.10.1 2022-09-09 09:20:08 +02:00
Ronald Langeveld
71b81c8995 Replaced missed memberBio with memberExpertise 
no issue
 2022-09-09 09:12:13 +02:00
Ronald Langeveld
878e5eba1d Replaced all references of "Bio" to "Expertise" for Comments (#10) 
ref https://github.com/TryGhost/Team/issues/1772

- all references of "Bio" to "Expertise" for Comments
- this commit is a breaking change as it relies on the API that returns `expertise` instead of `bio`.
 2022-09-09 09:05:39 +02:00
James Morris
778080eebe Added better support for dark mode and other background colours 
no issue
 2022-09-07 11:14:57 +01:00
James Morris
4625026fc2 Made some tweaks to the pagination buttons to look less like dividers 
no issue
 2022-09-05 16:53:05 +01:00
Simon Backx
8a26164200 Fixed ReplyButton text 2022-09-01 15:09:34 +02:00
Simon Backx
92accd76f0 Added Button suffix to all Button components 
refs https://github.com/TryGhost/Team/issues/1858
 2022-08-31 15:35:44 +02:00
Simon Backx
e8eeacac9e Renamed PopupModal to PopupBox 
refs https://github.com/TryGhost/Team/issues/1858

- PopupBox better reflects that it contains a Popup and is not a Popup
- In line with ContentBox, that contains the iframe with the comments content
 2022-08-31 15:31:38 +02:00
Simon Backx
fd7cebe906 Renamed dialogs to popups 
refs https://github.com/TryGhost/Team/issues/1858

Better to use the same terminology everywhere, and the name 'popup' is already used in Portal.
 2022-08-31 15:30:05 +02:00
Simon Backx
bea90b0922 Renamed CommentsBox to ContentBox and splitted Title component 
refs https://github.com/TryGhost/Team/issues/1858
 2022-08-31 15:25:49 +02:00
Simon Backx
a28ee5c133 Updated components folder structure 
refs https://github.com/TryGhost/Team/issues/1858
 2022-08-31 15:09:48 +02:00
Simon Backx
a7bfd8d878 Updated tests for new iframe title 2022-08-31 14:54:43 +02:00
Simon Backx
bcb23bc9dc Cleaned up Frame components 
refs https://github.com/TryGhost/Team/issues/1858
 2022-08-31 14:52:49 +02:00
Simon Backx
02a514f17c Removed style option from Frame component 2022-08-31 14:36:26 +02:00
Simon Backx
c3c00d0215 Fixed linting issues 2022-08-31 14:20:23 +02:00
Simon Backx
c803f7454e Fixed secundaryFormCount debug counter visible 
no issue
 2022-08-31 13:29:23 +02:00
Simon Backx
90e0ced175 Added separate BlankAvatar component 
refs https://github.com/TryGhost/Team/issues/1858
 2022-08-31 13:29:01 +02:00
Simon Backx
b701ba9c0d Cleaned up Comment component (#8) 
refs https://github.com/TryGhost/Team/issues/1858
fixes https://github.com/TryGhost/Team/issues/1789

- Split up the Comment component in many small Components to make it easier to read and maintain
- Added support for synchronous actions, which are required for actions that affect the context state based on the current value (e.g., increasing a value by one) because of the asynchronous nature of setState:

Before this change
```
// Context state: {hello: 0};
dispatchAction('increaseHelloByOne')
dispatchAction('increaseHelloByOne')
```

Could end up having a state `{hello: 1}` instead of the expected `{hello: 2}`, because underlying this would resolve into:

```
// Context state: {hello: 0};
const hello = {hello: 0};
setState({hello: hello + 1});
setState({hello: hello + 1});
```

Instead of

```
// Context state: {hello: 0};
setState(({hello}) => {hello: hello + 1});
setState(({hello}) => {hello: hello + 1});
```

Synchronous actions now support this.

- Removed deprecated `onAction` context state function
- Replaced the boolean based form checking by the more reliable counter based checking that uses synchronous actions (reason we needed synchronous actions) (fixes https://github.com/TryGhost/Team/issues/1789)
- Prevent creating a new `dispatchAction` function every time the context state changes, by using bind. This prevents infinte updates in `useEffect` hooks that depend on `dispatchAction` and also update the context via actions.
 2022-08-30 16:25:40 +02:00
James Morris
3a29a55228 Added eslinting to better manage Tailwind classes 2022-08-30 14:53:35 +01:00
James Morris
455cba4da2 Fixed the transparent background on text input for light mode 2022-08-30 10:38:17 +01:00
Simon Backx
31c2174d47 v0.9.2 2022-08-15 12:45:46 +02:00
Peter Zimon
e95e93618f Refined spacings for paragraphs and blockquotes 
- paragraphs had a bit too much bottom margin
- blockquotes missed bottom margin
 2022-08-15 12:42:40 +02:00
Simon Backx
6274e90e27 v0.9.1 2022-08-15 12:34:45 +02:00
Simon Backx
c8d4b89ac7 🐛 Added line break on Shift + Enter 
refs https://github.com/TryGhost/Team/issues/1793

Included in the @tiptap/extension-hard-break extension.
 2022-08-15 12:32:59 +02:00
Simon Backx
41623a6512 v0.9.0 2022-08-15 11:30:18 +02:00
Simon Backx
2b83af85d1 🐛 Fixed popups not closing correctly 
refs https://ghost.slack.com/archives/C02G9E68C/p1660323308235919

- When opening and closing a popup very fast, it will stay in DOM, blocking all pointer events.
- The Headless UI component <Transition show={show}> is not removed from DOM when show is set to true, and false very fast
- Fixed this by forcing a popup to get removed from DOM after 250ms after is has been closed.
- Updated HeadlessUI version
- Moved testing packges to dev dependencies
 2022-08-15 10:22:26 +02:00
Simon Backx
bf698c9a75 v0.8.0 2022-08-12 15:56:07 +02:00
Simon Backx
e44415eb6f Cleaned up margin syntax 2022-08-12 15:51:35 +02:00
Simon Backx
99ae23cf23 Excluded the last paragraph from bottom margin 2022-08-12 15:50:32 +02:00
James Morris
398a410ba2 Fixed up the paragraph spacing in the editor 
no issue
 2022-08-12 14:23:18 +01:00
James Morris
ee210d80b6 v0.7.0 2022-08-12 14:03:38 +01:00
Simon Backx
991e0856b8 Removed unused jsom import 2022-08-12 14:47:31 +02:00
Simon Backx
11c3dcc77a Fixed comment content missing after unhiding them 
fixes https://github.com/TryGhost/Team/issues/1786
 2022-08-12 14:22:48 +02:00
Simon Backx
de30741fce Added unlike spy 2022-08-12 14:17:35 +02:00
Simon Backx
75510aac5e Added like and unlike tests 
refs https://github.com/TryGhost/Team/issues/1780
 2022-08-12 14:15:48 +02:00
James Morris
39629145d0 Added in more spacing for the CTAs to catch more ophans 
no issue
 2022-08-12 13:08:32 +01:00
James Morris
001229801d Fixed up some small dark mode problems 
- The loading spinner in dark mode wasn't black
- The action buttons didn't hover correctly in dark mode

no issue
 2022-08-12 11:19:01 +01:00
Simon Backx
42d69562d9 Added test for replies and deleted members 
refs https://github.com/TryGhost/Team/issues/1780
 2022-08-12 11:19:48 +02:00
James Morris
2d79ef7cf9 Fixed local warnings in the terminal when building for comments 
no issue
 2022-08-12 09:29:29 +01:00
James Morris
fa056be39b Fixed pagination buttons to show singular values properly 
refs https://github.com/TryGhost/Team/issues/1782
 2022-08-12 08:56:19 +01:00
James Morris
34004cd135 Added in precise fixed width buttons for form 
- Reduces large widths of the buttons and so now variable
- Added fixed width to keep button same width when sending

refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 17:14:00 +01:00
James Morris
63476f6eca Updated the shadow to bring a little more contrast 
refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 16:56:26 +01:00
James Morris
52cfac284f Added in some spacing to the CTA when there are comments 
refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 16:41:57 +01:00
Simon Backx
163367dd93 Removed transformApiSiteData import 2022-08-11 17:29:37 +02:00
Simon Backx
58d32b3c82 Implemented dark mode tests 
refs https://github.com/TryGhost/Team/issues/1780
 2022-08-11 17:28:41 +02:00
Simon Backx
ef4cfc9b9a Readded auth frame test and improved test structure 
refs https://github.com/TryGhost/Team/issues/1780
 2022-08-11 17:11:26 +02:00
James Morris
6abd6f6d03 Updated the report dialog to a nicer style 
refs https://github.com/TryGhost/Team/issues/1778
 2022-08-11 16:07:37 +01:00
Simon Backx
fd21a88d52 Added first basic comments test 2022-08-11 16:40:10 +02:00
James Morris
3b7d26154e Added in the comment border line when replying with no replies 
refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 15:35:04 +01:00
James Morris
91134ecb62 Pushed some changes to the profile modal for comments 
- Includes a fix to the close button when on mobile
- Has some tweaks suggested by Zimo to bring in line with Portal

refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 15:30:34 +01:00
Simon Backx
24f384b0a2 Fixed calculating if reply form is in viewport 2022-08-11 15:16:36 +02:00
James Morris
e130c2edcd Tweaked non-published comments in dark mode 
refs https://github.com/TryGhost/Team/issues/1775
 2022-08-11 13:57:35 +01:00
James Morris
1e72a267a3 Pushed a little fix to the dark mode for the comment border 
refs https://github.com/TryGhost/Team/issues/1777
 2022-08-11 13:53:42 +01:00
Simon Backx
ceaecf43e6 Updated form to only close when another form opens and scroll better 
fixes https://github.com/TryGhost/Team/issues/1753
refs https://github.com/TryGhost/Team/issues/1758

- Scroll only if form is not in viewport + scroll to center
- Fixes: You can’t tap reply if another reply box is open (or at least you have to tap a bunch of times)
 2022-08-11 14:46:14 +02:00
James Morris
4a0ad8c6bc Little style tweaks to comment replies border and pagination border 
refs https://github.com/TryGhost/Team/issues/1777
 2022-08-11 12:41:27 +01:00
James Morris
6db7d9bd2d Fixes for super long expertise in form and comments 
refs https://github.com/TryGhost/Team/issues/1758
 2022-08-11 12:35:38 +01:00
James Morris
5e8ebe44b8 Adding in a subtle border for the comments when it has replies 
refs https://github.com/TryGhost/Team/issues/1777
 2022-08-11 11:54:28 +01:00
James Morris
9a306a2db2 Posted a few little tweaks to the deleted/hidden comment 
refs https://github.com/TryGhost/Team/issues/1775
 2022-08-11 11:26:05 +01:00
James Morris
ba8df169ad Changed the markup layout of the comments to fix a positoning problem when expertise is too long on mobile 
- When the Expertise is too long, it can cause a broken look to comments on mobile
- Changed how the markup works to better handle the details
 2022-08-11 10:09:14 +01:00
James Morris
0cf0c5833a This seems to fix the modal zooming on iOS 
refs https://github.com/TryGhost/Team/issues/1758
 2022-08-11 09:16:55 +01:00
Simon Backx
12b224e17a v0.6.0 2022-08-11 10:03:22 +02:00
James Morris
a64f13ae2d Some attempts to fix some issues with comments on mobile 
refs https://github.com/TryGhost/Team/issues/1758
 2022-08-10 17:36:00 +01:00
James Morris
bcad43c5a4 Added back the padding so comment boxes don't open full width again on desktop 
refs https://github.com/TryGhost/Team/issues/1758
 2022-08-10 17:36:00 +01:00
James Morris
0ae689dbfb Added a small tweak to CTAs on mobile 
refs https://github.com/TryGhost/Team/issues/1754
 2022-08-10 17:36:00 +01:00
Simon Backx
94d72c2846 Wired up publication name attribute 
fixes https://github.com/TryGhost/Team/issues/1776
 2022-08-10 17:34:28 +02:00
Simon Backx
35ed0af99d Fixed releasing mouse outside modals closing it 
fixes https://github.com/TryGhost/Team/issues/1769
 2022-08-10 16:45:45 +02:00
Simon Backx
bf9e190e15 Added reply pagination (#7) 
refs https://github.com/TryGhost/Team/issues/1723

- Moved usage from likes_count to count.likes
- Implemented real reply pagination based by an ID filter
- The backend now returns the relations correctly when creating new comments, so we don't need to fix them any longer.
 2022-08-10 16:14:42 +02:00
Simon Backx
b703ddd703 Fixed C keyboard shortcut when input is focused 
fixes https://github.com/TryGhost/Team/issues/1767

- Only focus the form if there is no other input focused on the page
 2022-08-10 15:46:14 +02:00
James Morris
1640901114 Added in the accent colour to the add details modal for comments 
refs https://github.com/TryGhost/Team/issues/1768
 2022-08-09 19:12:22 +01:00
James Morris
56facd62aa Adding more tweaks to the modals to ensure works well across platforms 
refs https://github.com/TryGhost/Team/issues/1756
 2022-08-09 18:58:21 +01:00
James Morris
82cc974549 Updated the copy and logic for the CTAs 
refs https://github.com/TryGhost/Team/issues/1754
 2022-08-09 18:29:07 +01:00
Fabien "egg" O'Carroll
fbdb70330f v0.5.0 2022-08-09 15:15:41 +01:00
Fabien "egg" O'Carroll
37db4df98a Added handling for updating comment count based on local actions 
refs https://github.com/TryGhost/Team/issues/1761
 2022-08-09 13:41:14 +01:00
Fabien "egg" O'Carroll
b908db41d1 Fixed pluralisation for comment count when there is just one 2022-08-09 13:41:14 +01:00
Fabien "egg" O'Carroll
4b453a8b3a Updated comment count to use the /comments/count API 
refs https://github.com/TryGhost/Team/issues/1763

We still need to use the pagination for the other checks because these
are based on how many comments are visible, which includes deleted or
hidden comments.

By using the /comments/count API we ensure that any changes to the
calculation of comments is replicated by both the comment_count
helper, as well as the comments-ui
 2022-08-09 13:41:14 +01:00
James Morris
3a48518407 Few adjustments to the CTAs 
- Keep tweaking the spacing
- Added a plan link for paid CTAs

refs https://github.com/TryGhost/Team/issues/1754
 2022-08-09 13:12:08 +01:00
James Morris
20fe790e5d First round of improving the name and bio modal 
refs https://github.com/TryGhost/Team/issues/1756
 2022-08-09 12:40:59 +01:00
James Morris
2629c5704d Combining the two CTA boxes into one and updating the copy 
refs https://github.com/TryGhost/Team/issues/1754
 2022-08-09 08:50:10 +01:00
James Morris
ac3dd62e6e Added in a hover state for editng bio 
- Improved the affordance for editing bio
- Added a new edit icon for this

refs https://github.com/TryGhost/Team/issues/1756
 2022-08-08 16:22:46 +01:00
James Morris
2b2b7c540b First round of CTA and empty state updates based on feedback 
- Added in a new line for further explanation
- Adjusted various text sizes and spacings
- Put back in the bottom border
- Currently has a hardcoded publication name for wiring up

refs https://github.com/TryGhost/Team/issues/1754
 2022-08-08 15:12:19 +01:00
James Morris
fa9b22e2c6 Removed the left and right spacing around the textbox when there are no comments 
refs https://github.com/TryGhost/Team/issues/1752
 2022-08-05 14:57:08 +01:00
Simon Backx
a1a0bf6723 Fixed blinking when bluring reply form 
fixes https://github.com/TryGhost/Team/issues/1749

Transition syntax was not working, and unused. The transition component also caused a delay, which caused the blinking.
 2022-08-05 15:24:38 +02:00
James Morris
a84bcc3d30 Removed the bottom margin from signed out boxes 
- After some trying things out, just removed that now
- There should be no more bottom spacing apart from what's in the iFrame now

refs https://github.com/TryGhost/Team/issues/1747
 2022-08-05 14:22:24 +01:00