Commit Graph

1921 Commits

Author SHA1 Message Date
Renovate Bot 58fcf70f23 Update dependency sanitize-html to v1.27.1 2020-07-21 17:54:29 +00:00
Renovate Bot 80603e218c Update dependency netjet to v1.4.0 2020-07-21 17:36:24 +00:00
Renovate Bot 9587af5dd0 Update dependency grunt to v1.2.1 2020-07-21 17:04:24 +00:00
Renovate Bot d0b9d6be0c Update dependency @sentry/node to v5.20.0 2020-07-21 16:31:12 +00:00
Daniel Lockyer 55948ef4a6 v3.26.0 2020-07-21 13:45:57 +01:00
Fabien O'Carroll 73badf150f 🐛 Fixed race condition when configuring Stripe
closes #12065

Includes the code from https://github.com/TryGhost/Members/pull/185
2020-07-21 14:22:06 +02:00
Fabien O'Carroll 0fe80edc0a 🐛 Fixed Stripe Subscriptions with trail periods
no-issue

This fixes a problem when subscribing to a Plan (Price) with a default
trial period. We also add logging to add a little more information about
which flow we're entering.

Subscriptions that are started with a trial have a
present on the Checkout Session object, which was incorrectly causing us
to determine that we are in a setup flow and attempt to update a
customers card details.

We now use the  property of the Checkout Session to determine
whether we are handling a new Subscription, or if we are in a setup
flow and should update the Customer's card details.

Includes the code from https://github.com/TryGhost/Members/pull/184
2020-07-21 14:22:06 +02:00
Fabien O'Carroll 1822e5d23e 🐛 Fixed webhook cleanup to handle older URLs
closes #12061

Includes the code from https://github.com/TryGhost/Members/pull/181
2020-07-21 14:22:06 +02:00
Renovate Bot 09ff9cd331
Update dependency @tryghost/members-ssr to v0.8.3 2020-07-21 11:48:24 +00:00
Renovate Bot 3f08443e26
Update dependency @tryghost/magic-link to v0.4.11 2020-07-21 10:05:00 +00:00
Renovate Bot b3aec95230
Update dependency express-hbs to v2.3.4 2020-07-20 10:57:49 +00:00
Renovate Bot 32a043c27c
Update dependency eslint to v7.5.0 2020-07-20 05:35:46 +00:00
Renovate Bot 33813962d3
Update dependency @sentry/node to v5.19.2 2020-07-14 08:04:55 +00:00
Daniel Lockyer ae68d090ca v3.25.0 2020-07-13 14:52:36 +01:00
Fabien O'Carroll 832ecad43b Improved handling of Stripe webhooks on boot
no-issue

This version of members-api includes changes to how webhooks are
managed, previously they would be deleted and recreated on every boot of
Ghost. Now they are created and the secret is persisted, on boot the
webhook is updated to the most current url and events. If the api
version is wrong or the update fails, the webhook is deleted and
recreated and the settings updated.

 - Installed @tryghost/members-api@0.24.0
 - Updated config to work with 0.24.0
2020-07-10 17:43:46 +02:00
Daniel Lockyer 59ef5c0ef5 v3.24.0 2020-07-10 14:26:50 +01:00
Renovate Bot fe962345af
Update dependency knex to v0.21.2 2020-07-09 22:13:35 +00:00
Daniel Lockyer 872c2dc4b3 v3.23.1 2020-07-09 10:05:08 +01:00
Renovate Bot 746e7ce3f2 Update dependency @sentry/node to v5.19.1 2020-07-09 07:50:29 +01:00
Renovate Bot 08edb08d3f
Update dependency lodash to v4.17.19 2020-07-08 17:37:40 +00:00
Renovate Bot c8f8896661
Update dependency lodash to v4.17.18 2020-07-08 16:28:46 +00:00
Rish 659900d01c Bumped @tryghost/members-api to 0.23.2
no issue

🐛 Fixed incorrect payload creation for magic link token
2020-07-08 21:57:25 +05:30
Renovate Bot 74c27aabbb
Update dependency lodash to v4.17.17 2020-07-08 14:24:53 +00:00
Daniel Lockyer 63426f3a42 v3.23.0 2020-07-08 15:23:23 +01:00
Renovate Bot 6996922ed0 Update dependency express-jwt to v6 [SECURITY] 2020-07-08 15:09:54 +02:00
Renovate Bot f4a060c923
Update dependency @tryghost/members-ssr to v0.8.2 2020-07-08 12:32:29 +00:00
Renovate Bot ec48cccadb
Update dependency @tryghost/members-csv to v0.2.1 2020-07-08 11:07:53 +00:00
Renovate Bot 5dfbc05b5f
Update dependency @tryghost/members-api to v0.23.1 2020-07-08 10:06:02 +00:00
Renovate Bot 60940253ad
Update dependency @tryghost/magic-link to v0.4.10 2020-07-08 08:25:12 +00:00
Daniel Lockyer 8956a9df35 Merged 3.22.2 into master
* tag '3.22.2':
  v3.22.2
  Updated Ghost-Admin to v3.22.2
  Emitted all settings events on reinit of cache (#12012)
  🐛 Updated access to be true by default in v3 API
  Hardened members subscription migration against missing data (#12009)
2020-07-06 16:19:55 +01:00
Daniel Lockyer ae80f742d3 v3.22.2 2020-07-06 16:17:13 +01:00
Renovate Bot d5d6a25600
Update dependency ajv to v6.12.3 2020-07-06 00:06:33 +00:00
Renovate Bot afcb4f099e
Update dependency eslint to v7.4.0 2020-07-03 21:00:03 +00:00
Kevin Ansfield 061d8c6ac3 🐛 Fixed stretched images appearing in emails
on issue

- upgraded `@tryghost/kg-default-cards` so that `srcset` and `sizes` attributes are not added to images when rendering post content used in emails
2020-07-03 10:16:05 +01:00
Renovate Bot dd270b399c
Update dependency @tryghost/session-service to v0.1.5 2020-07-02 21:05:52 +00:00
Renovate Bot a869e6c6c0
Update dependency @tryghost/mw-session-from-token to v0.1.5 2020-07-02 19:11:24 +00:00
Renovate Bot 4e859fff45
Update dependency @tryghost/adapter-manager to v0.1.7 2020-07-02 17:04:24 +00:00
Kevin Ansfield e9ae0d9baa 🐛 Fixed `srcset` and `sizes` attributes being rendered when image resizing unavailable
closes https://github.com/TryGhost/Ghost/issues/11944

- updates `@tryghost/image-transform` to version that exposes `canTransformFiles()` which checks for `sharp` availibility
- updates `@tryghost/kg-default-cards` to version that accepts a `canTransformImage()` method as an option
- updates our `mobiledoc` lib to pass a `canTransformImage()` function that returns false if sharp is unavailable, the image extension is not supported, or the storage engine in use does not support image transforms
- updates `populateImageSizes` to fetch image sizes when transforms are unavailable as the render/not-render is now handled in the renderer and we don't need to worry about adding size information to the mobiledoc source
2020-07-02 18:03:22 +01:00
Nazar Gargol 6902f86b40 Added field mapping support for members import CSVs
no issue

- This is a precursor work allowing client to send csv to JSON
field mapping hash as a `mapping` field parameter in the incoming
request.
2020-07-02 15:18:39 +12:00
Daniel Lockyer f6f22fce7b v3.22.1 2020-07-01 18:38:33 +01:00
Daniel Lockyer 7f7484669e v3.22.0 2020-07-01 10:49:49 +01:00
Daniel Lockyer dc131cfff1 Merged 3.21.1 into master
v3.21.1

* tag '3.21.1':
  v3.21.1
  Updated Ghost-Admin to v3.21.1
  Un-skipped populateImageSizes subdir test
  Fixed unit tests interdependency issue
  Fixed `populateImageSizes` handling of images in subdir setups
  🐛 Fixed potentially squashed images in image cards
  Refactored site url data attribute for new members script
2020-06-29 15:30:42 +01:00
Daniel Lockyer b06d03fce6 v3.21.1 2020-06-29 13:25:33 +01:00
Kevin Ansfield 1694fa3675 🐛 Fixed potentially squashed images in image cards
no issue

- 3.21.0 added `width/height` attributes to `<img>` elements output by image cards which was a potentially breaking change for any sites whose CSS does not expect those attributes, resulting in squashed and distorted images
- updated to `@tryghost/kg-default-cards` which modifies the image card renderer to not output `width/height` attributes
2020-06-29 11:19:45 +01:00
Renovate Bot 51d506469d
Update dependency @sentry/node to v5.18.1 2020-06-26 10:11:12 +00:00
Renovate Bot ea23a8392b Update dependency @sentry/node to v5.18.0 2020-06-25 18:24:14 +01:00
Kevin Ansfield b1924bac1c 🐛 Fixed potentially squashed images in image cards
no issue

- 3.21.0 added `width/height` attributes to `<img>` elements output by image cards which was a potentially breaking change for any sites whose CSS does not expect those attributes, resulting in squashed and distorted images
- updated to `@tryghost/kg-default-cards` which modifies the image card renderer to not output `width/height` attributes
2020-06-23 08:54:58 +01:00
Renovate Bot 2cdc4b5d9a
Update dependency eslint to v7.3.1 2020-06-23 03:29:54 +00:00
Daniel Lockyer 1ebbe4ea54 v3.21.0 2020-06-22 11:33:59 +01:00
Renovate Bot 93433bac37
Update dependency eslint to v7.3.0 2020-06-19 19:29:27 +00:00
Renovate Bot 4b145df42b
Update dependency jwks-rsa to v1.8.1 2020-06-19 12:23:03 +00:00
Kevin Ansfield edd997402b Added `sizes` attribute to in-content `<img>` elements
no issue

- by including `sizes` with media-queries that match typical content widths we can give the browser better hints as to which responsive image size to fetch resulting in more performant pages
- also fixes `srcset` output where "unknown" sizes were used instead of linking to the original image src which was causing 302 redirects and slowing image loading in some cases
2020-06-19 11:41:32 +01:00
Renovate Bot b05527b159
Update dependency @tryghost/magic-link to v0.4.9 2020-06-19 08:00:47 +00:00
Nazar Gargol 93e8ee83d9 Extracted members CSV related code into @tryghost/members-csv package
no issue

- Moves out CSV parsing and serialization related code into separate package as a part of push to modularize Ghost repo.
- Next up is to remove `csv-parser` dependency from this new package
2020-06-19 19:55:47 +12:00
Nazar Gargol 92a4ef5d31 Fixed package version to be exact
no issue

- The convention is to keep versions exact in this repository. The change seems like an overlook and not something done with specific intention
2020-06-19 18:02:13 +12:00
Fabien O'Carroll 4716d13d13 Added API endpoints for disconnecting Stripe
no-issue
pr: https://github.com/TryGhost/Ghost/pull/11930

- Upgraded @tryghost/members-api to 0.23.0

  This version includes a new method hasActiveStripeSubscriptions

- Added /admin/members/hasActiveStripeSubscriptions

  This can be used to determine whether or not we should allow removing
  the stripe keys.

- Added /admin/settings/stripe/connect

  This can be used to delete a Stripe Connect integration, provided
  there are not active subscriptions
2020-06-18 18:42:20 +02:00
Daniel Lockyer 2ea00a8f97 v3.20.3 2020-06-18 16:20:13 +01:00
Daniel Lockyer 996b30d335 v3.20.2 2020-06-18 15:10:11 +01:00
Daniel Lockyer 78bf5d1e21 v3.20.1 2020-06-17 17:13:05 +01:00
Kevin Ansfield 4537ccd329 🐛 Fixed embed/bookmark retrieval for sites that require cookies during redirects
no issue

- known failing case was Medium. Some *.medium.com articles triggered redirects but without cookies being stored/sent across the redirect requests it would cause an infinite redirect loop and we'd abort after 10 redirects
- use `got`'s [cookie support](https://github.com/sindresorhus/got/tree/v9.6.0#cookies) via `tough-cookie` so that we can create bookmark cards for medium.com and other sites with similar problems
2020-06-17 10:03:36 +01:00
Daniel Lockyer 4ca85b7139 v3.20.0 2020-06-16 11:55:57 +01:00
Kevin Ansfield 73e14b4235 🐛 Fixed small images appearing smaller in post content
closes https://github.com/TryGhost/Ghost/issues/11913

- updated `@tryghost/kg-default-cards` with fixed `srcset` behaviour
  - does not output `srcset` unless we know the image's original size
  - does not output `w` values for sizes that are bigger than the original image
2020-06-15 16:24:02 +01:00
Kevin Ansfield 937df2c7ec ️ Added blank alt attributes to images when no alt text is provided
no issue

- screen readers often resort to reading out the filename when alt text is not provided which is not useful. By adding `alt=""` (or just `alt`) to `<img>` elements the image is skipped by screen readers providing a smoother experience
- updated `@tryghost/kg-default-cards` which contains above change for `image` and `gallery` cards
2020-06-15 09:24:15 +01:00
renovate[bot] 85e6b77ca9
Update dependency @tryghost/members-api to v0.22.0 (#11910)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-12 19:06:18 +01:00
Nazar Gargol 589d826afd Added `/members/validate` ednpoint to Admin API
no issue

- This endpoint is meant to be used for validation of imported members
- Main function at the moment is to validate if stripe_customer_id present in the dataset exists in connected Stripe account
2020-06-12 16:34:12 +12:00
Daniel Lockyer 11a686d734 v3.19.2 2020-06-11 19:55:43 +01:00
Renovate Bot 1174dbc588
Update dependency @tryghost/kg-mobiledoc-html-renderer to v3.0.1 2020-06-11 17:20:25 +00:00
Renovate Bot 97a979bc93
Update dependency @tryghost/kg-markdown-html-renderer to v2.0.1 2020-06-11 14:46:23 +00:00
Daniel Lockyer 12d0000e7e v3.19.1 2020-06-11 15:43:03 +01:00
Daniel Lockyer 15f58f7925 Revert "Update dependency moment to v2.26.0"
This reverts commit dfb1f9aeae.
2020-06-11 14:22:39 +01:00
Daniel Lockyer 67fca4e716 Revert "Updated ghost-storage-base dependency"
This reverts commit 13986a797c.
2020-06-11 14:22:39 +01:00
Kevin Ansfield 70b205618f Added responsive-image `srcset` attribute to image and gallery card output
no issue

- adds a set of hardcoded "content image sizes" to the base config
- adjusts `handle-image-sizes` middleware to always allow the hardcoded content image sizes to be genreated
- updates `@tryghost/kg-card-factory` to allow passthrough of options to card renderers
- updates `@tryghost/kg-default-cards` to add `srcset` output for image and gallery cards
2020-06-11 13:28:44 +01:00
Renovate Bot 4a90e8f1ee
Update dependency @tryghost/kg-default-atoms to v2.0.1 2020-06-11 11:13:23 +00:00
Renovate Bot 84d510f059
Update dependency bson-objectid to v1.3.1 2020-06-11 06:21:08 +00:00
Renovate Bot f392883a6d
Update dependency analytics-node to v3.4.0-beta.2 2020-06-10 17:18:23 +00:00
Fabien 'egg' O'Carroll bfc03eb120
Replaced nql-map-key-values with @nexes/nql (#11896)
closes #11008

- Updated @nexes/nql to 0.4.0

  This version exports the mapKeyValues utility function

- Replaced nql-map-key-values with @nexes/nql util fn

  Usage was found using `rg nql-map-key-values` and replaced globally.

- Deleted nql-map-key-values module in shared 

  Now that this module isn't referenced anywhere else, we can remove it,
  relying solely on the util exported by @nexes/nql
2020-06-10 19:17:25 +02:00
Renovate Bot 299c9aaddb
Update dependency @tryghost/members-ssr to v0.8.1 2020-06-10 12:14:51 +00:00
Rish 37b9d934cd Bumped @tryghost/members-api to 0.20.1
refs https://github.com/TryGhost/members.js/issues/38

- Handles stripe checkout session creation error rejection with correct response
2020-06-10 17:42:54 +05:30
Daniel Lockyer 7918653da4 v3.19.0 2020-06-09 10:27:45 +01:00
Nazar Gargol 53abf79869 Removed format-csv module in favor of papaparse
no issue

- The aim was to extract format-csv to become an external dependency. After some analysis found out that native papaparse method `unparse` was achieving the same results with a lot better test coverage and stability. Because papaparse will become Ghost's default csv processor in near future decided to integrate papaparse instead of extracting module for the format-csv module's code, which would become redundant soon anyways.
- For reference papaparse will substitute current csv-parser lib because it's better performance and maturity.
- Performance comparison can be checked here - https://github.com/Keyang/csvbench#result . At the time of writing papaparse is rougly 40% faster than csv-parser
2020-06-09 15:23:15 +12:00
Daniel Lockyer 13986a797c Updated ghost-storage-base dependency
no issue

- ghost-storage-base uses moment which was affected by the moment update
- this commit updates the dependency so they use the same moment version
2020-06-08 19:43:55 +01:00
Renovate Bot dfb1f9aeae Update dependency moment to v2.26.0 2020-06-08 19:43:55 +01:00
Rish bca41e1877 Allowed updating from address domain for member emails
refs https://github.com/TryGhost/Ghost/issues/11414

Confirms if the fromAddress for sending member emails is valid and accessible using magic link flow, allowing owners to update full from address including domain change.

- Extends member service to handle magic link generation and validation for email update
- Updates existing setting endpoint to not directly update from address
- Adds new endpoint to send magic link to new address
- Adds new endpoint for validating the magic link when clicked and update the new email for from address
- Adds new email template for from address update email
2020-06-09 00:06:07 +05:30
Renovate Bot 867e0306b9
Update dependency @tryghost/kg-default-cards to v2.0.2 2020-06-08 16:31:07 +00:00
Renovate Bot a97996eec1 Update dependency @sentry/node to v5.17.0 2020-06-08 16:06:33 +01:00
renovate[bot] 1d49cba426
Update dependency @tryghost/kg-mobiledoc-html-renderer to v3 (#11887)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-08 10:47:17 +01:00
Kevin Ansfield e1fd8cc11f 🐛 Fixed original url/query params not being used in bookmark cards
refs https://github.com/TryGhost/Ghost/issues/11212
credit @devaman https://github.com/TryGhost/Ghost/pull/11542

- use `payload.url` for the `href` which is the originally entered url rather than `payload.metadata.url` which is the final url after redirects and metascraper extraction
- retains query params and redirects which are useful for things like affiliate links
2020-06-08 09:04:14 +01:00
renovate[bot] 31d0966e2d
Update dependency @tryghost/kg-markdown-html-renderer to v2 (#11886)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-08 08:17:30 +01:00
renovate[bot] 90a19ee397
Update dependency @tryghost/kg-default-atoms to v2 (#11884)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-08 08:17:16 +01:00
Kevin Ansfield d8773dcc45 Allowed bookmark cards to be created without a description
no issue

- title+description was too limiting for some sites so we're relaxing the requirements to only require a title
2020-06-08 07:55:38 +01:00
Renovate Bot b92f976a6a
Update dependency eslint to v7.2.0 2020-06-08 00:58:20 +00:00
Renovate Bot e9b812e4f0
Update dependency csv-parser to v2.3.3 2020-06-05 13:28:20 +00:00
Renovate Bot 80fa891965 Update dependency sanitize-html to v1.26.0 2020-06-05 09:59:48 +01:00
Kevin Ansfield ff83cd0d97 🐛 Fixed location not being recorded for paid member signups
no issue

- updates `@tryghost/members-{api/ssr}` packages that move geolocation into the token->session exchange step so that the member's IP address is always available for rough geolocation
2020-06-04 13:32:09 +01:00
Renovate Bot 5dcd856088
Update dependency fs-extra to v9.0.1 2020-06-04 00:26:05 +00:00
Renovate Bot 66026c57e9
Update dependency @sentry/node to v5.16.1 2020-06-03 16:59:57 +00:00
Daniel Lockyer 3757cd936b v3.18.1 2020-06-02 18:07:38 +01:00
Daniel Lockyer 0f6e23668c v3.18.0 2020-06-02 15:22:02 +01:00
Renovate Bot 7fe945f4dd
Update dependency @lodder/grunt-postcss to v2.0.4 2020-06-02 11:19:41 +00:00
Renovate Bot a16e4cc5d1 Update dependency @sentry/node to v5.16.0 2020-06-02 12:18:42 +01:00