McSinyx
/
pip
mirror of https://github.com/pypa/pip
1
1
Fork 0
Code Issues Releases Activity

Merge pull request #9372 from jdufresne/devnull 

Prefer subprocess.DEVNULL over open(os.devnull, 'w')
This commit is contained in:
Xavier Fernandez 2021-01-07 11:58:08 +01:00 committed by GitHub
parent c7419b2aac 50517b2171
commit 14830ae837
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
news/30e2240e-e268-4519-bee7-6f79bc4cf489.trivial.rst Normal file
View File

15
tests/lib/local_repos.py
View File

@ -22,15 +22,12 @@ def _create_svn_initools_repo(initools_dir):
'http://bitbucket.org/hltbra/pip-initools-dump/raw/8b55c908a320/' 'http://bitbucket.org/hltbra/pip-initools-dump/raw/8b55c908a320/'
'INITools_modified.dump' 'INITools_modified.dump'
) )
devnull = open(os.devnull, 'w') with open(filename) as dump:
dump = open(filename) subprocess.check_call(
subprocess.check_call( ['svnadmin', 'load', initools_dir],
['svnadmin', 'load', initools_dir], stdin=dump,
stdin=dump, stdout=subprocess.DEVNULL,
stdout=devnull, )
)
dump.close()
devnull.close()
os.remove(filename) os.remove(filename)