Commit Graph

9428 Commits

Author SHA1 Message Date
Pradyun Gedam 8cca170ceb
Merge pull request #7976 from uranusjr/installed-candidate-equal
New Resolver: Implement equality on candidate classes
2020-04-10 18:57:56 +05:30
Pradyun Gedam 9cbe8fbdd0
Merge pull request #7978 from sbidoul/remove-pip-egg-info-sbi
Generate legacy metadata in temporary directory
2020-04-10 18:57:13 +05:30
Pradyun Gedam 81f1054865
Merge pull request #7873 from hroncok/no_copy_self
Prevent infinite recursion with pip wheel with $TMPDIR in $PWD
2020-04-10 18:56:31 +05:30
Paul Moore 6c97645e2f
Merge pull request #8000 from uranusjr/new-resolver-normal-test-progress
New Resolver: Make sure candidates are prepared after resolution
2020-04-10 11:56:56 +01:00
Pradyun Gedam 9360793a6c
Merge pull request #7987 from deveshks/add-tests-for-pip-cmds-ignoring-cwd
Add unit tests for pip commands not using cwd
2020-04-10 14:29:06 +05:30
Paul Moore c7bde5bf88
Merge pull request #7990 from uranusjr/resolver-installed-2
New Resolver: Correctly uninstall existing distribution before installing
2020-04-09 20:58:17 +01:00
Paul Moore d49b4dab8f
Merge pull request #8006 from uranusjr/fix-dist-name-parse
Remove the version part from the dist-info directory name
2020-04-09 17:14:15 +01:00
Tzu-ping Chung d5e45bb59a Remove the version part from the dist-info stem 2020-04-09 20:28:28 +08:00
Pradyun Gedam c5da021142
Merge pull request #7959 from hrnciar/remove-shebang-from-nonexecutable-script
Remove shebang from nonexecutable script
2020-04-09 17:26:34 +05:30
Pradyun Gedam c8e4afac57
Merge pull request #7977 from deveshks/add-mypy-annotations-commands
Added type annotations to pip._internal.commands.check
2020-04-09 17:15:59 +05:30
Pradyun Gedam ea1295b720
Merge pull request #7965 from deveshks/warn-on-invalid-index-url
Warn if an invalid URL is passed with --index-url
2020-04-09 17:15:47 +05:30
Xavier Fernandez ea9cb06c49
Merge pull request #7988 from McSinyx/tabulate
Fix tabulate col size in case of empty cell
2020-04-09 13:35:16 +02:00
Tomas Hrnciar b438d47344 Remove shebang from nonexecutable script
When packaging pip in Fedora, we have realised
that there is a nonexecutable file with a shebang line.

It seems that the primary purpose of this file is to be imported from Python
code and hence the shebang appears to be unnecessary.

Shebangs are hard to handle when doing downstream packaging because it makes
sense for upstream to use `#!/usr/bin/env python` while in the RPM package, we
need to avoid that and use a more specific interpreter. Since the shebang was
unused, I propose to remove it to avoid the problems.

We have found more shebangs but in vendored packages. I have also opened PRs there:
https://github.com/ActiveState/appdirs/pull/144
https://github.com/psf/requests/pull/5410
https://github.com/chardet/chardet/pull/192

x
2020-04-09 11:53:21 +02:00
Pradyun Gedam c110953703
Merge pull request #7958 from ilanschnell/add-yaml-options
Add ability to run pip with options for yaml tests
2020-04-09 10:20:37 +05:30
Tzu-ping Chung 56e065f956 Move dist preparation to its own method 2020-04-09 02:27:37 +08:00
Tzu-ping Chung a7d17f8da6 Make sure candidates are prepared after resolution 2020-04-08 23:38:10 +08:00
Tzu-ping Chung be60eaaa4f Uninstall existing dist before reinstallation 2020-04-08 17:17:25 +08:00
Tzu-ping Chung 90ce7c9edd Refactor to prepare for upgrade procedures 2020-04-08 17:17:25 +08:00
Tzu-ping Chung e714b5cf84 Add failing tests for reinstall and upgrade 2020-04-08 17:16:47 +08:00
Tzu-ping Chung 591d476fca Note on why we don't implement equality 2020-04-08 16:38:47 +08:00
Tzu-ping Chung 018c051a8e Implement equality on candidate classes 2020-04-08 16:38:47 +08:00
Xavier Fernandez 327a31536f
Merge pull request #7729 from cosmicexplorer/cache-parse-links
Cache parse_links() by --find-links html page url
2020-04-08 10:33:24 +02:00
Devesh Kumar Singh fe6920bc2f Addressed review comments 2020-04-08 13:59:33 +05:30
Paul Moore bd912cf0de
Merge pull request #7993 from uranusjr/new-resolver-normal-test-progress
Canonicalise project name from InstallationCandidate
2020-04-08 09:12:50 +01:00
Danny McClanahan 6e7b16cec4
add failing test ; apply the fix ; add template NEWS entry
add failing test

apply the fix

add template NEWS entry according to https://pip.pypa.io/en/latest/development/contributing/#news-entries (wrong PR #)

rename news entry to the current PR #

respond to review comments

fix test failures

fix tests by adding uuid salt in urls

cache html page fetching by link

make CI pass (?)

make the types much better

finally listen to the maintainer and cache parse_links() by url :)

avoid caching parse_links() when the url is an index url

cleanup

add testing for uncachable marking

only conditionally vendor _lru_cache for py2

bugfix => feature

python 2 does not cache!

Do away with type: ignore with getattr()

respond to review comments
2020-04-07 12:01:43 -07:00
Stéphane Bidoul 030578ef04
Remove unused argument from generate_metadata 2020-04-07 17:01:08 +02:00
Stéphane Bidoul 34adf0a258
Simplify make_setuptools_egg_info_args 2020-04-07 17:01:08 +02:00
Stéphane Bidoul da2ab6b829
Simplify legacy metadata generation
Always generate legacy metadata in a
temporary directory, even in the editable
case. Generating it in the source directory
did not add value, because setup.py develop
always regenerates the .egg-info directory.
2020-04-07 17:01:08 +02:00
Paul Moore 451f5d9f37
Merge pull request #7994 from uranusjr/new-resolver-model-repr
Add __repr__ to requirement/candidate models
2020-04-07 14:42:47 +01:00
Tzu-ping Chung 6d40804b12 Add __repr__ to requirement/candidate models 2020-04-07 20:53:25 +08:00
Tzu-ping Chung b89e1c2fb4 Canonicalize InstallationCandidate name
Caught by test_single_download_from_requirements_file etc.
2020-04-07 19:05:26 +08:00
Tzu-ping Chung 2f36ac7587 Add assertion message for easier debugging 2020-04-07 19:02:17 +08:00
Nguyễn Gia Phong 26b76f6f11 Move tabulate to utils.misc and test it 2020-04-07 17:35:47 +07:00
Devesh Kumar Singh efd6dd28d0 Address review comments 2020-04-07 09:44:36 +05:30
Devesh Kumar Singh a73ad91c8b Running test_check for pkg_path 2020-04-07 09:06:13 +05:30
Devesh Kumar Singh ac65f136fd Add tests to verify --index-url behaviour 2020-04-06 20:19:11 +05:30
Paul Moore 2b3d0a5cc0
Merge pull request #7983 from uranusjr/install-req-editable-type-fix
Accept InstallRequirement as comes_from
2020-04-06 14:48:26 +01:00
Nguyễn Gia Phong c2aa573107 Fix tabulate col size in case of empty cell
Previously, the size is no less than len(str(None)) == 4.
This commit also add type hint and docstring to the function.
2020-04-06 17:56:49 +07:00
Devesh Kumar Singh 4c70c6d350 Warn if an invalid URL is passed with --index-url 2020-04-06 10:57:50 +05:30
Devesh Kumar Singh 84baf2110f Fixed issue in test_freeze for failing test 2020-04-06 01:26:33 +05:30
Devesh Kumar Singh 29b4ec79ed Fixed issue in test_show for failing test 2020-04-06 00:27:30 +05:30
Devesh Kumar Singh 2324ae422e Add unit tests for pip commands not using cwd 2020-04-05 23:17:03 +05:30
Pradyun Gedam eb865b4e10
Merge pull request #7955 from deveshks/pip-list-not-contain-pkg-work-dir
Don't list packages in current directory
2020-04-05 21:13:14 +05:30
Devesh Kumar Singh feac595446 Don't use cwd in python -m pip command 2020-04-05 19:59:05 +05:30
Stéphane Bidoul bf8e6bc785
Generate legacy metadata in temporary directory
Before it was generated in a pip-egg-info
subdirectory of the source dir. This will avoid
polluting source dir when we build in place.
2020-04-05 11:23:57 +02:00
Ilan Schnell 2b883d5d8a add ability to test uninstall - and simple uninstall test 2020-04-05 00:05:43 -05:00
Tzu-ping Chung 74c5042052 Accept InsatllRequirement as comes_from 2020-04-05 12:17:25 +08:00
Paul Moore d9b3a7cc32
Merge pull request #7979 from uranusjr/editable
Implement editable candidate
2020-04-04 23:22:55 +01:00
Devesh Kumar Singh c2fdf4a35b Add mypy annotations to pip._internal.commands.check 2020-04-05 01:56:05 +05:30
Ilan Schnell 0c3bc448e1 always check for files in site-packages - add simple test for installing twice 2020-04-04 14:33:28 -05:00