Matthew Chen
dcf7a05986
Use default avatars for contact shares in contact view.
2018-05-04 13:21:53 -04:00
Matthew Chen
66989b8db7
Use default avatars for contact shares in conversation view.
2018-05-04 13:21:53 -04:00
Matthew Chen
459101c20e
Add feature flag for contact sharing.
2018-05-04 09:35:47 -04:00
Matthew Chen
ff6b45abee
Respond to CR.
2018-05-03 14:31:11 -04:00
Matthew Chen
91d54360ba
Add contact view.
2018-05-03 14:09:54 -04:00
Matthew Chen
2738bcbc58
Create contact view.
2018-05-03 14:09:54 -04:00
Michael Kirk
e604437e24
Don't become first responder while presenting
...
// FREEBIE
2018-05-03 12:45:48 -04:00
Michael Kirk
5c0c01dea2
Contact picking
...
// FREEBIE
2018-05-02 11:06:09 -04:00
Matthew Chen
411d5a3b4f
Respond to CR.
2018-05-02 11:01:23 -04:00
Matthew Chen
783bf5b81c
Clean up ahead of PR.
2018-05-02 10:52:29 -04:00
Matthew Chen
708b44e3c5
Improve handling of contact display names.
2018-05-02 10:52:29 -04:00
Matthew Chen
7e35a7e7d7
Sketch out rendering of contact shares in conversation view.
2018-05-02 10:51:59 -04:00
Matthew Chen
2e06ebfe19
Fix system cell layout.
2018-04-30 10:57:12 -04:00
Matthew Chen
45be54f7ac
Design polish for the "profile pic in conversation view" and "archived conversations in home view."
2018-04-26 11:50:33 -04:00
Michael Kirk
b702695793
cleanup
2018-04-26 11:18:18 -04:00
Michael Kirk
55e19b55b3
Fix layout for iOS9/10
...
code cleanup
// FREEBIE
2018-04-26 11:18:18 -04:00
Michael Kirk
7a1d24a9ab
Avatar updates when contact/profile/group photo changes
...
// FREEBIE
2018-04-26 11:18:18 -04:00
Michael Kirk
b1bff71145
WIP moving to stackview backed header view in conversation view
...
- iOS10 with large titles doesn't truncate
2018-04-26 11:18:18 -04:00
Matthew Chen
fb0c47aa12
Fix dynamic type issues.
2018-04-25 15:12:52 -04:00
Matthew Chen
204d379603
Respond to CR.
2018-04-25 10:49:19 -04:00
Matthew Chen
40ac0daa9a
Respond to CR.
2018-04-25 10:49:19 -04:00
Matthew Chen
9275c67818
Rework outgoing message state.
2018-04-25 10:49:19 -04:00
Matthew Chen
fa9a4c808a
Simplify usage of contacts framework.
2018-04-24 13:21:12 -04:00
Michael Kirk
9c81eb44a1
Replace remaining UI usage of interaction.description
...
// FREEBIE
2018-04-21 19:21:18 -04:00
Michael Kirk
b039fdd276
UI Fix: start with full hourglass on short timer durations
...
We were positioning relative to "blink" time (2s), rather than delete
time, which means that for 10s timers we were starting as though only 8s
remained.
// FREEBIE
2018-04-18 15:32:01 -04:00
Matthew Chen
a1386eca81
Fix taps in message cells.
2018-04-17 13:28:06 -04:00
Matthew Chen
284cc8c265
Apply attachment type assets.
2018-04-16 16:12:16 -04:00
Matthew Chen
146db1984b
Apply attachment type assets.
2018-04-16 16:12:16 -04:00
Michael Kirk
64ff4cd660
tap-to-retry failed thumbnail downloads
...
// FREEBIE
2018-04-16 16:06:18 -04:00
Matthew Chen
f6d5b9197c
Respond to CR.
2018-04-16 12:39:11 -04:00
Matthew Chen
bb9c1fb23d
Apply design changes from Myles.
2018-04-16 12:36:30 -04:00
Matthew Chen
6a69070ce9
Apply design changes from Myles.
2018-04-16 12:36:30 -04:00
Matthew Chen
6831412e44
Respond to CR.
2018-04-16 12:14:09 -04:00
Matthew Chen
a5c7bdb987
Don't animate changes to shape layer properties.
2018-04-16 12:08:57 -04:00
Matthew Chen
59a3d736bf
Respond to CR.
2018-04-13 15:10:16 -04:00
Matthew Chen
d7ae35f72c
Streamline usage of quoted message view.
2018-04-13 15:03:51 -04:00
Matthew Chen
195d357370
Streamline usage of quoted message view.
2018-04-13 15:03:51 -04:00
Matthew Chen
9c93099515
Fix incomplete asserts.
2018-04-13 15:01:25 -04:00
Matthew Chen
6caa5b87b6
Add more asserts around thread in SAE.
2018-04-13 14:59:38 -04:00
Matthew Chen
644e78f19d
Respond to CR.
2018-04-13 14:32:42 -04:00
Michael Kirk
e554884ab3
Use profile name in quoted messages, fix "multi account" label
...
// FREEBIE
2018-04-13 09:53:31 -04:00
Michael Kirk
40879ca3e3
Distinguish between quoting yourself and someone else quoting you
...
// FREEBIE
2018-04-11 19:21:38 -04:00
Michael Kirk
5774e5769d
truncate tail for both preview and message bubble
...
// FREEBIE
2018-04-11 15:26:09 -04:00
Matthew Chen
576f5dee88
Add white background to images in quoted reply view.
2018-04-11 14:53:59 -04:00
Matthew Chen
fc2704cf88
Label quoted replies to yourself as such.
2018-04-11 14:40:18 -04:00
Matthew Chen
759b2a332f
Respond to CR.
2018-04-11 14:18:09 -04:00
Matthew Chen
ea82419a40
Fix long press on quoted reply.
2018-04-11 14:02:07 -04:00
Matthew Chen
031a1d7325
Fix quoted message overflow.
2018-04-11 13:57:17 -04:00
Matthew Chen
ae91b03c71
Add white background to images in conversation view.
2018-04-11 13:45:12 -04:00
Michael Kirk
5320536736
remove WIP comments
...
// FREEBIE
2018-04-11 11:55:30 -04:00
Michael Kirk
7abd51838f
Move bubble actions to new bubble delegate
...
// FREEBIE
2018-04-11 11:55:30 -04:00
Matthew Chen
f6698501df
Revert "Label quoted replies to yourself as such."
...
This reverts commit 24d7492f61
.
2018-04-11 11:48:08 -04:00
Matthew Chen
24d7492f61
Label quoted replies to yourself as such.
2018-04-11 11:47:33 -04:00
Matthew Chen
abba24988c
Rework how dates are formatted in home view.
2018-04-11 09:34:37 -04:00
Michael Kirk
6b6f4f9336
Limit caption length
...
// FREEBIE
2018-04-10 16:00:19 -04:00
Matthew Chen
9769d482da
Respond to CR.
2018-04-10 15:56:56 -04:00
Matthew Chen
76995e4594
Enforce quoted reply edge cases.
2018-04-10 15:56:55 -04:00
Matthew Chen
f2b416d800
Respond to CR.
2018-04-10 15:54:46 -04:00
Matthew Chen
8b060a187c
Tap on quoted replies.
2018-04-10 15:54:46 -04:00
Matthew Chen
65015e686f
Tap on quoted replies.
2018-04-10 15:54:46 -04:00
Matthew Chen
e8ad6bad87
Respond to CR.
2018-04-10 10:53:29 -04:00
Matthew Chen
ebb89ed1fd
Tweak message layout.
2018-04-10 10:52:08 -04:00
Michael Kirk
520dad25bb
WIP making OWSQuotedMessageView work with preview
...
// FREEBIE
2018-04-10 10:06:18 -04:00
Michael Kirk
5287ab8f8c
Try 2: no more stack view
...
// FREEBIE
2018-04-10 10:06:18 -04:00
Matthew Chen
8fe289feec
Tweak design of quoted replies.
2018-04-09 16:45:42 -04:00
Matthew Chen
3799dce822
Respond to CR.
2018-04-09 14:32:10 -04:00
Matthew Chen
c106a67a52
Use dynamic type everywhere in conversation view.
2018-04-09 14:25:53 -04:00
Matthew Chen
ade2ee7216
Use dynamic type everywhere in conversation view.
2018-04-09 14:25:53 -04:00
Michael Kirk
941b7ec1bc
clarify method signature
...
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
c56e8acc51
QuotedReplyModel from SSK->SignalMessaging
...
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
1d4c0624be
Clarify variable names
...
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
a9459757f0
Lingering var renames QuotedReplyDraft -> QuotedReplyModel
...
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
fa2e1ba89b
Fetch thumbnail when not available locally
...
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
cb5d3d4f85
Use QuotedReplyModel to access attachment data
...
This view model loads the attachment when it's build.
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
55c6d99d98
populate draft toolbar
...
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
253435b27f
extract QuotedReplyDraft model
2018-04-09 12:47:56 -04:00
Michael Kirk
0b8b3b4f16
WIP: towards avatar attachment streams
...
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
53af41fcc6
Reusable UploadOperation based on extracted OWSOperation
...
// FREEBIE
2018-04-09 12:47:56 -04:00
Matthew Chen
0dfdb8ce88
Elaborate quoted reply variations to include replies with attachments.
2018-04-06 16:47:21 -04:00
Matthew Chen
de2dc49126
Elaborate quoted reply variations to include replies with attachments.
2018-04-06 16:47:21 -04:00
Matthew Chen
3ee37bd3f0
Respond to CR.
2018-04-06 16:46:36 -04:00
Matthew Chen
2f2d1f81a8
Clean up ahead of PR.
2018-04-06 12:45:16 -04:00
Matthew Chen
6830d4e8cb
Apply message bubble view to message details view.
2018-04-06 12:35:46 -04:00
Matthew Chen
d99a2be005
Apply message bubble view to message details view.
2018-04-06 12:35:46 -04:00
Matthew Chen
316b55bf9d
Respond to CR.
2018-04-06 12:34:50 -04:00
Matthew Chen
7067085cdd
Extract message bubble view.
2018-04-06 12:32:09 -04:00
Matthew Chen
d05b73af28
Extract message bubble view.
2018-04-06 12:32:09 -04:00
Matthew Chen
d1060a2a85
Extract message bubble view.
2018-04-06 12:32:09 -04:00
Matthew Chen
7f0fa1228e
Extract message bubble view.
2018-04-06 12:32:09 -04:00
Matthew Chen
c5d8a7cb38
Clean up ahead of PR.
2018-04-05 11:15:00 -04:00
Matthew Chen
f6aa3f89b7
Clean up ahead of PR.
2018-04-05 10:58:55 -04:00
Matthew Chen
ca4757b8d1
Clean up ahead of PR.
2018-04-05 10:57:51 -04:00
Matthew Chen
71c5c3a4b7
Refine appearance of quoted reply message cells.
2018-04-05 10:39:07 -04:00
Matthew Chen
8a843f70e3
Refine the attachments in the quoted reply view.
2018-04-05 10:38:34 -04:00
Matthew Chen
822aa64b14
Respond to CR.
2018-04-05 10:35:57 -04:00
Matthew Chen
cac85508cc
Refine appearance of quoted reply message cells.
2018-04-05 10:24:42 -04:00
Matthew Chen
7e921b7935
Refine appearance of quoted reply message cells.
2018-04-05 10:24:42 -04:00
Matthew Chen
08ba3852cd
Refine appearance of quoted reply message cells.
2018-04-05 10:24:42 -04:00
Matthew Chen
5235f6eee9
Refine appearance of quoted reply message cells.
2018-04-05 10:24:42 -04:00
Matthew Chen
d6f3df82ae
Refine appearance of quoted reply message cells.
2018-04-05 10:24:42 -04:00
Matthew Chen
c70f911f6f
Refine appearance of quoted reply message cells.
2018-04-05 10:24:42 -04:00
Matthew Chen
6171505657
Refine appearance of quoted reply message cells.
2018-04-05 10:24:42 -04:00
Matthew Chen
10b4ade55a
Refine appearance of quoted reply message cells.
2018-04-05 10:24:42 -04:00
Matthew Chen
3343b4ec58
Refine appearance of quoted reply message cells.
2018-04-05 10:24:42 -04:00
Matthew Chen
9085609087
Fix interaction initializers and tests.
2018-04-05 09:36:52 -04:00
Michael Kirk
51eee90bb7
Remove unnecessary changes
...
// FREEBIE
2018-04-04 10:59:05 -04:00
Michael Kirk
bf401bad90
Send quoted messages
...
MVP
- [x] populate from menu
- [x] send quoted message
TODO
- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit
NICE TO HAVE
- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments
// FREEBIE
2018-04-04 10:59:04 -04:00
Michael Kirk
d99054d895
Reply menu item
...
MVP
- [x] populate from menu
- [] send quoted message
TODO
- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit
NICE TO HAVE
- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments
// FREEBIE
2018-04-04 10:59:04 -04:00
Michael Kirk
6874a9e28e
Convert to swift
...
// FREEBIE
2018-04-04 10:59:04 -04:00
Michael Kirk
cfbbeca7ac
WIP: QuotedMessagePreviewView
...
MVP
- [] populate from menu
- [] send quoted message
TODO
- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit
NICE TO HAVE
- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments
// FREEBIE
2018-04-04 10:59:03 -04:00
Matthew Chen
00a81355d6
Respond to CR.
2018-04-04 10:27:30 -04:00
Matthew Chen
324afb1152
Modify cells to show quoted messages.
2018-04-04 10:12:07 -04:00
Matthew Chen
5824cbd2a8
Modify cells to show quoted messages.
2018-04-04 10:12:07 -04:00
Matthew Chen
988b6ffae7
Modify cells to show quoted messages.
2018-04-04 10:12:07 -04:00
Matthew Chen
f6f98369a6
Modify cells to show quoted messages.
2018-04-04 10:12:07 -04:00
Matthew Chen
22dc904283
Modify cells to show quoted messages.
2018-04-04 10:12:07 -04:00
Matthew Chen
2278cdd589
Modify cells to show quoted messages.
2018-04-04 10:12:07 -04:00
Matthew Chen
7cf169012c
Elaborate conversation view items around quoted replies.
2018-04-04 10:12:07 -04:00
Matthew Chen
c36297a9ad
Elaborate 'quoted reply' variations in the Debug UI.
2018-04-03 13:42:21 -04:00
Matthew Chen
d5218cf4d9
Simplify bubble edge.
2018-04-03 13:40:29 -04:00
Michael Kirk
00e5e1b0d6
Fixup some tests
...
// FREEBIE
2018-04-03 11:29:05 -04:00
Michael Kirk
f441c6211d
Format
...
// FREEBIE
2018-04-02 17:02:32 -04:00
Michael Kirk
6f1608f44b
Conventional naming for out custom PureLayout methods.
...
This moves methods more in line with PureLayout conventions.
- Methods always specify if they pin to an edge vs margin
- `margin` is a reserved word which should only refer to layout margins.
i.e. do not use it to refer to "inset" and "offset".
// FREEBIE
2018-04-02 17:02:32 -04:00
Matthew Chen
4240b517d0
Respond to CR.
2018-04-02 16:17:46 -04:00
Matthew Chen
fb1f3b5572
Rework quoted reply debug UI.
2018-04-02 16:17:46 -04:00
Matthew Chen
4915c127cb
Rework quoted reply debug UI.
2018-04-02 16:17:46 -04:00
Matthew Chen
8e4f2ca0ed
Rework proto schema changes for quoted replies.
...
Sketch out model changes for quoted replies.
Sketch out quoted reply input preview.
Send quoted messages protos.
Update models to reflect quoted messages.
Rework interaction initializers.
Rework interaction initializers.
Add debug UI methods for generating quoted reply variations.
Add debug UI methods for generating quoted reply variations.
2018-04-02 16:17:46 -04:00
Matthew Chen
1bea832faa
Fix assert in bubble views.
2018-04-02 15:59:30 -04:00
Matthew Chen
f98c45603c
Respond to CR.
2018-04-02 11:13:11 -04:00
Matthew Chen
12bcf887c1
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
4f9085a761
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
3ca2c08b06
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
578f40d791
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
c8012d3891
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
3d07dc7c5b
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
8d74c68f9d
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
8a74e10208
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
e0e8eafb5d
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
e1e6606783
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
cb00b22870
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
6525ccdb05
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
75177ef00f
Bubble collapse.
2018-04-02 10:07:15 -04:00
Matthew Chen
3a5ba15d21
Elaborate debug UI for messages.
2018-04-02 10:07:15 -04:00
Matthew Chen
c2e31540d7
Elaborate debug UI for messages.
2018-04-02 10:06:45 -04:00
Michael Kirk
394cc6637c
Backport comments from translations
...
// FREEBIE
2018-03-26 10:12:04 -04:00
Michael Kirk
6c877403cf
Fix delete from message details
...
// FREEBIE
2018-03-22 19:54:19 -04:00
Michael Kirk
00b5316976
Don't show the "All Media" button when viewing the slider from the
...
gallery via settings.
In this context it makes more sense for the user to hit the "dismiss"
button to get "back" to "All Media"
// FREEBIE
2018-03-20 11:12:11 -04:00
Michael Kirk
ae8dbeb8dd
Access Media Gallery from conversation settings
...
// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk
dfd628250d
Gallery performance
...
- [x] share uiDatabaseConnection to share cache
- [x] increase cache size
- [x] load less initially
- [x] lazy loading
- [x] slider view
- [x] tile view
// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk
985af76d0b
WIP: All Media view
...
TODO
- [ ] label video/gif
- [ ] reasonable load perf
- [ ] reasonable scroll perf
- [ ] select / delete
- [ ] cancel share action from media details returns signal style
NICE TO HAVE
- [ ] fancy in/out animation from All Media <-> tiles
- [ ] label video thumbnail with duration stamp
- [ ] Other perf?
- [ ] dbModified?
- [ ] select / send
- [ ] darken section header a shade once it's "active"
DONE
- [x] tap to refocus on new media
- [x] generate test data
- [x] section headers
- [x] equal spacing around cells
// FREEBIE
WIP WIP extract datasouce to GalleryViewController
- [x] swipe through is broken
- [x] present animation
- [x] dismiss animation
// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk
4ac9a1019b
Media page view controller
...
First pass at a swipe-through media view for conversations.
Future work could include
- title label per item
- sender name
- date/time
- photo rail
- include caption
// FREEBIE
2018-03-16 15:55:34 -04:00
Michael Kirk
88e1386720
Move frame to presentation logic, out of init
...
This no longer made sense now that we're using this in a
PageViewController we won't always be zooming from a particular frame.
TODO:
- why is background image all wonky?
- why aren't views created by the time it's presented? Is that a
regression? (how is self.view a MenuView if loadView hasn't been called)
// FREEBIE
2018-03-14 12:50:27 -04:00
Matthew Chen
b296cfb893
Sketch out incremental backup manager and settings view.
2018-03-12 16:40:07 -03:00
Michael Kirk
a1de99f1f1
Merge tag '2.21.0.9'
2018-03-06 16:43:33 -05:00
Matthew Chen
d6f4db1523
Rename TSStorageManager to OWSPrimaryStorage.
2018-03-06 17:12:13 -03:00
Michael Kirk
d7fcac8a5a
In-App notifications don't pause background audio
...
// FREEBIE
2018-03-05 17:59:09 -05:00
Michael Kirk
07ee3ea843
Merge tag '2.21.0.5'
2018-03-05 09:54:06 -05:00
Michael Kirk
6077367e66
Notification sounds should respect silent switch
...
// FREEBIE
2018-03-03 11:33:31 -05:00
Matthew Chen
baf6fcc535
Add 2FA registration view.
2018-03-02 10:55:00 -05:00
Matthew Chen
e12a1e984a
Work on two-factor auth settings UI.
2018-03-01 15:38:59 -05:00
Matthew Chen
38ff82ab97
Rebrand OWSAudioPlayer.
2018-02-26 14:47:57 -05:00
Matthew Chen
99aedca45f
Strip out special casing for pre-iOS 9 users.
2018-02-26 14:13:38 -05:00
Matthew Chen
81629a87df
Fix build break.
2018-02-22 13:31:41 -05:00
Matthew Chen
152c570900
Respond to CR.
2018-02-22 12:07:11 -05:00
Matthew Chen
03670b4868
Rename the view horizon.
2018-02-22 11:46:08 -05:00
Matthew Chen
fabbe46114
Clean up ahead of PR.
2018-02-22 11:46:08 -05:00
Matthew Chen
4e1e232825
Flush writes from other processes.
2018-02-22 11:46:08 -05:00
Matthew Chen
1ff4f85247
Improve handling of db modifications while conversation view is not observing.
2018-02-22 11:46:08 -05:00
Matthew Chen
2ac7716771
Improve handling of db modifications while conversation view is not observing.
2018-02-22 11:46:08 -05:00
Michael Kirk
5ba5d3f524
Remove "Share" from edit menu
...
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.
Specifically:
- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
share extension (could be the Signal share extension or another app's
share extension)
- the conversation view (which is rendered behind the share extension)
regains first responder, causing the input toolbar to appear above the
share extension
One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.
// FREEBIE
2018-02-22 08:57:58 -05:00
Michael Kirk
d7f8c3e9d3
Ensure inputAccessory doesn't obscure the SN alert
...
This affects iOS 8, 9, and to a lesser degree iOS10.
On iOS11, presenting an alert causes the keyboard/inputAccessoryView to
temporarily dismiss.
// FREEBIE
2018-02-21 16:35:46 -05:00
Michael Kirk
abb51b565a
Don't de-activate audio sesion when other audio activities are happening
...
// FREEBIE
2018-02-16 14:00:15 -08:00
Matthew Chen
ceaf028445
Always scroll to bottom after sending attachments.
2018-02-16 14:06:46 -05:00
Matthew Chen
e3776015bb
Respond to CR.
2018-02-13 10:49:54 -05:00
Matthew Chen
246a56e925
Respond to CR.
2018-02-13 10:49:54 -05:00
Matthew Chen
33686594e9
Tweak debug logging.
2018-02-13 10:49:54 -05:00
Matthew Chen
ba42ac73d8
Revisit TODOs in the SAE work.
2018-02-12 22:33:26 -05:00
Matthew Chen
bd0f601792
Respond to CR.
2018-02-09 10:31:29 -05:00
Matthew Chen
43765ef3b5
Respond to CR.
2018-02-09 10:31:29 -05:00
Matthew Chen
bbd689bfd0
Add protocol context to protocol kit.
2018-02-09 10:31:29 -05:00
Matthew Chen
d3e16583eb
Add protocol context to protocol kit.
2018-02-09 10:31:29 -05:00
Michael Kirk
c646f76335
Garther audio concerns, clean up session when done
...
- sync speakerphone state manipulated from system call screen
- Revert audio session after call failure, ensures media plays out of
speaker after placing a failing call.
- Replace notification with delegate pattern since we're already using
delegate pattern here.
- Fixes voiceover accessibility after voice memo
- Avoid audio blip after pressing hangup
- Rename CallAudioSession -> OWSAudioSession
Going to start using it for other non-call things since we want to
gather all our audio session concerns.
- Resume background audio when done playing video
- Extract OWSVideoPlayer which ensures audio is in proper state before
playback
- Move recording session logic to shared OWSAudioSession
- Deactivate audio session when complete
// FREEBIE
2018-02-06 18:45:51 -08:00
Michael Kirk
7734958eec
Make "swipe for info" RTL compatible
...
// FREEBIE
2018-02-02 11:18:12 -08:00
Michael Kirk
54f7c298b7
Only initiate "show details" pan gesture when swiping back
...
// FREEBIE
2018-02-02 11:18:12 -08:00
Michael Kirk
e39ca59eeb
Merge tag '2.19.5.0'
2018-02-01 14:03:43 -08:00
Matthew Chen
fa76e524c4
Respond to CR.
2018-01-30 10:15:15 -05:00
Matthew Chen
9c84bdb105
Add support for images as documents.
2018-01-30 10:12:08 -05:00
Matthew Chen
3609275c20
Handle malformed row updates.
2018-01-30 10:06:46 -05:00
Matthew Chen
069587b150
Add message approval view.
2018-01-25 13:27:16 -05:00
Matthew Chen
992e926142
Unpack oversize text messages if possible.
2018-01-25 13:26:10 -05:00
Matthew Chen
b9bd21e73f
Improve presentation of text attachments in attachment approval view.
2018-01-25 13:24:22 -05:00
Michael Kirk
05035e40a6
Fixup tests
...
// FREEBIE
2018-01-25 11:00:38 -05:00
Michael Kirk
6491bb8956
Fix timer offset
...
// FREEBIE
2018-01-22 16:55:09 -05:00
Michael Kirk
baa312f449
Timer button with duration label
...
// FREEBIE
2018-01-22 10:28:51 -05:00
Michael Kirk
f41dfa509c
Re-aquire first responder when necessary.
...
// FREEBIE
2018-01-19 15:05:50 -05:00
Michael Kirk
3ca5ec2726
Ensure media-library permissions when accessing media library
...
// FREEBIE
2018-01-18 13:37:11 -05:00
Michael Kirk
5dde17d939
Show approval/caption view in app.
...
ApprovalView/Captioning is shown for:
- Images/Videos from Library
- Images/Video from Camera
- Document Picker
- GIFs
Voice notes are intentionally not captionable.
Also, in main app, hide status bar when ApprovalView is presented
// FREEBIE
2018-01-17 18:19:48 -05:00
Michael Kirk
58558b36de
Add clarifying comment.
...
// FREEBIE
2018-01-17 18:11:48 -05:00
Michael Kirk
0c6a42003f
clang-format after RI
...
// FREEBIE
2018-01-16 15:27:53 -05:00
Michael Kirk
a423fe8a0e
WIP Merge tag '2.19.4.4'
...
- restore video playback in fullscreen
This was a large merge, so I'm opting to make some changes in separate
commits.
2018-01-16 15:25:58 -05:00
Matthew Chen
17907dca10
Clean up ahead of PR.
2018-01-12 10:23:54 -05:00
Matthew Chen
15b8e58324
Retain changes from session database branch.
2018-01-12 10:23:54 -05:00
Michael Kirk
63c23b77d0
Cleanup presentation view, feels less blurry
...
// FREEBIE
2018-01-12 00:17:06 -05:00
Michael Kirk
8851413b35
CR: cleanup, remove debug animation time, move constant
...
// FREEBIE
2018-01-11 23:05:59 -05:00
Michael Kirk
74e03aad01
Fix intermittent content offset problem
...
Using the CollectionView's frame to determine if we're at the bottom
doesn't make sense unless the collection view is correctly layed out.
// FREEBIE
2018-01-11 23:04:18 -05:00
Matthew Chen
16f7317579
Complete backup restore/import.
2018-01-11 10:44:03 -05:00
Matthew Chen
272a90d269
Add import back up UI. Begin work on import backup logic.
2018-01-11 10:42:57 -05:00
Matthew Chen
e77c3e6717
Retain changes from session database branch.
2018-01-10 12:18:23 -05:00
Michael Kirk
74019b2ae4
Fix keyboard animation glitch after sending
...
// FREEBIE
2018-01-09 12:31:41 -05:00
Michael Kirk
1ec409ad2b
CR: re-enable default keyboard toggle
...
// FREEBIE
2018-01-08 16:29:42 -05:00
Michael Kirk
8d2934d86e
CR: remove unnecessary code, comments
...
// FREEBIE
2018-01-08 15:11:35 -05:00
Michael Kirk
412fe2735e
Rename FullImageViewController -> MediaDetailViewController
...
// FREEBIE
2018-01-08 01:10:32 -05:00
Michael Kirk
918e3f7dfe
Videos play in full-screen media view controller, use modern movie
...
player.
// FREEBIE
2018-01-08 01:10:32 -05:00
Michael Kirk
81268012e5
Better keyboard management.
...
- fixes problems on iOS11.2 where emoji keyboard sometimes obscures text
input.
- better animation for interactive pan gesture when viewing message
details
- more intuitive swipe-to-dismiss keyboard in conversation view
- converge on one mnethod for dismissing keyboard in conversation view
- [ ] Pop keyboard, then hit attachment, dismisses keyboard, which is
fine, but the content should immediately scroll down with the
keyboard, instead it stays up, and scrolls down only once the
attachment action sheet has been dismissed.
// FREEBIE
2018-01-08 01:10:31 -05:00
sdkjfhsdkjhfsdlkjhfsdf
b87079d4b4
Sharing attachment shows progress / retry dialog
...
// FREEBIE
2017-12-20 20:57:17 -06:00
sdkjfhsdkjhfsdlkjhfsdf
513e33b0fd
Cleanup before code review
...
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
cf091758a5
Fix oversized text messages
...
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
82aeee301d
can delete text messages again
...
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
f5b9ae97ef
fix insets for incoming vs outgoin
...
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
eeaea5fa01
better match for corner radius
...
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
0ea3a36559
make sure captioned attachment doesn't grow too large
...
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
0e9c9a9bb3
Separate gestures for text/vs media
...
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf
92477c78b7
cleanup before PR
2017-12-20 14:26:53 -06:00
Michael Kirk
bce18637f0
render attachments with captions
...
// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk
3176cb5a62
text sizing correctly
2017-12-20 14:26:53 -06:00
Michael Kirk
f8866c4e0b
Fix some constraints, get other attachment types looking good
...
TODO
- [ ] message bubble sizes are not correct. Not always wide enough to
fit their content.
// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk
76ca52f33c
caption bubble properly sized, but all attachments make space now
2017-12-20 14:26:53 -06:00
Michael Kirk
3eb3c268a9
Towards a caption in message
...
TODO
- [ ] adjust height properly
- [ ] all media types
- [ ] include caption in message details
- [ ] gestures working on both independently
- [ ] perf benchmark
// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk
a5c5dd3f96
WIP, extract subclass
2017-12-20 14:26:53 -06:00
Matthew Chen
6b0e3508a5
Respond to CR.
2017-12-20 11:28:07 -05:00
Matthew Chen
9258b0883e
Clean up TSStorageManager usage.
2017-12-19 11:41:31 -05:00
Matthew Chen
9a990b58e8
Respond to CR.
2017-12-19 11:38:25 -05:00
Matthew Chen
3643414da1
Respond to CR.
2017-12-15 11:16:07 -05:00
Matthew Chen
e45d63e862
Clean up ahead of PR.
2017-12-15 11:11:57 -05:00
Matthew Chen
0c9d9ba679
Fix issues around cross process db changes.
2017-12-15 11:11:57 -05:00
Michael Kirk
8996741277
DocumentPicker converts to mp4 when necessary
...
// FREEBIE
2017-12-11 20:34:47 -05:00
Michael Kirk
031e40d090
Use SignalAttachment logic in conversation view too
...
// FREEBIE
2017-12-11 20:16:34 -05:00
Matthew Chen
74efcb9041
Rework thread safety in profile manager.
2017-12-11 12:28:28 -05:00
Matthew Chen
80ae5e0fcf
Respond to CR.
2017-12-11 10:37:20 -05:00
Matthew Chen
11b4848530
Respond to CR.
2017-12-11 10:37:20 -05:00
Matthew Chen
84061cca9f
Change image resizing/quality behavior, preferring smaller images in the common case.
2017-12-11 10:37:20 -05:00
Matthew Chen
125aabb0a3
Change image resizing/quality behavior, preferring smaller images in the common case.
2017-12-11 10:37:20 -05:00
Michael Kirk
d9cca77e23
update header references
...
// FREEBIE
2017-12-08 13:32:52 -05:00
Matthew Chen
b4e8df79da
Migrate environment to SignalMessaging.
2017-12-05 10:29:29 -05:00
Matthew Chen
6d87df88aa
Migrate environment to SignalMessaging.
2017-12-05 10:29:28 -05:00
Matthew Chen
bf21d0c0ed
Enable logging in SAE; rework log file management to include multiple log directories.
2017-12-01 12:55:47 -05:00
Matthew Chen
64762eb427
Observe YapDatabaseModifiedExternallyNotification.
2017-11-30 10:28:05 -05:00
Michael Kirk
9ac3ce3758
Memoize bubble factory
...
Shaves 5% off of initial conversation load.
// FREEBIE
2017-11-29 14:53:04 -08:00
Michael Kirk
fd829ba575
Merge branch 'hotfix/2.19.1'
2017-11-29 14:07:33 -08:00
Michael Kirk
a11d83187b
WIP: Framework-friendly - compiles but crashes on launch
...
// FREEBIE
2017-11-29 13:58:27 -08:00
Michael Kirk
9d1e3dc223
We need to change file extensions when converting data
...
// FREEBIE
2017-11-29 12:43:05 -08:00
Michael Kirk
1a99b34913
Fix iOS8 crash on type
...
// FREEBIE
2017-11-29 10:15:57 -08:00
Michael Kirk
a542471bbe
center "Loading More Messages" label
...
// FREEBIE
2017-11-22 13:32:20 -05:00
Matthew Chen
f9f0f1c27d
Revert "Force conversation view cells to update layout immediately."
...
This reverts commit ef820a3719
.
2017-11-22 13:12:15 -05:00
Matthew Chen
35bdc86ab5
Reload adjacent rows using original indices, not final indices.
2017-11-22 13:06:54 -05:00
Matthew Chen
71f5ef5940
Improve handling of unread indicator edge cases.
2017-11-22 10:39:38 -05:00
Matthew Chen
2ec1e7e925
Respond to CR.
2017-11-22 09:39:43 -05:00
Matthew Chen
2d241623b7
Improve handling of edge cases around unread indicator delimiting deleted message(s).
2017-11-21 18:17:19 -05:00
Matthew Chen
5ef9d53c91
Update conversation view UI to reflect unread state.
2017-11-21 17:53:52 -05:00
Matthew Chen
ef820a3719
Force conversation view cells to update layout immediately.
...
// FREEBIE
2017-11-21 17:52:14 -05:00
Michael Kirk
370364c936
Scroll down button scrolls to unread
...
// FREEBIE
2017-11-21 11:42:33 -05:00
Matthew Chen
b0c9add29c
Update layout of "scroll down button" to reflect RTL.
2017-11-21 11:27:01 -05:00
Matthew Chen
92ef507810
Make swipe-for-details RTL-safe.
2017-11-21 11:17:05 -05:00
Matthew Chen
aea2bf3e00
Fix scroll state insets in conversation view.
2017-11-20 17:17:10 -05:00
Matthew Chen
5cfa7e35f4
Respond to CR.
2017-11-20 17:08:10 -05:00
Michael Kirk
34811a635b
Fixes: "connected call" showing as "unconnected outgoing" call.
...
Expire viewItem cache when resetting mappings
// FREEBIE
2017-11-20 17:04:54 -05:00
Matthew Chen
b76d9a4e68
Remove redundant logTag methods.
2017-11-20 16:51:58 -05:00
Matthew Chen
a4879f6bb5
Remove redundant logTag methods.
2017-11-20 16:51:58 -05:00
Matthew Chen
8eb4e682d9
Revert "Show menu controller from centroid of message cells."
...
This reverts commit 08bb1c909d
.
2017-11-20 15:21:48 -05:00
Matthew Chen
cebeea9189
Reduce extremes of Jumbomoji behavior.
2017-11-20 15:02:45 -05:00
Matthew Chen
d8ae5841d6
Respond to CR.
...
// FREEBIE
2017-11-20 14:50:43 -05:00
Matthew Chen
45c7d80d97
Improving handling of edge cases in conversation view.
2017-11-20 14:44:10 -05:00
Matthew Chen
6d4a05bbea
Improving handling of edge cases in conversation view.
2017-11-20 14:44:10 -05:00
Matthew Chen
658746093d
Use finalIndex in row changes.
2017-11-20 14:44:10 -05:00
Michael Kirk
8ee030bea1
Don't dismiss keyboard when view appears
...
// FREEBIE
2017-11-20 14:30:55 -05:00
Matthew Chen
7b1a846f79
Dismiss keyboard when leaving conversation view.
2017-11-20 13:12:57 -05:00
Matthew Chen
572de11763
Apply dynamic type sizing to Jumbomoji.
2017-11-16 18:25:59 -05:00
Matthew Chen
937ac5830d
Skip animations in conversation view.
2017-11-16 17:59:32 -05:00
Matthew Chen
b67179b45d
Skip animations in conversation view.
2017-11-16 17:53:05 -05:00
Matthew Chen
0ccddb696a
Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons.
...
// FREEBIE
2017-11-16 17:32:39 -05:00
Matthew Chen
96274a60a9
Respond to CR.
...
// FREEBIE
2017-11-16 17:30:19 -05:00
Matthew Chen
7aae47b021
Reduce font size of "load more" indicator.
2017-11-16 17:30:19 -05:00
Matthew Chen
dffd776ace
Increase the max text message length.
2017-11-16 17:29:26 -05:00
Michael Kirk
228e350e2a
message details shows failed bubble when appropriate
...
// FREEBIE
2017-11-16 17:05:31 -05:00
Matthew Chen
6b8f4c7dde
Dismiss menu controller if message cell is hidden or recycled.
2017-11-16 16:35:53 -05:00
Matthew Chen
08bb1c909d
Show menu controller from centroid of message cells.
2017-11-16 15:38:11 -05:00
Matthew Chen
aad93d2d89
Fix broken assert in conversation view item.
2017-11-16 13:23:47 -05:00
Matthew Chen
ddf4bf28cc
Load attachments for conversation view items using long-lived db connection.
2017-11-16 13:16:18 -05:00
Matthew Chen
df5aa5ef67
Update UI to reflect changes to disappearing messages configuration.
2017-11-16 12:25:43 -05:00
Michael Kirk
9675cbb1e1
Scroll only as far as necessary
...
// FREEBIE
2017-11-15 17:30:45 -05:00
Matthew Chen
cc90f4cb80
Respond to CR.
...
// FREEBIE
2017-11-15 15:46:27 -05:00
Matthew Chen
86fdd6dea2
Fix edge cases in conversation view.
2017-11-15 15:43:03 -05:00
Matthew Chen
6413bc8e4c
Evacuate the view item cache.
2017-11-15 13:36:56 -05:00
Matthew Chen
19ba564f80
Respond to CR.
...
// FREEBIE
2017-11-15 13:21:31 -05:00
Matthew Chen
c6160a5a1e
Rework the "update with..." methods to avoid re-saving deleted models.
2017-11-15 07:16:12 -05:00
Michael Kirk
8c69e00a3f
Adapt ConversationViewController to iPhoneX
...
// FREEBIE
2017-11-14 12:37:09 -05:00
Matthew Chen
c3b6c9055e
Disable partial text selection; ignore taps outside links; ignore taps on non-sent messages, link-icy all links.
2017-11-13 18:46:41 -05:00
Matthew Chen
3da1d8c63f
Disable partial text selection; ignore taps outside links; ignore taps on non-sent messages, link-icy all links.
2017-11-13 11:18:38 -05:00
Matthew Chen
c91dda43e0
Disable partial text selection; ignore taps outside links; ignore taps on non-sent messages, link-icy all links.
2017-11-13 11:15:58 -05:00
Matthew Chen
c3087cf3df
Don't dismiss keyboard when tapping in the conversation view.
2017-11-13 10:41:41 -05:00