Commit Graph

5629 Commits

Author SHA1 Message Date
Renovate Bot 1055c2d7e4
Update dependency ember-cli-mirage to v1.1.7 2020-06-08 17:31:43 +00:00
Kevin Ansfield 17cb3ece43 Added display of server-side error message when bookmark request fails
closes https://github.com/TryGhost/Ghost/issues/11212

- store error message that is received from the server and remove the url from the context string for cleaner display
2020-06-08 17:40:33 +01:00
Rish 7fde2e1aac Updated fix for staff user edit button using task button property
refs TryGhost/Ghost#11789

- Reverted aaac414745 as we want to handle the state with css props instead of relying on specificity
- Updates fix for change password button on staff user edit screen to use task button props - aaac414745
2020-06-08 19:54:48 +05:30
Renovate Bot c7c24623cb
Update dependency @tryghost/kg-parser-plugins to v1.0.1 2020-06-08 10:18:57 +00:00
Renovate Bot 9c08c994c7
Update dependency @tryghost/kg-clean-basic-html to v1.0.1 2020-06-08 08:03:17 +00:00
Kevin Ansfield 28aa16f9a9 Removed ember-cli-chai in favour of direct ember-auto-import imports
no issue

- removes some deprecated babel plugins from our dependencies
2020-06-08 08:37:14 +01:00
Kevin Ansfield af81169657 Lock file maintenance 2020-06-08 08:25:29 +01:00
Kevin Ansfield c08faf1a2d Display original url in bookmark card
refs https://github.com/TryGhost/Ghost/issues/11212
credit @devaman https://github.com/TryGhost/Ghost-Admin/pull/1478

- display the original url rather than the fetched url in order to preserve query params and redirects (useful for affiliate links)
2020-06-08 08:21:34 +01:00
renovate[bot] ced46ea0e5
Update dependency @tryghost/kg-clean-basic-html to v1 (#1595)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-08 08:18:02 +01:00
renovate[bot] d4bcfd9c16
Update dependency @tryghost/kg-parser-plugins to v1 (#1596)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-08 07:57:27 +01:00
Renovate Bot 895d2a22f5
Update dependency eslint to v7.2.0 2020-06-08 02:17:38 +00:00
Renovate Bot ff55d556e2
Update dependency ember-composable-helpers to v4.1.2 2020-06-08 00:58:06 +00:00
Peter Zimon 2eebd206b9 Fixed test for member import dialog copy changes
no refs.
2020-06-05 15:41:00 +02:00
Peter Zimon 563c740a42 Refined copy for member import dialog
no issues.
- refined copy for member import start and end step screens
2020-06-05 15:03:43 +02:00
Nazar Gargol bc72f6eb3c Updated members' import file validation logic
no issue

- The invalid file type error should be shown on the very first step of import and should not allow proceeding without selecting a correct file.
2020-06-06 00:48:09 +12:00
Peter Zimon b64f2679c5 Refined members import dialog
no issue
- updated screen logic for member import
- added icons and refined styles for file upload dialog
2020-06-05 14:20:23 +02:00
Nazar Gargol 035d79d56f Added separate stage to members import popup with support of labels
refs 633ba27f0e

- Import modal is now devided into separate stages with ability to specify labels which will be assigned to every member present in the dataset.
- Also adds explicit "Import" button without automatic import when the CSV file is selected
2020-06-05 22:57:07 +12:00
renovate[bot] 12fa72b02f
Update dependency ember-data to v3.19.0 (#1593)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-05 11:12:11 +01:00
renovate[bot] 3ef3540c04
Update dependency testem to v3.2.0 (#1592)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-05 10:58:14 +01:00
renovate[bot] 3c4151ac0f
Update dependency markdown-it to v11 (#1575)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-05 10:52:34 +01:00
Kevin Ansfield 1635a34e4b 🐛 Fixed member list not updating when manually adding a new member
no issue

- always refresh members list/stats data when adding or saving a member from the members screen
2020-06-05 09:01:01 +01:00
Kevin Ansfield ff565a369c 🐛 Fixed members list not updating after deleting a member
no issue

- force a full refresh of all members data when deleting rather than only forcing a refresh of the stats
2020-06-05 08:53:58 +01:00
Kevin Ansfield b75f5965d3 🐛 Fixed members list not refreshing after adding yourself
no issue

- passed in the `refreshData` action to the `<GhMembersNoMembers>` component and called it after creating the member
- converted `<GhMembersNoMembers>` to a glimmer component
2020-06-05 08:50:20 +01:00
Kevin Ansfield 22a24d1d19 Fixed no-shadow linting warnings in text-expansions.js
no issue

- part of gradual cleanup to remove linter warnings
2020-06-05 08:31:46 +01:00
Kevin Ansfield db8b913e2d Fixed tests
refs 4a53587f3b

- updated tests to use `settings.shared_views` in place of `user.accessibility`
2020-06-04 21:43:54 +01:00
Kevin Ansfield 4a53587f3b Switched per-user custom views to shared custom views
requires fdeb7daf40

- swapped to using settings model for storing custom views instead of user accessibility field
- added conditional that checks current user is an admin/owner when displaying the manage custom views button in the content filter (only admins/owners can edit settings model)
  - passed `session.user` into the `<GhContentFilter>` component as an argument so that the conditional getter doesn't need to handle async user access
- fixed no-shadow linting error in settings service
2020-06-04 21:30:06 +01:00
Renovate Bot e31ae2f3fa
Update dependency ember-composable-helpers to v4.1.1 2020-06-04 14:29:15 +00:00
Rish a258e8ad15 Removed redundant auto reset for amp
no issue

- Auto reset is on by default, this got missed in last commit
2020-06-04 19:25:42 +05:30
Rish 4ed4f71c71 Removed redundant reset value for task buttons
no issue

- Since task buttons by default have reset on now, we don't need to explicitly add it to individual buttons
2020-06-04 19:23:59 +05:30
Rish aaac414745 🐛 Fixed change password button state on staff screen
closes https://github.com/TryGhost/Ghost/issues/11789

- Invert css classes definitions for red/green buttons to allow the button to turn green for the success state

Credits - https://github.com/m1kl - https://github.com/TryGhost/Ghost-Admin/pull/1568
2020-06-04 18:44:38 +05:30
Rish 36fa9dc32c Enabled auto reset state for action buttons
no issue

- By default, action buttons had auto-reset off and reset had to be explicitly set
- Auto reset for action buttons is on by default now, and any button that should not reset should explicitly switch it off
2020-06-04 18:44:38 +05:30
Renovate Bot 0e8b66018e
Update dependency fs-extra to v9.0.1 2020-06-04 00:25:50 +00:00
renovate[bot] fc3f61464a
Update dependency ember-composable-helpers to v4.1.0 (#1589)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-06-03 21:19:47 +01:00
Fabien O'Carroll 1db5968131 Corrected url for Stripe Connect auth
no-issue

This was missed in the PR changes requests in Ghost.
2020-06-03 15:10:29 +02:00
Daniel Lockyer 5d268bfe52 v3.18.1 2020-06-02 18:07:38 +01:00
Renovate Bot 9aafc5ad66
Update dependency ember-cli-babel to v7.20.5 2020-06-02 15:40:27 +00:00
Daniel Lockyer f508aa1eb5 v3.18.0 2020-06-02 15:22:02 +01:00
Fabien 'egg' O'Carroll c17612e3d1
Added Stripe Connect UI (#1586)
no-issue

- Rendering is conditional on `stripeDirect` config being false.
- CSS downloaded from https://stripe.com/newsroom/brand-assets
- `stripe_connect_integration_token` is the setting to _set_ the
  stripe_connect_integration setting
2020-06-02 13:58:43 +02:00
Peter Zimon 342d8dd686 Fixed members list cell wrapping
no issues.
- sets members cells wrapping to avoid table cells overlapping
2020-06-02 12:30:11 +02:00
Kevin Ansfield d42ea9a480 Lock file maintenance
refs https://github.com/TryGhost/Ghost/issues/11868

- includes bump of `ember-basic-dropdown` that contains accessibility improvements
2020-06-02 09:01:06 +01:00
Kevin Ansfield ef491730d8 Fixed members list/chart not updating after members import
no issue

- move members loading code into `members` controller so that it's more accessible to other areas of the app
- add `refreshData()` to the `members` controller which forces members list and stats to be re-fetched
- call `members.refreshData()` after successful upload of members import file
- store range/days in `membersStats` service so that it's remembered across refreshes and component renders
2020-06-01 15:48:46 +01:00
Peter Zimon 8867c364ff Added placeholder to impersonate URL
no issues.
- adds a placeholder value for impersonate URL field to avoid empty field while loading
- disables "Copy link" button until the actual URL is not loaded
2020-06-01 10:04:12 +02:00
Renovate Bot 8e9d71cac6
Update dependency ember-cli-babel to v7.20.4 2020-06-01 00:33:05 +00:00
Renovate Bot a1786bccf5
Update dependency ember-cli-babel to v7.20.3 2020-05-29 15:48:44 +00:00
Renovate Bot 981e68a00f
Update dependency ember-cli-babel to v7.20.2 2020-05-29 13:49:53 +00:00
Renovate Bot 9f9e1f2cea
Update dependency ember-cli-babel to v7.20.1 2020-05-29 02:35:23 +00:00
Marco Zehe 263724dc83
🐛 Fixed various Close buttons throughout the UI. (#1585)
refs TryGhost/Ghost#11863

Some `a`tags with `href` attributes that are empty are used as buttons, but since the href is not linkifying anything, they appear as text nodes to assistive technologies. Give them a `"button"` role so it is guaranteed that assistive technologies will pick them up as actionable controls.
2020-05-28 17:11:21 +01:00
Marco Zehe 52b53d068b
Various A11y post screen fixes (#1584)
refs #11863

* 🐛 Gave various buttons accessible labels

Hidden span elements are not rendered to assistive technologies, so duplicate the text in an aria-label on the button element.

* 🐛 Fixed various accessibility issues in the editor

* Made menus menus and menu item menuitems.
* Added labels to buttons where there were only hidden spans, or no text at all.
* Made separators show up for screen readers.
2020-05-28 16:01:09 +01:00
Marco Zehe ef56dbfad9
🐛 Fixed various small accessibility problems in the admin screen (#1583)
refs #11863

* 🐛 Fixed accessible button label for showing and hiding custom post types.
* 🐛 Made the menu separators accessible.
* 🐛 Fixed the More item to be a button for assistive technologies.
2020-05-28 15:51:14 +01:00
Kevin Ansfield 3da16a8c32 Improved performance of members admin screens
no issue

- removes the "old" members screens
- swaps route names and links to point at the new members screens that were behind the experiments flag

Why are the new screens faster?

- only loads 50 members at once rather than every member in the database
- loads pages of members in as-needed whilst scrolling
- fetches member stats from the API rather than calculating locally
- caches members list and stats data for 60 seconds to avoid re-fetching when navigating to/from the members list
- moves search and filtering duties to the API rather than calculating locally
2020-05-28 13:35:53 +01:00