1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
Commit graph

5448 commits

Author SHA1 Message Date
Kevin Ansfield
e80fa137db Updated members routes/controllers with Octane idioms
no issue

- ran [`ember-native-class-codemod`](https://github.com/ember-codemods/ember-native-class-codemod) on members-related files
- updated files to remove need for `@classic` decorator where possible
    - switched to tracked properties
    - removed usage of `this.get/set/toggleProperty` etc
- swapped usage of `{{action 'foo'}}` for `{{this.foo}}`
2020-05-20 16:39:31 +01:00
Kevin Ansfield
9250d7939b Swapped duplicated members files from -dev to -old
no issue

- allows continued development on the "original/non duplicated" files to better preserve git history once the `-old.*` files are deleted
2020-05-20 16:39:31 +01:00
Fabien O'Carroll
c7b75e35dd Hid Stripe apikey form if stripeDirect: false
no-issue

We are going to keep the UI as a fallback in future. Eventually this
`if` will include an `else` block rendering a Stripe Connect button.
2020-05-20 16:49:00 +02:00
Kevin Ansfield
e32ba68c80 Fixed missing CSS styles in production builds
no issue

- some styles such as `border: none` inside `.gh-btn-white` were being stripped when ran through `clean-css` leading to visual differences between development and production
- disabled `ember-cli`'s default CSS minification as we already use `cssnano` for minification in our postcss pipeline for both dev and prod builds
2020-05-20 11:05:30 +01:00
Peter Zimon
a5fa4074e2 Removed test email function from Labs
no refs.
- removes leftover test email section from Labs to resolve a lot of confusion around it
2020-05-20 11:34:56 +02:00
Peter Zimon
51fc3008b2 Fixed FF dropdown visual bug
no refs.
- fixes double border visual bug in Firefox
2020-05-20 09:49:12 +02:00
Daniel Lockyer
208198c166 v3.16.1 2020-05-20 07:30:34 +01:00
Renovate Bot
9453b85d5d
Update dependency pretender to v3.4.3 2020-05-19 16:23:14 +00:00
renovate[bot]
7666935018
Update dependency ember-cli-babel to v7.20.0 (#1574)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-19 17:22:46 +01:00
Kevin Ansfield
dc5549a265 Duplicated members screens for development experiments
no issue

- members screens will be undergoing heavy development to change how underlying data loading works
- duplicated all related screens and components so that development can occur behind the `enableDeveloperExperiments` flag without breaking the existing screens
- added "Members (dev)" link to the duplicate screens in nav bar when `enableDeveloperExperiments` is on
2020-05-19 16:18:30 +01:00
Aileen Nowak
c87e01a433 Updated Pacific theme screenshot
no issue

Updated screenshot, as the theme look has changed
2020-05-19 14:10:35 +12:00
Daniel Lockyer
78e905e272 v3.16.0 2020-05-18 14:43:53 +01:00
Kevin Ansfield
acb3624de3 Fixed saving of custom views expansion state
no issue

- if `user.accessibility` is `null` as it is for newly created users then toggling the expansion state of custom views menus failed to save because we were assuming there was an object available
2020-05-18 13:45:59 +01:00
Kevin Ansfield
db8a53e8f5 Fixed initial animation of custom views expansion
no issue

- apply defaults during service initialisation so that `navigation.settings.expanded.posts` doesn't start out as "undefined" then transition to "true" on first render resulting in unnecessary animation in the sidebar
- speeds up acceptance tests which no longer need to wait for animation to complete before continuing
2020-05-18 13:42:01 +01:00
Kevin Ansfield
f4524e0206 Fixed delete button in token select inputs
refs cc80214916

- ember-power-select switch to Glimmer components meant that our mousedown handler that was going through Ember's event bus was firing after the EPS events which trigger dropdown open/close and therefore not triggering the delete action
2020-05-18 13:33:21 +01:00
Kevin Ansfield
d6058dbf27 Co-located component template files
no issue

Keeps component JS backing files and template files in the same directory which avoids hunting across directories when working with components. Also lets you see all components when looking at one directory, whereas previously template-only or js-only components may not have been obvious without looking at both directories.

- ran [codemod](https://github.com/ember-codemods/ember-component-template-colocation-migrator/) for app-level components
- manually moved in-repo-addon component templates in `lib/koenig-editor`
- removed all explicit `layout` imports as JS/template associations are now made at build-time removing the need for them
- updated `.embercli` to default to new flat component structure
2020-05-18 13:14:08 +01:00
renovate[bot]
8dd6c5c5c0
Update dependency ember-infinity to v2.1.2 (#1573)
* Update dependency ember-infinity to v2.1.2
* updated gh-infinity-loader template to match ember-infinity default template

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2020-05-18 09:06:04 +01:00
renovate[bot]
d8971b0996
Update dependency ember-source to v3.18.1 (#1571)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-18 08:01:48 +01:00
renovate[bot]
9420525bfa
Update dependency ember-useragent to v0.10.0 (#1572)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-18 07:57:36 +01:00
renovate[bot]
b18e5083b0
Update dependency autoprefixer to v9.8.0 (#1570)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-18 07:56:44 +01:00
Renovate Bot
d54c69eeed
Update dependency ember-source to v3.16.8 2020-05-18 00:15:09 +00:00
Kevin Ansfield
4f9ff7ff83 Lock file maintenance 2020-05-17 23:05:58 +01:00
renovate[bot]
2eff6cf2d7
Update dependency eslint to v7 (#1566)
* Update dependency eslint to v7

* Fixed linting errors

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2020-05-17 22:53:37 +01:00
renovate[bot]
25fd55f42e
Update dependency blueimp-md5 to v2.16.0 (#1569)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-17 22:43:28 +01:00
Kevin Ansfield
e374afe1ac Removed ember-source from renovate ignore list
no issue

- `ember-power-select` has been upgraded which was the blocker for ember-source upgrade
2020-05-17 22:37:51 +01:00
renovate[bot]
cc80214916
Update dependency ember-power-select to v4 (#1528)
* Update dependency ember-power-select to v4
* Fixed trigger component override collision when building

- move the "override" into our own namespace
- update all `<PowerSelect>` usage to explicitly reference our customised trigger component

* Bumped ember-power-datepicker

- bumps `ember-basic-dropdown` sub-dependency
- resolves "Error: Could not find module `ember-compatibility-helpers` imported from `@glimmer/component/index`"
- https://github.com/cibernox/ember-basic-dropdown/issues/551

* Updated trigger to use class syntax

- it's not possible to use `.extend()` on an imported class

* Updated <GhBasicDropdown>

- match updated ember-basic-dropdown code

* Added `autofocus` modifier

- added `ember-modifier` dependency so that we can create our own render modifiers

* Updated <GhSearchInputTrigger> to a glimmer component

* Updated gh-token-input components

* Fixed tests

- wrap `<PowerSelect>` with `<div>` to maintain test selectors
- fixed `<GhBasicDropdown>` not rendering anything due to not having a local template

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2020-05-17 22:35:53 +01:00
renovate[bot]
7e195b24dc
Update dependency ember-infinity to v2.1.1 (#1484)
no issue

- fixed template reference
- updated template to match upstream's use of render-modifiers
- removed silencing of `isVisible` deprecation

Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-12 09:05:17 +01:00
Kevin Ansfield
499ed7b764 Fixed incorrect validation when member's name is too long
no issue

- the email length validation was conditional on `member.name` rather than `member.email` so if the name was too long both name and email were marked as invalid
2020-05-11 11:40:38 +01:00
Kevin Ansfield
69e5cdb5e9 Reduced unnecessary waiting in tests
no issue

- fixed `<GhTaskButton>` not resetting after an externally triggered task run such as when pressing Cmd+S
- cleaned up manual timeouts/resets where button reset is now fully handled by `<GhTaskButton>` (these were causing 2.5s waits each time a save occurred in acceptance tests)
- where manual timeouts were required, reduce testing time from >2.5s to 50ms
2020-05-11 11:37:35 +01:00
Kevin Ansfield
8b0b5a27a8 Update dependency eslint-plugin-ghost to v1.4.1
no issue

- enables `prefer-ember-test-helpers` rule
- fixes single linting error from the new rule
2020-05-11 10:20:03 +01:00
renovate[bot]
7a923f0679
Update dependency ember-cli-moment-shim to v3.8.0 (#1567)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-11 09:02:39 +01:00
renovate[bot]
2eb598360f
Update dependency blueimp-md5 to v2.15.0 (#1565)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-11 09:00:27 +01:00
Renovate Bot
15c25532e5
Update dependency broccoli-funnel to v3.0.3 2020-05-11 00:16:04 +00:00
Renovate Bot
a95de29b64
Update dependency ember-cli-htmlbars to v5.1.2 2020-05-08 15:12:18 +00:00
renovate[bot]
65ed1b75d5
Update dependency ember-cli-htmlbars to v5 (#1559)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-08 13:00:28 +01:00
renovate[bot]
9ca5392a16
Update dependency ember-cli to v3.18.0 (#1558)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-08 12:59:57 +01:00
Daniel Lockyer
c5aff8c2f0 v3.15.3 2020-05-08 12:17:17 +01:00
renovate[bot]
b8b944c079
Update dependency blueimp-md5 to v2.14.0 (#1557)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-08 12:07:49 +01:00
renovate[bot]
e197d2d93d
Update dependency ember-test-selectors to v4.1.0 (#1564)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-05-08 12:06:29 +01:00
Liam Williams
a540265c43
🐛 Fixed unselectable routes files in macOS Safari (#1472)
closes TryGhost/Ghost#11472

- adds an explicit `.yaml` to the `accepts` attribute of the routes file uploader to work around Safari only allowing `.yml` to be selected when given the yaml mime type
2020-05-08 12:05:55 +01:00
Kevin Ansfield
7ebbdc3297
💄 Adjusted email previews to better represent email behaviour of embed cards (#1554)
no issue

- added `sandbox` attribute which blocks scripts from running inside the iframe
- results in better representation of how embeds will render in emails where scripts are not allowed
2020-05-08 11:54:18 +01:00
Daniel Lockyer
144efa249b v3.15.2 2020-05-07 21:59:02 +01:00
Daniel Lockyer
0ba237bc8f v3.15.1 2020-05-07 10:52:18 +01:00
Kevin Ansfield
571c0881ef 🐛 Fixed autofocus on password reset screen
no issue

- autofocus was running on both inputs so the "confirm" input was winning out
- updated copy
2020-05-07 10:33:27 +01:00
Renovate Bot
c625286702
Update dependency ember-cli-postcss to v6.0.1 2020-05-06 23:14:55 +00:00
Kevin Ansfield
479eecba4c Update dependency eslint-plugin-ghost to v1.4.0
no issue

- applies fixes for new/updated rules
- disables `ember/no-mixins` rule as we're not able to migrate away yet
2020-05-06 18:07:01 +01:00
Daniel Lockyer
d48fd0ebdd v3.15.0 2020-05-06 13:43:38 +01:00
Rish
e4d66d4623 Fixed typo in regenerate modal
no issue
2020-05-06 12:48:20 +05:30
Rish
c6b0fb90ae Cleaned key regeneration message for Zapier on route change
no issue

- After a successful key regeneration, the success message stayed in Zapier integration even on navigating away to different page, this clears up any message state on away transition
2020-05-06 12:43:29 +05:30
Rish
bc0106ce0c Added regenerate copy tweak for internal Zapier integration
no issue

- Updates dialog copy for confirmation of regenerating internal Zapier integration admin key
2020-05-06 12:36:43 +05:30