vantablack
/
vantaMOO
5
6
Fork 4
Code Issues 14 Pull Requests Packages Projects Releases Wiki Activity

Inherit RPCharacter from ClothedCharacter #30

Closed
oreolek wants to merge 2 commits from oreolek:clothing into vanta
pull from: oreolek:clothing
merge into: vantablack:vanta
Conversation 9 Commits 2 Files Changed 2 +4 -4
oreolek commented 2023-01-11 06:26:02 +01:00
Contributor
Copy Link

Multi-inheritance breaks get_display_things

This is a way to address #29

Multi-inheritance breaks `get_display_things` This is a way to address #29
oreolek added 1 commit 2023-01-11 06:26:04 +01:00
7d4e0c9b5a
Inherit RPCharacter from ClothedCharacter 
Multi-inheritance breaks `get_display_things`
lunacb commented 2023-01-11 07:45:19 +01:00
Contributor
Copy Link

This doesn't fix the problem. Now ContribRPCharacter's methods just override ClothedCharacter's.

This doesn't fix the problem. Now `ContribRPCharacter`'s methods just override `ClothedCharacter`'s.
lunacb commented 2023-01-11 07:52:31 +01:00
Contributor
Copy Link

I don't think there's a good solution to the problem that doesn't involve refactoring the contrib code.

I don't think there's a good solution to the problem that doesn't involve refactoring the contrib code.
oreolek commented 2023-01-11 07:54:30 +01:00
Author
Contributor
Copy Link

Now ContribRPCharacter's methods just override ClothedCharacter's.

Not quite. ContribRPCharacter defers to super's method if there's no a special RP code present, so it will use ClothedCharacter's code instead of default.

> Now `ContribRPCharacter`'s methods just override `ClothedCharacter`'s. Not quite. `ContribRPCharacter` defers to `super`'s method if there's no a special RP code present, so it will use `ClothedCharacter`'s code instead of default.
lunacb commented 2023-01-11 08:01:12 +01:00
Contributor
Copy Link

oh, you're right.

I still think it's good to refactor more eventually, though. it still feels messy and unintuitive to me, and wouldn't scale well if more contrib code/features were to be added.

oh, you're right. I still think it's good to refactor more eventually, though. it still feels messy and unintuitive to me, and wouldn't scale well if more contrib code/features were to be added.
oreolek commented 2023-01-11 08:09:39 +01:00
Author
Contributor
Copy Link

I'm not a python dev so this is the best i can do for now.

I'm not a python dev so this is the best i can do for now.
lunacb commented 2023-01-11 11:11:51 +01:00
Contributor
Copy Link

Sorry, I'm not trying to be accusatory! I'm not a python dev either.

Sorry, I'm not trying to be accusatory! I'm not a python dev either.
oreolek added 1 commit 2023-01-12 10:04:38 +01:00
vantablack commented 2023-01-17 08:10:20 +01:00
Owner
Copy Link

i can't merge this

it says "This pull request has changes conflicting with the target branch.
typeclasses/characters.py"

i can't merge this it says "This pull request has changes conflicting with the target branch. typeclasses/characters.py"
oreolek commented 2023-01-17 13:54:35 +01:00
Author
Contributor
Copy Link

okay i'm gonna defer to @lunacb on this one because she already rewrote this code while working on pronouns.

okay i'm gonna defer to @lunacb on this one because she already rewrote this code while working on pronouns.
lunacb commented 2023-01-17 22:05:34 +01:00
Contributor
Copy Link

I'll open a new PR. This one can be closed.

I'll open a new PR. This one can be closed.
oreolek closed this pull request 2023-01-18 04:52:10 +01:00
oreolek deleted branch clothing 2023-01-22 06:33:28 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vantablack/vantaMOO#30
No description provided.
Delete Branch "oreolek:clothing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?