Commit graph

1064 commits

Author SHA1 Message Date
Matthew Chen
e0f2a76c73 Animate sending icon. 2018-06-29 12:50:16 -04:00
Matthew Chen
24c4c4c098 Respond to CR. 2018-06-29 12:49:23 -04:00
Matthew Chen
23435b690a Tweak message contents. 2018-06-29 12:43:41 -04:00
Matthew Chen
dd28c01897 Tweak date headers. 2018-06-29 12:43:41 -04:00
Matthew Chen
fa5bfc25e1 Tweak system messages and unread indicators. 2018-06-29 12:43:41 -04:00
Matthew Chen
d2f2e1cb22 Respond to CR. 2018-06-29 12:41:30 -04:00
Matthew Chen
3d5cff1ed0 Tweak attachment download view. 2018-06-29 12:38:49 -04:00
Matthew Chen
554606e2a7 Ensure body media size. 2018-06-29 12:38:05 -04:00
Matthew Chen
e80e5ff9cb Improve layer view design. 2018-06-29 12:32:41 -04:00
Matthew Chen
1e2a498806 Tweak media view gradients. 2018-06-29 12:32:41 -04:00
Matthew Chen
0613cf3bb7 Fix bubble strokes. 2018-06-29 12:28:58 -04:00
Matthew Chen
f607eabb7a Fix audio message layout. 2018-06-29 12:27:19 -04:00
Matthew Chen
d869afc3e4 Tweak break spacing. 2018-06-28 15:06:53 -04:00
Matthew Chen
7d971f1b79 Rework view item configuration. 2018-06-28 15:06:09 -04:00
Matthew Chen
dc531a86ea Tweak message cells. 2018-06-28 15:06:09 -04:00
Matthew Chen
87380894ba Tweak message cells. 2018-06-28 15:03:44 -04:00
Matthew Chen
17d4ccc489 Disable compact text layout. 2018-06-28 15:03:02 -04:00
Matthew Chen
35dc348551 Move conversation style. 2018-06-28 13:26:17 -04:00
Matthew Chen
f2153f888b Tweak color palette. 2018-06-28 13:18:35 -04:00
Matthew Chen
cbc80abff1 Tweak color palette. 2018-06-28 13:18:35 -04:00
Matthew Chen
7634e3a44d Respond to CR. 2018-06-28 13:16:59 -04:00
Matthew Chen
ffb1c35383 Clean up ahead of PRs. 2018-06-27 17:08:46 -04:00
Matthew Chen
3beac83a12 Clean up ahead of PRs. 2018-06-27 17:07:14 -04:00
Matthew Chen
416a52b74a Tweak contact shares. 2018-06-27 17:03:26 -04:00
Matthew Chen
3c4d14034b Tweak contact shares. 2018-06-27 17:03:03 -04:00
Matthew Chen
dc79d302c6 Tweak audio messages. 2018-06-27 16:58:19 -04:00
Matthew Chen
a0b612c64b Tweak generic attachments. 2018-06-27 16:57:29 -04:00
Matthew Chen
774310396c Clean up ahead of PR. 2018-06-27 16:51:30 -04:00
Matthew Chen
5f09080699 Clean up ahead of PR. 2018-06-27 16:51:30 -04:00
Matthew Chen
9cc3a3b7b3 Add body media shadows. 2018-06-27 16:51:30 -04:00
Matthew Chen
e9973b2095 Respond to CR. 2018-06-27 16:49:54 -04:00
Matthew Chen
966e6a1156 Tweak sender names. 2018-06-27 13:18:31 -04:00
Matthew Chen
c744245c4a Fix corner rounding. 2018-06-27 13:17:24 -04:00
Matthew Chen
227234d8cb Respond to CR. 2018-06-27 13:15:31 -04:00
Matthew Chen
dc86bee5d1 Respond to CR. 2018-06-27 09:56:11 -04:00
Matthew Chen
16a1dcfb77 Respond to CR. 2018-06-27 09:53:45 -04:00
Matthew Chen
89523f556b Tweak intra-cell spacing. 2018-06-27 09:33:47 -04:00
Matthew Chen
d04ee35216 Respond to CR. 2018-06-27 09:27:09 -04:00
Matthew Chen
4fc24540dc Breaks: unread indicators and date headers. 2018-06-27 09:20:49 -04:00
Matthew Chen
a4703cec76 Breaks: unread indicators and date headers. 2018-06-27 09:20:49 -04:00
Matthew Chen
4b60037e35 Breaks: unread indicators and date headers. 2018-06-27 09:20:49 -04:00
Matthew Chen
d34e53a163 Breaks: unread indicators and date headers. 2018-06-27 09:20:49 -04:00
Matthew Chen
572fee6173 Respond to CR. 2018-06-27 09:19:51 -04:00
Matthew Chen
f5239a4fbd Compact layout / widow reduction. 2018-06-27 09:11:55 -04:00
Matthew Chen
2232c25487 Ensure bubble sizing. 2018-06-26 13:33:53 -04:00
Matthew Chen
c7f9575df6 Ensure bubble sizing. 2018-06-26 13:33:47 -04:00
Matthew Chen
3fba101421 Respond to CR. 2018-06-26 13:32:05 -04:00
Matthew Chen
18417edbde Introduce message cell footer view. 2018-06-26 13:25:07 -04:00
Matthew Chen
7d5ad0e165 Introduce message cell footer view. 2018-06-26 13:25:07 -04:00
Matthew Chen
6626e2ecc3 Introduce message cell footer view. 2018-06-26 13:25:07 -04:00
Matthew Chen
f363a196f3 Introduce message cell footer view. 2018-06-26 13:25:07 -04:00
Matthew Chen
cbacda87ca Introduce message cell footer view. 2018-06-26 13:25:07 -04:00
Matthew Chen
8cfb6eef18 Refine conversation style. 2018-06-26 10:22:05 -04:00
Matthew Chen
33b1628c26 Rename to ConversationStyle. 2018-06-26 10:20:26 -04:00
Matthew Chen
a5d52c4203 Clean up ahead of PR. 2018-06-25 15:09:45 -04:00
Matthew Chen
4effa56d50 Tweak 'group sender' avatars. 2018-06-25 15:07:46 -04:00
Matthew Chen
a9b6fe5978 Respond to CR. 2018-06-25 15:00:45 -04:00
Matthew Chen
fdd6174871 Fix breakage from cell layout changes. 2018-06-25 14:41:14 -04:00
Matthew Chen
990bb81e4a Respond to CR. 2018-06-25 14:39:48 -04:00
Matthew Chen
a31bd16d90 Respond to CR. 2018-06-25 13:53:35 -04:00
Matthew Chen
7847db7e1c Tweak text insets to reflect dynamic type. 2018-06-25 13:51:28 -04:00
Matthew Chen
4b5d994c3f Respond to CR. 2018-06-25 13:49:31 -04:00
Matthew Chen
fc299b8700 Use UI database connection throughout the conversation cells. 2018-06-25 13:08:10 -04:00
Matthew Chen
d40f74dd0b Respond to CR. 2018-06-25 12:43:25 -04:00
Matthew Chen
196d82c17a Respond to CR. 2018-06-25 09:42:18 -04:00
Matthew Chen
53b1ae6a36 Fix gutter constants. 2018-06-25 09:26:41 -04:00
Matthew Chen
0b04397e21 Tweak message cells. 2018-06-25 09:26:41 -04:00
Matthew Chen
d425809fa3 Tweak message cells. 2018-06-25 09:26:41 -04:00
Matthew Chen
98ac13f9be Tweak message cells. 2018-06-25 09:26:41 -04:00
Matthew Chen
ac6f78a5fc Tweak message cells. 2018-06-25 09:26:41 -04:00
Matthew Chen
08ca4fdb50 Lazy-load contact avatar data and images. Use NSCache for avatar images. 2018-06-20 17:55:14 -04:00
Matthew Chen
83f11ad79b Don't cache CNContact. 2018-06-20 17:55:14 -04:00
Matthew Chen
1607aa7f57 Image content types. 2018-06-20 17:13:31 -04:00
Matthew Chen
0b64ecf675 Respond to CR. 2018-06-20 14:46:24 -04:00
Matthew Chen
32336e38e1 Merge tag '2.26.0.26' 2018-06-15 11:47:23 -04:00
Matthew Chen
b5a836bf28 Shared ui db connection v. auto load more. 2018-06-15 11:38:47 -04:00
Matthew Chen
f8e785ef72 Merge tag '2.26.0.25' 2018-06-15 09:59:45 -04:00
Michael Kirk
a91b6b35e2 update UI DB to latest before showing CVC
// FREEBIE
2018-06-14 18:23:13 -04:00
Michael Kirk
0cf751d34f Newly added group members should have expire time
Send expire timer with group info updates and in group updates that add a user.
2018-06-14 15:20:45 -04:00
Matthew Chen
95ac17bb7e Merge tag '2.26.0.24' 2018-06-14 15:07:47 -04:00
Michael Kirk
0dec029a69 Don't mark as read when callscreen is active
// FREEBIE
2018-06-13 15:42:01 -04:00
Matthew Chen
44b23d44fd Respond to CR. 2018-06-13 12:40:34 -04:00
Matthew Chen
999e8c8e31 Respond to CR. 2018-06-12 12:44:32 -04:00
Matthew Chen
13e9f11b4e Open message search results. 2018-06-12 12:44:32 -04:00
Matthew Chen
27b6a5e5bb Open message search results. 2018-06-12 12:44:32 -04:00
Matthew Chen
bb266d03e4 Preserve default scroll state until conversation view is presented. 2018-06-11 15:09:05 -04:00
Matthew Chen
19c9e226fb Respond to CR. 2018-06-01 17:51:18 -04:00
Matthew Chen
3964b78ff7 Reduce usage of JSQ. 2018-06-01 17:44:18 -04:00
Matthew Chen
833f6ad51d Skip missing and invalid interactions in conversation view. 2018-06-01 17:42:12 -04:00
Matthew Chen
2c0ba1cbd9 Skip missing and invalid interactions in conversation view. 2018-06-01 17:42:12 -04:00
Matthew Chen
6bc145ce3a Fix more build warnings. 2018-06-01 17:37:06 -04:00
Michael Kirk
9aafd89979 Remove unused synthesized ivars
// FREEBIE
2018-06-01 13:19:45 -04:00
Michael Kirk
ae1d82be84 Fix: input toolbar disappears when tapping media while edit menu is
present

// FREEBIE
2018-06-01 13:16:43 -04:00
Michael Kirk
e6c659d0ff remove incorrect comment 2018-06-01 13:16:43 -04:00
Michael Kirk
6e6a7446d0 Use global readWrite connection
// FREEBIE
2018-06-01 13:16:43 -04:00
Michael Kirk
468f7524ef Revert "separate read/write db connections"
This reverts commit 3e61741060e6a7c2a9891b46cf3abd567d33aa3a.
2018-06-01 13:16:43 -04:00
Michael Kirk
00f8ea4ff8 Use a single ui connection to share cache.
Primarly two things:
1. using an extension for the first time per connection is slow
2. fetching the same objects (e.g. if you leave/re-enter the same
conversation)

// FREEBIE
2018-06-01 13:16:43 -04:00
Michael Kirk
ddd39fcd3d separate read/write db connections
// FREEBIE
2018-06-01 13:16:42 -04:00
Michael Kirk
d9172cccb9 Measure time to display
// FREEBIE
2018-06-01 13:16:42 -04:00
Matthew Chen
879b9d4c72 Respond to CR. 2018-06-01 12:39:13 -04:00
Matthew Chen
9a08afae28 Fix build warnings. 2018-06-01 12:39:13 -04:00
Matthew Chen
3cd6a33aa6 Fix build warnings. 2018-06-01 12:39:13 -04:00
Matthew Chen
5ed22ada7b Respond to CR. 2018-06-01 12:01:20 -04:00
Matthew Chen
e4f7995e4d Ensure conversation view is first responder before presenting another view. 2018-06-01 11:59:26 -04:00
Matthew Chen
23e2d971e4 Handle layout of long group name labels. 2018-06-01 11:54:42 -04:00
Matthew Chen
9ee572fb24 Respond to CR. 2018-05-31 16:36:16 -04:00
Matthew Chen
fefc9843b1 Modify views to observe changes when active, not just foreground. 2018-05-31 16:31:51 -04:00
Matthew Chen
812210a63c Modify views to observe changes when active, not just foreground. 2018-05-31 16:31:51 -04:00
Michael Kirk
aa0a31c25e Reduce viewWillAppear by ~5% by optimizing loadForTextDisplay
// FREEBIE
2018-05-31 16:20:53 -04:00
Michael Kirk
97324eaae1 Load less messages initially
// FREEBIE
2018-05-31 16:20:15 -04:00
Matthew Chen
4f520646cc Avoid double layout in conversation view; but carefully. 2018-05-30 17:46:24 -04:00
Michael Kirk
273063e0aa ConversationView first load avoids redundant layout
We are laying out the collection view, invalidating the layout, and then
laying out the collection view again on first appearance of the
conversation view. This is quite expensive - removing it shaves off
about 30% of load time.

// FREEBIE
2018-05-30 17:46:24 -04:00
Matthew Chen
f63d25a172 Migrate to Swift 4. 2018-05-30 15:05:02 -04:00
Matthew Chen
28f7142a59 Auto-migration to Swift 4. 2018-05-30 15:05:02 -04:00
Matthew Chen
5f593bd736 Revert "Add temporary verbose logging around message creation."
This reverts commit f26ad5cd34.
2018-05-29 14:01:11 -04:00
Matthew Chen
0aa8306036 Revert "Add temporary verbose logging around message creation."
This reverts commit 5b0d806a6d.
2018-05-29 14:01:04 -04:00
Matthew Chen
5b0d806a6d Add temporary verbose logging around message creation. 2018-05-29 13:42:49 -04:00
Matthew Chen
f26ad5cd34 Add temporary verbose logging around message creation. 2018-05-29 11:49:42 -04:00
Michael Kirk
2709a91b5e Fixup attachment approval vis-a-vis call banner
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk
1b60716759 Stop worrying about notification order by using delegate pattern
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk
29d08545e2 Use OWSNavigationController instead of UINavigationController
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk
33eb4c38cd Centralize translucency configuration
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk
a2b1793262 initial render is wrong, but settles somewhere nice
-[x] fix initial placement
-[x] add additional top safe area?

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk
3a9391f4fb notes on what didn't work 2018-05-24 12:28:20 -04:00
Michael Kirk
4dbd14ac41 WIP navbar resize
-[ ] CallScreen
  -[x] functional button
  -[ ] needs design
  -[x] disable conversation view call buttons while in call
-[ ] iOS11
  -[x] resize nav content
  -[ ] background showing at top of all vc's
  -[] iPhoneX
    -[x] use differently sized banner for now
    -[] mimic X system design
-[ ] iOS10
  -[x] resize nav content
  -[ ] animation glitch while push/pop
-[ ] iOS9

// FREEBIE
2018-05-24 12:28:20 -04:00
Matthew Chen
e2d9c1187a Fix "group avatar doesn't update after local change." 2018-05-18 15:37:38 -04:00
Matthew Chen
692d0a7579 Don't mark messages as read if conversation view isn't 100% visible. 2018-05-17 16:07:23 -04:00
Matthew Chen
78de7a10f7 Don't mark messages as read if conversation view isn't 100% visible. 2018-05-17 16:07:23 -04:00
Matthew Chen
db1c8fd9f3 Respond to CR. 2018-05-16 17:24:10 -04:00
Matthew Chen
f436fc19c2 Make contact share "bubble/card" reflect share contents. 2018-05-16 17:19:05 -04:00
Matthew Chen
f6106512db Only mark messages read in conversation view if visible. 2018-05-16 16:30:01 -04:00
Michael Kirk
30cef1f084 start readtimer whenever we become active
// FREEBIE
2018-05-15 12:56:47 -04:00
Michael Kirk
117d7319d2 Add contact modally and restore navbar style when dismssing contacts
// FREEBIE
2018-05-14 18:40:56 -04:00
Michael Kirk
2cc3eabdb8 quote reply to contact share (no avatar)
// FREEBIE
2018-05-10 14:34:19 -04:00
Matthew Chen
acdc51ba3d Respond to CR. 2018-05-10 13:17:34 -04:00
Matthew Chen
37b8b368a6 Show "share contact" flow in single presented navigation controller. 2018-05-10 13:17:01 -04:00
Michael Kirk
c15fea4eca merge avatar with existing
// FREEBIE
2018-05-10 11:31:22 -04:00
Michael Kirk
0c469764f1 re-use contact picker for "add to existing"
Required refactor of contact picker to be presented non-modally.

TODO: merge emails, address, display names

// FREEBIE
2018-05-10 11:31:22 -04:00
Michael Kirk
609746abec clarify naming
// FREEBIE
2018-05-10 11:31:22 -04:00
Matthew Chen
4079cdb600 Apply more contact share assets. 2018-05-09 17:51:27 -04:00
Matthew Chen
ff3524fb00 Improve contact share message bubble layout with large dynamic type sizes. 2018-05-09 17:46:05 -04:00
Michael Kirk
42109593af Remove fromViewController state from ContactShareViewHelper
// FREEBIE
2018-05-09 10:21:00 -04:00
Michael Kirk
77bbbad70c Remove contactShare state from ContactShareViewHelper
// FREEBIE
2018-05-09 10:21:00 -04:00
Matthew Chen
c2adf624ea Respond to CR. 2018-05-08 17:22:34 -04:00
Matthew Chen
44ceee5849 Add contact share actions to conversation view and improve phone number parsing. 2018-05-08 17:22:34 -04:00
Michael Kirk
7e22d9e900 Prevent input toolbar from appearing over camera view, contact view or actionsheet
// FREEBIE
2018-05-08 17:07:15 -04:00
Michael Kirk
41aa7eafe3 makeKeyAndVisible restores first responder, so no need to track it
ourselves.

This isn't *quite* as nice for the case when we want to restore a
textfield that was active before, but it much more simply covers the
more important case that we restore input accessory views after
backgrounding/foregrounding.

// FREEBIE
2018-05-08 17:07:15 -04:00
Michael Kirk
fda5d65674 Avoid crash - reply only works from ConversationVC
// FREEBIE
2018-05-08 13:56:28 -04:00
Matthew Chen
bd116f8938 Share contacts from share extension. 2018-05-07 17:04:55 -04:00
Matthew Chen
5f1941f6aa Apply design changes from Myles. 2018-05-07 16:17:16 -04:00
Michael Kirk
a10ae1835e respond to code review
// FREEBIE
2018-05-07 12:51:55 -04:00
Michael Kirk
45f91ead44 Use actual avatar in ContactViewController
// FREEBIE
2018-05-07 12:08:41 -04:00
Michael Kirk
77fc5571fb Implement avatar sending
// FREEBIE
2018-05-07 12:08:41 -04:00
Michael Kirk
5ba5e98260 Show downloaded contact avatar in thread
// FREEBIE
2018-05-07 12:08:41 -04:00
Matthew Chen
fd93bf677e Clean up ahead of PR. 2018-05-04 18:13:22 -04:00
Matthew Chen
6e18d84a10 Add contact share approval view. 2018-05-04 18:13:22 -04:00
Matthew Chen
0c745dd989 Add contact share approval view. 2018-05-04 18:13:22 -04:00
Matthew Chen
1fc401d200 Respond to CR. 2018-05-04 13:34:11 -04:00
Matthew Chen
1a1a043b27 Format phone numbers of contacts. 2018-05-04 13:21:53 -04:00
Matthew Chen
dcf7a05986 Use default avatars for contact shares in contact view. 2018-05-04 13:21:53 -04:00
Matthew Chen
66989b8db7 Use default avatars for contact shares in conversation view. 2018-05-04 13:21:53 -04:00
Matthew Chen
459101c20e Add feature flag for contact sharing. 2018-05-04 09:35:47 -04:00
Matthew Chen
ff6b45abee Respond to CR. 2018-05-03 14:31:11 -04:00
Matthew Chen
91d54360ba Add contact view. 2018-05-03 14:09:54 -04:00
Matthew Chen
2738bcbc58 Create contact view. 2018-05-03 14:09:54 -04:00
Michael Kirk
e604437e24 Don't become first responder while presenting
// FREEBIE
2018-05-03 12:45:48 -04:00
Michael Kirk
5c0c01dea2 Contact picking
// FREEBIE
2018-05-02 11:06:09 -04:00
Matthew Chen
411d5a3b4f Respond to CR. 2018-05-02 11:01:23 -04:00
Matthew Chen
783bf5b81c Clean up ahead of PR. 2018-05-02 10:52:29 -04:00
Matthew Chen
708b44e3c5 Improve handling of contact display names. 2018-05-02 10:52:29 -04:00
Matthew Chen
7e35a7e7d7 Sketch out rendering of contact shares in conversation view. 2018-05-02 10:51:59 -04:00
Matthew Chen
2e06ebfe19 Fix system cell layout. 2018-04-30 10:57:12 -04:00
Matthew Chen
45be54f7ac Design polish for the "profile pic in conversation view" and "archived conversations in home view." 2018-04-26 11:50:33 -04:00
Michael Kirk
b702695793 cleanup 2018-04-26 11:18:18 -04:00
Michael Kirk
55e19b55b3 Fix layout for iOS9/10
code cleanup

// FREEBIE
2018-04-26 11:18:18 -04:00
Michael Kirk
7a1d24a9ab Avatar updates when contact/profile/group photo changes
// FREEBIE
2018-04-26 11:18:18 -04:00
Michael Kirk
b1bff71145 WIP moving to stackview backed header view in conversation view
- iOS10 with large titles doesn't truncate
2018-04-26 11:18:18 -04:00
Matthew Chen
fb0c47aa12 Fix dynamic type issues. 2018-04-25 15:12:52 -04:00
Matthew Chen
204d379603 Respond to CR. 2018-04-25 10:49:19 -04:00
Matthew Chen
40ac0daa9a Respond to CR. 2018-04-25 10:49:19 -04:00
Matthew Chen
9275c67818 Rework outgoing message state. 2018-04-25 10:49:19 -04:00
Matthew Chen
fa9a4c808a Simplify usage of contacts framework. 2018-04-24 13:21:12 -04:00
Michael Kirk
9c81eb44a1 Replace remaining UI usage of interaction.description
// FREEBIE
2018-04-21 19:21:18 -04:00
Michael Kirk
b039fdd276 UI Fix: start with full hourglass on short timer durations
We were positioning relative to "blink" time (2s), rather than delete
time, which means that for 10s timers we were starting as though only 8s
remained.

// FREEBIE
2018-04-18 15:32:01 -04:00
Matthew Chen
a1386eca81 Fix taps in message cells. 2018-04-17 13:28:06 -04:00
Matthew Chen
284cc8c265 Apply attachment type assets. 2018-04-16 16:12:16 -04:00
Matthew Chen
146db1984b Apply attachment type assets. 2018-04-16 16:12:16 -04:00
Michael Kirk
64ff4cd660 tap-to-retry failed thumbnail downloads
// FREEBIE
2018-04-16 16:06:18 -04:00
Matthew Chen
f6d5b9197c Respond to CR. 2018-04-16 12:39:11 -04:00
Matthew Chen
bb9c1fb23d Apply design changes from Myles. 2018-04-16 12:36:30 -04:00
Matthew Chen
6a69070ce9 Apply design changes from Myles. 2018-04-16 12:36:30 -04:00
Matthew Chen
6831412e44 Respond to CR. 2018-04-16 12:14:09 -04:00
Matthew Chen
a5c7bdb987 Don't animate changes to shape layer properties. 2018-04-16 12:08:57 -04:00
Matthew Chen
59a3d736bf Respond to CR. 2018-04-13 15:10:16 -04:00
Matthew Chen
d7ae35f72c Streamline usage of quoted message view. 2018-04-13 15:03:51 -04:00
Matthew Chen
195d357370 Streamline usage of quoted message view. 2018-04-13 15:03:51 -04:00
Matthew Chen
9c93099515 Fix incomplete asserts. 2018-04-13 15:01:25 -04:00
Matthew Chen
6caa5b87b6 Add more asserts around thread in SAE. 2018-04-13 14:59:38 -04:00
Matthew Chen
644e78f19d Respond to CR. 2018-04-13 14:32:42 -04:00
Michael Kirk
e554884ab3 Use profile name in quoted messages, fix "multi account" label
// FREEBIE
2018-04-13 09:53:31 -04:00
Michael Kirk
40879ca3e3 Distinguish between quoting yourself and someone else quoting you
// FREEBIE
2018-04-11 19:21:38 -04:00
Michael Kirk
5774e5769d truncate tail for both preview and message bubble
// FREEBIE
2018-04-11 15:26:09 -04:00
Matthew Chen
576f5dee88 Add white background to images in quoted reply view. 2018-04-11 14:53:59 -04:00
Matthew Chen
fc2704cf88 Label quoted replies to yourself as such. 2018-04-11 14:40:18 -04:00
Matthew Chen
759b2a332f Respond to CR. 2018-04-11 14:18:09 -04:00
Matthew Chen
ea82419a40 Fix long press on quoted reply. 2018-04-11 14:02:07 -04:00
Matthew Chen
031a1d7325 Fix quoted message overflow. 2018-04-11 13:57:17 -04:00
Matthew Chen
ae91b03c71 Add white background to images in conversation view. 2018-04-11 13:45:12 -04:00
Michael Kirk
5320536736 remove WIP comments
// FREEBIE
2018-04-11 11:55:30 -04:00
Michael Kirk
7abd51838f Move bubble actions to new bubble delegate
// FREEBIE
2018-04-11 11:55:30 -04:00
Matthew Chen
f6698501df Revert "Label quoted replies to yourself as such."
This reverts commit 24d7492f61.
2018-04-11 11:48:08 -04:00
Matthew Chen
24d7492f61 Label quoted replies to yourself as such. 2018-04-11 11:47:33 -04:00
Matthew Chen
abba24988c Rework how dates are formatted in home view. 2018-04-11 09:34:37 -04:00
Michael Kirk
6b6f4f9336 Limit caption length
// FREEBIE
2018-04-10 16:00:19 -04:00
Matthew Chen
9769d482da Respond to CR. 2018-04-10 15:56:56 -04:00
Matthew Chen
76995e4594 Enforce quoted reply edge cases. 2018-04-10 15:56:55 -04:00
Matthew Chen
f2b416d800 Respond to CR. 2018-04-10 15:54:46 -04:00
Matthew Chen
8b060a187c Tap on quoted replies. 2018-04-10 15:54:46 -04:00
Matthew Chen
65015e686f Tap on quoted replies. 2018-04-10 15:54:46 -04:00
Matthew Chen
e8ad6bad87 Respond to CR. 2018-04-10 10:53:29 -04:00
Matthew Chen
ebb89ed1fd Tweak message layout. 2018-04-10 10:52:08 -04:00
Michael Kirk
520dad25bb WIP making OWSQuotedMessageView work with preview
// FREEBIE
2018-04-10 10:06:18 -04:00
Michael Kirk
5287ab8f8c Try 2: no more stack view
// FREEBIE
2018-04-10 10:06:18 -04:00
Matthew Chen
8fe289feec Tweak design of quoted replies. 2018-04-09 16:45:42 -04:00
Matthew Chen
3799dce822 Respond to CR. 2018-04-09 14:32:10 -04:00
Matthew Chen
c106a67a52 Use dynamic type everywhere in conversation view. 2018-04-09 14:25:53 -04:00
Matthew Chen
ade2ee7216 Use dynamic type everywhere in conversation view. 2018-04-09 14:25:53 -04:00
Michael Kirk
941b7ec1bc clarify method signature
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
c56e8acc51 QuotedReplyModel from SSK->SignalMessaging
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
1d4c0624be Clarify variable names
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
a9459757f0 Lingering var renames QuotedReplyDraft -> QuotedReplyModel
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
fa2e1ba89b Fetch thumbnail when not available locally
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
cb5d3d4f85 Use QuotedReplyModel to access attachment data
This view model loads the attachment when it's build.

// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
55c6d99d98 populate draft toolbar
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
253435b27f extract QuotedReplyDraft model 2018-04-09 12:47:56 -04:00
Michael Kirk
0b8b3b4f16 WIP: towards avatar attachment streams
// FREEBIE
2018-04-09 12:47:56 -04:00
Michael Kirk
53af41fcc6 Reusable UploadOperation based on extracted OWSOperation
// FREEBIE
2018-04-09 12:47:56 -04:00
Matthew Chen
0dfdb8ce88 Elaborate quoted reply variations to include replies with attachments. 2018-04-06 16:47:21 -04:00
Matthew Chen
de2dc49126 Elaborate quoted reply variations to include replies with attachments. 2018-04-06 16:47:21 -04:00
Matthew Chen
3ee37bd3f0 Respond to CR. 2018-04-06 16:46:36 -04:00
Matthew Chen
2f2d1f81a8 Clean up ahead of PR. 2018-04-06 12:45:16 -04:00
Matthew Chen
6830d4e8cb Apply message bubble view to message details view. 2018-04-06 12:35:46 -04:00
Matthew Chen
d99a2be005 Apply message bubble view to message details view. 2018-04-06 12:35:46 -04:00
Matthew Chen
316b55bf9d Respond to CR. 2018-04-06 12:34:50 -04:00
Matthew Chen
7067085cdd Extract message bubble view. 2018-04-06 12:32:09 -04:00
Matthew Chen
d05b73af28 Extract message bubble view. 2018-04-06 12:32:09 -04:00
Matthew Chen
d1060a2a85 Extract message bubble view. 2018-04-06 12:32:09 -04:00
Matthew Chen
7f0fa1228e Extract message bubble view. 2018-04-06 12:32:09 -04:00
Matthew Chen
c5d8a7cb38 Clean up ahead of PR. 2018-04-05 11:15:00 -04:00
Matthew Chen
f6aa3f89b7 Clean up ahead of PR. 2018-04-05 10:58:55 -04:00
Matthew Chen
ca4757b8d1 Clean up ahead of PR. 2018-04-05 10:57:51 -04:00
Matthew Chen
71c5c3a4b7 Refine appearance of quoted reply message cells. 2018-04-05 10:39:07 -04:00
Matthew Chen
8a843f70e3 Refine the attachments in the quoted reply view. 2018-04-05 10:38:34 -04:00
Matthew Chen
822aa64b14 Respond to CR. 2018-04-05 10:35:57 -04:00
Matthew Chen
cac85508cc Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Matthew Chen
7e921b7935 Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Matthew Chen
08ba3852cd Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Matthew Chen
5235f6eee9 Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Matthew Chen
d6f3df82ae Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Matthew Chen
c70f911f6f Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Matthew Chen
6171505657 Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Matthew Chen
10b4ade55a Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Matthew Chen
3343b4ec58 Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Matthew Chen
9085609087 Fix interaction initializers and tests. 2018-04-05 09:36:52 -04:00
Michael Kirk
51eee90bb7 Remove unnecessary changes
// FREEBIE
2018-04-04 10:59:05 -04:00
Michael Kirk
bf401bad90 Send quoted messages
MVP

- [x] populate from menu
- [x] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
2018-04-04 10:59:04 -04:00
Michael Kirk
d99054d895 Reply menu item
MVP

- [x] populate from menu
- [] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
2018-04-04 10:59:04 -04:00
Michael Kirk
6874a9e28e Convert to swift
// FREEBIE
2018-04-04 10:59:04 -04:00
Michael Kirk
cfbbeca7ac WIP: QuotedMessagePreviewView
MVP

- [] populate from menu
- [] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
2018-04-04 10:59:03 -04:00
Matthew Chen
00a81355d6 Respond to CR. 2018-04-04 10:27:30 -04:00
Matthew Chen
324afb1152 Modify cells to show quoted messages. 2018-04-04 10:12:07 -04:00
Matthew Chen
5824cbd2a8 Modify cells to show quoted messages. 2018-04-04 10:12:07 -04:00
Matthew Chen
988b6ffae7 Modify cells to show quoted messages. 2018-04-04 10:12:07 -04:00
Matthew Chen
f6f98369a6 Modify cells to show quoted messages. 2018-04-04 10:12:07 -04:00
Matthew Chen
22dc904283 Modify cells to show quoted messages. 2018-04-04 10:12:07 -04:00
Matthew Chen
2278cdd589 Modify cells to show quoted messages. 2018-04-04 10:12:07 -04:00
Matthew Chen
7cf169012c Elaborate conversation view items around quoted replies. 2018-04-04 10:12:07 -04:00
Matthew Chen
c36297a9ad Elaborate 'quoted reply' variations in the Debug UI. 2018-04-03 13:42:21 -04:00
Matthew Chen
d5218cf4d9 Simplify bubble edge. 2018-04-03 13:40:29 -04:00
Michael Kirk
00e5e1b0d6 Fixup some tests
// FREEBIE
2018-04-03 11:29:05 -04:00
Michael Kirk
f441c6211d Format
// FREEBIE
2018-04-02 17:02:32 -04:00
Michael Kirk
6f1608f44b Conventional naming for out custom PureLayout methods.
This moves methods more in line with PureLayout conventions.

- Methods always specify if they pin to an edge vs margin

- `margin` is a reserved word which should only refer to layout margins.
  i.e. do not use it to refer to "inset" and "offset".

// FREEBIE
2018-04-02 17:02:32 -04:00
Matthew Chen
4240b517d0 Respond to CR. 2018-04-02 16:17:46 -04:00
Matthew Chen
fb1f3b5572 Rework quoted reply debug UI. 2018-04-02 16:17:46 -04:00
Matthew Chen
4915c127cb Rework quoted reply debug UI. 2018-04-02 16:17:46 -04:00
Matthew Chen
8e4f2ca0ed Rework proto schema changes for quoted replies.
Sketch out model changes for quoted replies.

Sketch out quoted reply input preview.

Send quoted messages protos.

Update models to reflect quoted messages.

Rework interaction initializers.

Rework interaction initializers.

Add debug UI methods for generating quoted reply variations.

Add debug UI methods for generating quoted reply variations.
2018-04-02 16:17:46 -04:00
Matthew Chen
1bea832faa Fix assert in bubble views. 2018-04-02 15:59:30 -04:00
Matthew Chen
f98c45603c Respond to CR. 2018-04-02 11:13:11 -04:00
Matthew Chen
12bcf887c1 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
4f9085a761 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
3ca2c08b06 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
578f40d791 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
c8012d3891 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
3d07dc7c5b Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
8d74c68f9d Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
8a74e10208 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
e0e8eafb5d Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
e1e6606783 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
cb00b22870 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
6525ccdb05 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
75177ef00f Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen
3a5ba15d21 Elaborate debug UI for messages. 2018-04-02 10:07:15 -04:00
Matthew Chen
c2e31540d7 Elaborate debug UI for messages. 2018-04-02 10:06:45 -04:00
Michael Kirk
394cc6637c Backport comments from translations
// FREEBIE
2018-03-26 10:12:04 -04:00
Michael Kirk
6c877403cf Fix delete from message details
// FREEBIE
2018-03-22 19:54:19 -04:00
Michael Kirk
00b5316976 Don't show the "All Media" button when viewing the slider from the
gallery via settings.

In this context it makes more sense for the user to hit the "dismiss"
button to get "back" to "All Media"

// FREEBIE
2018-03-20 11:12:11 -04:00
Michael Kirk
ae8dbeb8dd Access Media Gallery from conversation settings
// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk
dfd628250d Gallery performance
- [x] share uiDatabaseConnection to share cache
- [x] increase cache size
- [x] load less initially
- [x] lazy loading
  - [x] slider view
  - [x] tile view

// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk
985af76d0b WIP: All Media view
TODO

- [ ] label video/gif
- [ ] reasonable load perf
- [ ] reasonable scroll perf
- [ ] select / delete
- [ ] cancel share action from media details returns signal style

NICE TO HAVE

- [ ] fancy in/out animation from All Media <-> tiles
- [ ] label video thumbnail with duration stamp
- [ ] Other perf?
- [ ] dbModified?
- [ ] select / send
- [ ] darken section header a shade once it's "active"

DONE

- [x] tap to refocus on new media
- [x] generate test data
- [x] section headers
- [x] equal spacing around cells

// FREEBIE

WIP WIP extract datasouce to GalleryViewController

- [x] swipe through is broken
- [x] present animation
- [x] dismiss animation

// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk
4ac9a1019b Media page view controller
First pass at a swipe-through media view for conversations.

Future work could include

- title label per item
  - sender name
  - date/time
- photo rail
- include caption

// FREEBIE
2018-03-16 15:55:34 -04:00
Michael Kirk
88e1386720 Move frame to presentation logic, out of init
This no longer made sense now that we're using this in a
PageViewController we won't always be zooming from a particular frame.

TODO:

- why is background image all wonky?
- why aren't views created by the time it's presented? Is that a
regression? (how is self.view a MenuView if loadView hasn't been called)

// FREEBIE
2018-03-14 12:50:27 -04:00
Matthew Chen
b296cfb893 Sketch out incremental backup manager and settings view. 2018-03-12 16:40:07 -03:00
Michael Kirk
a1de99f1f1 Merge tag '2.21.0.9' 2018-03-06 16:43:33 -05:00
Matthew Chen
d6f4db1523 Rename TSStorageManager to OWSPrimaryStorage. 2018-03-06 17:12:13 -03:00
Michael Kirk
d7fcac8a5a In-App notifications don't pause background audio
// FREEBIE
2018-03-05 17:59:09 -05:00
Michael Kirk
07ee3ea843 Merge tag '2.21.0.5' 2018-03-05 09:54:06 -05:00
Michael Kirk
6077367e66 Notification sounds should respect silent switch
// FREEBIE
2018-03-03 11:33:31 -05:00
Matthew Chen
baf6fcc535 Add 2FA registration view. 2018-03-02 10:55:00 -05:00
Matthew Chen
e12a1e984a Work on two-factor auth settings UI. 2018-03-01 15:38:59 -05:00
Matthew Chen
38ff82ab97 Rebrand OWSAudioPlayer. 2018-02-26 14:47:57 -05:00
Matthew Chen
99aedca45f Strip out special casing for pre-iOS 9 users. 2018-02-26 14:13:38 -05:00
Matthew Chen
81629a87df Fix build break. 2018-02-22 13:31:41 -05:00
Matthew Chen
152c570900 Respond to CR. 2018-02-22 12:07:11 -05:00
Matthew Chen
03670b4868 Rename the view horizon. 2018-02-22 11:46:08 -05:00
Matthew Chen
fabbe46114 Clean up ahead of PR. 2018-02-22 11:46:08 -05:00
Matthew Chen
4e1e232825 Flush writes from other processes. 2018-02-22 11:46:08 -05:00
Matthew Chen
1ff4f85247 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Matthew Chen
2ac7716771 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Michael Kirk
5ba5d3f524 Remove "Share" from edit menu
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.

Specifically:

- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
  share extension (could be the Signal share extension or another app's
  share extension)
- the conversation view (which is rendered behind the share extension)
  regains first responder, causing the input toolbar to appear above the
  share extension

One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.

// FREEBIE
2018-02-22 08:57:58 -05:00
Michael Kirk
d7f8c3e9d3 Ensure inputAccessory doesn't obscure the SN alert
This affects iOS 8, 9, and to a lesser degree iOS10.
On iOS11, presenting an alert causes the keyboard/inputAccessoryView to
temporarily dismiss.

// FREEBIE
2018-02-21 16:35:46 -05:00
Michael Kirk
abb51b565a Don't de-activate audio sesion when other audio activities are happening
// FREEBIE
2018-02-16 14:00:15 -08:00
Matthew Chen
ceaf028445 Always scroll to bottom after sending attachments. 2018-02-16 14:06:46 -05:00
Matthew Chen
e3776015bb Respond to CR. 2018-02-13 10:49:54 -05:00
Matthew Chen
246a56e925 Respond to CR. 2018-02-13 10:49:54 -05:00
Matthew Chen
33686594e9 Tweak debug logging. 2018-02-13 10:49:54 -05:00
Matthew Chen
ba42ac73d8 Revisit TODOs in the SAE work. 2018-02-12 22:33:26 -05:00
Matthew Chen
bd0f601792 Respond to CR. 2018-02-09 10:31:29 -05:00
Matthew Chen
43765ef3b5 Respond to CR. 2018-02-09 10:31:29 -05:00
Matthew Chen
bbd689bfd0 Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Matthew Chen
d3e16583eb Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Michael Kirk
c646f76335 Garther audio concerns, clean up session when done
- sync speakerphone state manipulated from system call screen
  - Revert audio session after call failure, ensures media plays out of
    speaker after placing a failing call.
  - Replace notification with delegate pattern since we're already using
    delegate pattern here.
- Fixes voiceover accessibility after voice memo
- Avoid audio blip after pressing hangup
- Rename CallAudioSession -> OWSAudioSession
  Going to start using it for other non-call things since we want to
  gather all our audio session concerns.
- Resume background audio when done playing video
  - Extract OWSVideoPlayer which ensures audio is in proper state before
    playback
  - Move recording session logic to shared OWSAudioSession
  - Deactivate audio session when complete

// FREEBIE
2018-02-06 18:45:51 -08:00
Michael Kirk
7734958eec Make "swipe for info" RTL compatible
// FREEBIE
2018-02-02 11:18:12 -08:00
Michael Kirk
54f7c298b7 Only initiate "show details" pan gesture when swiping back
// FREEBIE
2018-02-02 11:18:12 -08:00
Michael Kirk
e39ca59eeb Merge tag '2.19.5.0' 2018-02-01 14:03:43 -08:00
Matthew Chen
fa76e524c4 Respond to CR. 2018-01-30 10:15:15 -05:00
Matthew Chen
9c84bdb105 Add support for images as documents. 2018-01-30 10:12:08 -05:00
Matthew Chen
3609275c20 Handle malformed row updates. 2018-01-30 10:06:46 -05:00
Matthew Chen
069587b150 Add message approval view. 2018-01-25 13:27:16 -05:00
Matthew Chen
992e926142 Unpack oversize text messages if possible. 2018-01-25 13:26:10 -05:00
Matthew Chen
b9bd21e73f Improve presentation of text attachments in attachment approval view. 2018-01-25 13:24:22 -05:00