Commit Graph

5937 Commits

Author SHA1 Message Date
Kevin Ansfield 5606b9c068 Implemented first iteration of content snippets
closes https://github.com/TryGhost/Team/issues/411

- adds "Create snippet" icon to the editor toolbar
- uses the same link input component design for specifying snippet titles
- snippets are loaded in the background when the editor is accessed
- snippets are listed at the bottom of the card menus of the + and / menus
- clicking a snippet inserts the snippet's contents in place of the current blank section
2020-10-15 18:03:35 +01:00
Peter Zimon 8a394aea8e Fixed 'null' portal button text
no refs.
- fixing portal button displaying 'null' if the portal button text input field is empty
2020-10-14 14:47:08 +02:00
Kevin Ansfield 738e1e1a05 Lock file maintenance 2020-10-14 12:55:06 +01:00
renovate[bot] f18588724c
Update dependency ember-cli-app-version to v4 (#1724)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-14 10:21:20 +01:00
renovate[bot] a302a0ca53
Update dependency ember-truth-helpers to v3 (#1723)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-14 10:20:56 +01:00
Renovate Bot 288a3ece23
Update dependency ember-exam to v6 2020-10-12 21:55:26 +00:00
Peter Zimon 09bced72bb Updated Portal links design
no refs.
- in Portal settings domain and the path are separated visually so that it conveys the concept of using the relative URL instead of absolute
- for similar reasons, copy link copies only the path part
2020-10-12 13:56:37 +02:00
Renovate Bot 2b1bf70b91
Update dependency eslint to v7.11.0 2020-10-09 21:05:56 +00:00
Peter Zimon a4e8efb639 Fixed test for scheduling copy change
no refs.
2020-10-09 17:15:21 +02:00
Peter Zimon 2654dcc432 Removed full stop from scheduling text in editor
no refs.
2020-10-09 16:56:37 +02:00
Peter Zimon 4f8f19695f Fixed account menu margin
no refs.
- fixes account menu dropdown button margins disappearing on Firefox for smaller screensizes
2020-10-09 16:56:13 +02:00
Kevin Ansfield 43d55e2c60 Fixed usage of {{enable-developer-experiments}} without sub-expression syntax 2020-10-09 15:52:23 +01:00
Kevin Ansfield a4338ca21f Added developer experiments indication to about page
no issue

- without this there's no indication the config flag is set when you have no access to the config file or you don't know which features are currently behind the flag
2020-10-09 11:38:47 +01:00
Kevin Ansfield 0672f14b8e Added {{enable-developer-experiments}} helper
no issue

- removes the need to have component backing classes with the `config` service injected
2020-10-09 11:10:39 +01:00
Daniel Lockyer c534b74746 v3.35.5 2020-10-08 11:00:35 +01:00
Daniel Lockyer 33d5cb2edf v3.35.4 2020-10-06 09:55:49 +01:00
Kevin Ansfield 68efc5bff3 Resolved "already declared in upper scope" linting warnings
no issue

- fixed all `no-shadow` linter warnings
- changed `no-shadow` eslint rule from `warn` to `error` so we don't re-introduce shadowed variables in the future
2020-10-05 09:56:21 +01:00
renovate[bot] 88f1291e16
Update dependency ember-power-select to v4.0.5 (#1721)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-05 09:09:39 +01:00
renovate[bot] 78837f7a82
Update dependency @tryghost/timezone-data to v0.2.28 (#1719)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-05 09:09:26 +01:00
Sam Lord c6efa32c97 v3.35.3 2020-10-02 14:38:32 +01:00
Peter Zimon 46a1b4f8bb Updated scheduling copy
no refs.
- updated moment locale to display '1 minute' instead of 'a minute' to be more explicit about scheduled time
- removed full stop from the scheduler message in editor header
2020-10-02 10:45:49 +02:00
Sam Lord 0a3e80dcb4 v3.35.2 2020-10-01 19:57:13 +01:00
Sam Lord 38dae6773c v3.35.1 2020-10-01 19:21:26 +01:00
Kevin Ansfield fc7cb76309 Fixed content jiggle when selecting cards and card code background position
no issue

- borders are necessary on selected cards to keep consistent spacing between selected/non-selected cards
  - use transparent borders in dark mode rather than eliminating borders
- moved transparent card background style to `_koenig-dark.css` so it only affects dark mode - we want to keep the background colour for light mode so that we don't get mis-aligned backgrounds in certain cards
2020-10-01 16:56:30 +01:00
Kevin Ansfield 8fe6d76137 🐛 Fixed first set of members appearing twice in members list
closes https://github.com/TryGhost/Ghost/issues/12241

- `ella-sparse` exposes a `range.page` property which we can use instead of trying to calculate the page number ourselves
2020-10-01 11:21:34 +01:00
Kevin Ansfield 4ac3f3643f Update dependency ember-in-viewport to v3.8.0
no issue

- now that we no longer have the `ember-sticky-element` dependency we're free to upgrade `ember-in-viewport`
- remove package.json resolution so latest version gets installed
- remove ember-in-viewport from renovate ignore config
- update `<GhScrollTrigger>` to match latest `ember-in-viewport` usage and convert to a glimmer component
  - ensure `scrollableArea` is always set so that the trigger doesn't stop working after the first trigger
2020-10-01 10:06:53 +01:00
Kevin Ansfield a0db65f5df Removed ember-sticky-element in favour of native `position: sticky`
no issue

- native `position: sticky` support is now good enough across the board of our supported browser versions to use in place of a JS version for our use cases
- `ember-sticky-element` is preventing the dependency update of `ember-in-viewport` so removing it will allow a lot of our sub-dependencies to be updated
2020-10-01 10:02:27 +01:00
Kevin Ansfield f50c66964b Lock file maintenance 2020-10-01 08:02:06 +01:00
Rish bc084fda9b Allowed empty accent color in portal preview
no issue

- Current logic was not setting empty accent color in portal preview which was misleading when no accent color is set
- Updated preview url to contain empty accent color which is picked by Portal preview
2020-10-01 12:28:24 +05:30
renovate[bot] 14e7748884
Update ember core (#1704)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-01 07:57:12 +01:00
renovate[bot] 5a91cf881e
Lock file maintenance (#1720)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-01 07:44:44 +01:00
renovate[bot] 10fc25a081
Update dependency @tryghost/string to v0.1.12 (#1718)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-01 07:42:18 +01:00
renovate[bot] 9f5db06652
Update dependency @tryghost/helpers to v1.1.31 (#1717)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-10-01 07:41:58 +01:00
Sam Lord 9a82624cde v3.35.0 2020-09-30 11:00:13 +01:00
Fabien O'Carroll 254a2dafed Updated magic link expiry information to 24 hours
no-issue

Since https://github.com/TryGhost/Ghost/commit/fd5194ea magic links have
a 24 hour expiry
2020-09-30 10:56:12 +01:00
Kevin Ansfield 76a60aee1f Adjusted browser support to include Safari 12
no issue

- Safari 12 support was automatically dropped when Safari 14 was released this September. This created quite a step-change in level of JS that is left as native in the build output causing problems for users who haven't upgraded or are stuck on browser versions ~1yr old
- adjusted the browser support to include last 3 versions of Safari, giving another year (most likely based on Apple's historic release schedule) of older browser support
2020-09-30 09:48:47 +01:00
Fabien 'egg' O'Carroll 232cafaa8f
🐛 Fixed tag metadata fields not being populated when editing in admin (#1714)
closes #12190

The "scratch" concept was being used incorrectly for codeinjection fields and was not initialised with all the required fields.
2020-09-28 16:20:53 +01:00
Peter Zimon e76439d072 Fixed publication logo display proportions
no refs.
- fixed the styles for publication logo in general settings so that the logo is displayed with correct ratio regardless of its proportions
2020-09-28 14:14:16 +02:00
Renovate Bot 0b96959531
Update dependency eslint to v7.10.0 2020-09-28 00:05:51 +00:00
Daniel Lockyer 924087b7b9 Merged 3.34.1 into master
v3.34.1

* tag '3.34.1':
  v3.34.1
2020-09-24 19:29:19 +01:00
Daniel Lockyer a80e2681f1 v3.34.1 2020-09-24 19:26:52 +01:00
Peter Zimon 5f776dddcc Fixed loading spinner size for Portal icons
no refs.
- fixed oversized loading spinner for Portal icons
2020-09-24 10:00:22 +02:00
Peter Zimon 5bb273af02 Updated order of default Portal icons
no refs.
- swapped icon no. 3 and 4 to represent major use cases better
2020-09-24 09:50:33 +02:00
Rish d0e696e6dc Renamed members-modal naming to portal
no issue

- Updated naming for members modal to portal in sync with rest of the codebase
2020-09-24 12:19:35 +05:30
Fabien 'egg' O'Carroll 56df9d4b5e
Added support for filtering the exported Members CSV (#1716)
no-issue

Co-authored-by: Peter Zimon <zimo@ghost.org>
2020-09-23 14:29:47 +01:00
Rishabh Garg cba35bf625
🐛 Fixed social settings not saved on keyboard shortcut (#1633)
no issue

- Social account(twitter/facebook) values in general settings were only updated to settings upstream on focus out
- Uses `notifyPropertyChange` to avoid multiple `.set()` workarounds

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2020-09-23 16:58:48 +05:30
Daniel Lockyer 6189c91e56 v3.34.0 2020-09-22 11:25:12 +01:00
renovate[bot] 9abbacf995
Update dependency grunt to v1.3.0 (#1682)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-09-22 08:52:04 +01:00
Umur Dinçer b76dd44336
🐛 Fixed missing start date in members chart (#1644)
closes https://github.com/TryGhost/Ghost/issues/12014

- `startDateLabel` was never populated after refactoring the members chart to use the members stats service
- use the first date that's returned as part of the members stats days array so that we can account for any potential time period being selected

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
2020-09-22 08:51:29 +01:00
Paul Davis eba9f0eac0
Added margin to bottom of Admin when installed as PWA on newer iOS devices (#1667)
no issue

On newer iOS devices with no home button, we have this bar at the bottom of the screen instead. When installed as a PWA, the mobile nav sits under that bar. I'm unsure how much Ghost is used this way, but this is a small QOL improvement for those who do.

This PR uses the native `env` CSS custom properties Safari has to add a propriety amount of `padding-bottom` to the mobile nav bar, and also the global container to prevent anything in the iframe from being hidden by the taller nav bar. If the device does not support these `env` vars, is has no adverse affect. In order for this to work, the `<meta name="viewport" />` tag needs `viewport-fit=cover` added to it.

MDN docs for reference: https://developer.mozilla.org/en-US/docs/Web/CSS/env
2020-09-22 07:43:17 +01:00